From: Karen Etheridge <ether@cpan.org>
Date: Wed, 3 Apr 2013 21:21:58 +0000 (-0700)
Subject: RT#84246 - Term::ReadLine issues
X-Git-Tag: v1.003017~1
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2FDevel-REPL.git;a=commitdiff_plain;h=d6d183430fa16815ee449fb2792152636d7cfba8

RT#84246 - Term::ReadLine issues
---

diff --git a/Changes b/Changes
index e1f812d..742e910 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,8 @@
 Revision history for Devel-REPL
 
+  - fix issues with Term::ReadLine:PERL in tests (RT#84246) (thanks,
+    Christopher McCann!)
+
 1.003016 - 2013-03-26
   - make all plugins load again by using native traits (thanks, Zaki Mughal!)
     (RT#84011)
diff --git a/t/load_plugins.t b/t/load_plugins.t
index 84ec53a..d3ff2e3 100755
--- a/t/load_plugins.t
+++ b/t/load_plugins.t
@@ -1,3 +1,4 @@
+
 use strict;
 use warnings;
 
@@ -38,13 +39,20 @@ Timing
 Turtles
 /;
 
+# one $repl is shared:
+# "Looks like the problem is that you can't open multiple instances of
+# Term::ReadLine:PERL from the same object.  I was able to correct this by
+# changing the test to reuse the same Devel::REPL instance each time.  This
+# prevents the warning that causes the test to fail.  I don't think this
+# changes the spirit of the test, it's just a byproduct of how
+# Term::ReadLine::Perl works." -- RT#84246
+my $repl = Devel::REPL->new;
 for my $plugin_name (@plugins) {
     test_load_plugin($plugin_name);
 }
 
 sub test_load_plugin {
     my ($plugin_name) = @_;
-    my $repl = Devel::REPL->new;
     my $test_name = "plugin $plugin_name loaded";
     eval "use Devel::REPL::Plugin::$plugin_name";
     unless($@) {