From: Sartak Date: Sat, 22 Sep 2007 01:07:54 +0000 (+0000) Subject: Remove -e switch, but refactor load_rcfile to make it easy to use the "do FILE" like... X-Git-Tag: v1.003015~146 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2FDevel-REPL.git;a=commitdiff_plain;h=cb3b891f24d8cf8b0b669bcb9cbb1135df12dace Remove -e switch, but refactor load_rcfile to make it easy to use the "do FILE" like behavior git-svn-id: http://dev.catalyst.perl.org/repos/bast/trunk/Devel-REPL@3776 bd8105ee-0ff8-0310-8827-fb3f25b6796d --- diff --git a/lib/Devel/REPL/Script.pm b/lib/Devel/REPL/Script.pm index 6da9202..aab0cc2 100644 --- a/lib/Devel/REPL/Script.pm +++ b/lib/Devel/REPL/Script.pm @@ -17,10 +17,6 @@ has 'profile' => ( is => 'ro', isa => 'Str', required => 1, default => sub { 'Default' }, ); -has 'e' => ( - is => 'ro', isa => 'ArrayRef', default => sub { [] }, -); - has '_repl' => ( is => 'ro', isa => 'Devel::REPL', required => 1, default => sub { Devel::REPL->new() } @@ -30,7 +26,6 @@ sub BUILD { my ($self) = @_; $self->load_profile($self->profile); $self->load_rcfile($self->rcfile); - $self->load_scripts($self->e); } sub load_profile { @@ -50,25 +45,30 @@ sub load_rcfile { $rc_file = File::Spec->catfile(File::HomeDir->my_home, '.re.pl', $rc_file); } - if (-r $rc_file) { - open RCFILE, '<', $rc_file || die "Couldn't open ${rc_file}: $!"; - my $rc_data; - { local $/; $rc_data = ; } - close RCFILE; # Don't care if this fails - $self->eval_rcdata($rc_data); - warn "Error executing rc file ${rc_file}: $@\n" if $@; - } + $self->apply_script($rc_file); } -sub load_scripts { - my ($self, $scripts) = @_; +sub apply_script { + my ($self, $script, $warn_on_unreadable) = @_; - for (@$scripts) { - do $_; + if (!-e $script) { + warn "File '$script' does not exist" if $warn_on_unreadable; + return; } + elsif (!-r _) { + warn "File '$script' is unreadable" if $warn_on_unreadable; + return; + } + + open RCFILE, '<', $script or die "Couldn't open ${script}: $!"; + my $rc_data; + { local $/; $rc_data = ; } + close RCFILE; # Don't care if this fails + $self->eval_script($rc_data); + warn "Error executing script ${script}: $@\n" if $@; } -sub eval_rcdata { +sub eval_script { my ($self, $data) = @_; local $CURRENT_SCRIPT = $self; $self->_repl->eval($data);