X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2FDevel-REPL.git;a=blobdiff_plain;f=lib%2FDevel%2FREPL%2FPlugin%2FMultiLine%2FPPI.pm;h=ca858068b6ee7ee8a6e71c9f04daf0418a5d065d;hp=f0f9f9a9b1cfd94b18e11bf53a5989cd842b265f;hb=b595a818b1d89dbea55ace1af86d0df91c97ba0c;hpb=d8153bec650b92d2cd68449a148c393c51e877e9 diff --git a/lib/Devel/REPL/Plugin/MultiLine/PPI.pm b/lib/Devel/REPL/Plugin/MultiLine/PPI.pm index f0f9f9a..ca85806 100644 --- a/lib/Devel/REPL/Plugin/MultiLine/PPI.pm +++ b/lib/Devel/REPL/Plugin/MultiLine/PPI.pm @@ -2,15 +2,17 @@ package Devel::REPL::Plugin::MultiLine::PPI; use Devel::REPL::Plugin; use PPI; -use namespace::clean -except => [ 'meta' ]; +use namespace::autoclean; has 'continuation_prompt' => ( - is => 'rw', required => 1, lazy => 1, + is => 'rw', + lazy => 1, default => sub { '> ' } ); has 'line_depth' => ( - is => 'rw', required => 1, lazy => 1, + is => 'rw', + lazy => 1, default => sub { 0 } ); @@ -57,16 +59,12 @@ sub line_needs_continuation $line .= "\n;;"; my $document = PPI::Document->new(\$line); - unless ( defined($document) ) { - die "PPI failed to parse document '$line'\n"; - } + return 0 if !defined($document); # adding ";" to a complete document adds a PPI::Statement::Null. we added a ;; # so if it doesn't end in null then there's probably something that's # incomplete - unless ( $document->child(-1)->isa('PPI::Statement::Null') ) { - return 1; - } + return 0 if $document->child(-1)->isa('PPI::Statement::Null'); # this could use more logic, such as returning 1 on s/foo/ba my $unfinished_structure = sub