X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2FDevel-REPL.git;a=blobdiff_plain;f=lib%2FDevel%2FREPL%2FPlugin%2FMultiLine%2FPPI.pm;h=1f23cfc5e2b23db0493b7b69fc116a7486552422;hp=a812b27b1e06293fe97b32e620d099926434a502;hb=d954e450ff6824b77a888ce2a44019bdfe560d1b;hpb=49946f5ce52c6859a628226f36c7c99ae7a65069

diff --git a/lib/Devel/REPL/Plugin/MultiLine/PPI.pm b/lib/Devel/REPL/Plugin/MultiLine/PPI.pm
index a812b27..1f23cfc 100644
--- a/lib/Devel/REPL/Plugin/MultiLine/PPI.pm
+++ b/lib/Devel/REPL/Plugin/MultiLine/PPI.pm
@@ -1,6 +1,6 @@
 package Devel::REPL::Plugin::MultiLine::PPI;
 
-use Moose::Role;
+use Devel::REPL::Plugin;
 use PPI;
 use namespace::clean -except => [ 'meta' ];
 
@@ -20,38 +20,56 @@ around 'read' => sub {
   my $line = $self->$orig(@args);
 
   if (defined $line) {
-    while ($self->line_needs_continuation($line)) {
-      my $orig_prompt = $self->prompt;
-      $self->prompt($self->continuation_prompt);
+    return $self->continue_reading_if_necessary($line, @args);
+  } else {
+    return $line;
+  }
+};
+
+sub continue_reading_if_necessary {
+  my ( $self, $line, @args ) = @_;
 
-      $self->line_depth($self->line_depth + 1);
-      my $append = $self->read(@args);
-      $self->line_depth($self->line_depth - 1);
+  while ($self->line_needs_continuation($line)) {
+    my $orig_prompt = $self->prompt;
+    $self->prompt($self->continuation_prompt);
 
-      $line .= $append if defined($append);
+    $self->line_depth($self->line_depth + 1);
+    my $append = $self->read(@args);
+    $self->line_depth($self->line_depth - 1);
 
-      $self->prompt($orig_prompt);
+    $line .= "\n$append" if defined($append);
 
-      # ^D means "shut up and eval already"
-      return $line if !defined($append);
-    }
+    $self->prompt($orig_prompt);
+
+    # ^D means "shut up and eval already"
+    return $line if !defined($append);
   }
+
   return $line;
-};
+}
 
 sub line_needs_continuation
 {
   my $repl = shift;
   my $line = shift;
+
+  # add this so we can test whether the document ends in PPI::Statement::Null
+  $line .= "\n;;";
+
   my $document = PPI::Document->new(\$line);
   return 0 if !defined($document);
 
+  # adding ";" to a complete document adds a PPI::Statement::Null. we added a ;;
+  # so if it doesn't end in null then there's probably something that's
+  # incomplete
+  return 0 if $document->child(-1)->isa('PPI::Statement::Null');
+
   # this could use more logic, such as returning 1 on s/foo/ba<Enter>
   my $unfinished_structure = sub
   {
     my ($document, $element) = @_;
     return 0 unless $element->isa('PPI::Structure');
-    return 1 unless $element->start && $element->finish;
+    return 1 unless $element->finish;
     return 0;
   };