X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2FDevel-REPL.git;a=blobdiff_plain;f=lib%2FDevel%2FREPL%2FPlugin%2FMultiLine%2FPPI.pm;h=1f23cfc5e2b23db0493b7b69fc116a7486552422;hp=1db70efeb854670e58386b9aae8c63089725acf3;hb=2fd5e0773dda71e35884cc04dbc67c13c06d902e;hpb=4ea2c25425ec86ef71282ea6f5a04f153e3648ed diff --git a/lib/Devel/REPL/Plugin/MultiLine/PPI.pm b/lib/Devel/REPL/Plugin/MultiLine/PPI.pm index 1db70ef..1f23cfc 100644 --- a/lib/Devel/REPL/Plugin/MultiLine/PPI.pm +++ b/lib/Devel/REPL/Plugin/MultiLine/PPI.pm @@ -52,15 +52,24 @@ sub line_needs_continuation { my $repl = shift; my $line = shift; + + # add this so we can test whether the document ends in PPI::Statement::Null + $line .= "\n;;"; + my $document = PPI::Document->new(\$line); return 0 if !defined($document); + # adding ";" to a complete document adds a PPI::Statement::Null. we added a ;; + # so if it doesn't end in null then there's probably something that's + # incomplete + return 0 if $document->child(-1)->isa('PPI::Statement::Null'); + # this could use more logic, such as returning 1 on s/foo/ba my $unfinished_structure = sub { my ($document, $element) = @_; return 0 unless $element->isa('PPI::Structure'); - return 1 unless $element->start && $element->finish; + return 1 unless $element->finish; return 0; };