remove pointless "required" fields for attrs with defaults/builders

[p5sagit/Devel-REPL.git] / lib / Devel / REPL / Plugin / MultiLine / PPI.pm

diff --git a/lib/Devel/REPL/Plugin/MultiLine/PPI.pm b/lib/Devel/REPL/Plugin/MultiLine/PPI.pm
index f0f9f9a..ca85806 100644 (file)
--- a/lib/Devel/REPL/Plugin/MultiLine/PPI.pm
+++ b/lib/Devel/REPL/Plugin/MultiLine/PPI.pm
@@ -2,15 +2,17 @@ package Devel::REPL::Plugin::MultiLine::PPI;
 
 use Devel::REPL::Plugin;
 use PPI;
-use namespace::clean -except => [ 'meta' ];
+use namespace::autoclean;
 
 has 'continuation_prompt' => (
-  is => 'rw', required => 1, lazy => 1,
+  is => 'rw',
+  lazy => 1,
   default => sub { '> ' }
 );
 
 has 'line_depth' => (
-  is => 'rw', required => 1, lazy => 1,
+  is => 'rw',
+  lazy => 1,
   default => sub { 0 }
 );
 
@@ -57,16 +59,12 @@ sub line_needs_continuation
   $line .= "\n;;";
 
   my $document = PPI::Document->new(\$line);
-  unless ( defined($document) ) {
-     die "PPI failed to parse document '$line'\n";
-  }
+  return 0 if !defined($document);
 
   # adding ";" to a complete document adds a PPI::Statement::Null. we added a ;;
   # so if it doesn't end in null then there's probably something that's
   # incomplete
-  unless ( $document->child(-1)->isa('PPI::Statement::Null') ) {
-     return 1;
-  }
+  return 0 if $document->child(-1)->isa('PPI::Statement::Null');
 
   # this could use more logic, such as returning 1 on s/foo/ba<Enter>
   my $unfinished_structure = sub