X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2FConfig-Any.git;a=blobdiff_plain;f=lib%2FConfig%2FAny%2FGeneral.pm;h=db32022b709b1f7a982654f99a9ea30158793f20;hp=d16cf595cf8753e6fe7ead2de3663601bbcfd9b1;hb=257737f9fe6767883962406974f9c53a1d2dbb1c;hpb=82222eccd9a0ff010db060d9cc4e11bbed9ee924 diff --git a/lib/Config/Any/General.pm b/lib/Config/Any/General.pm index d16cf59..db32022 100644 --- a/lib/Config/Any/General.pm +++ b/lib/Config/Any/General.pm @@ -2,7 +2,6 @@ package Config::Any::General; use strict; use warnings; -use Carp; use base 'Config::Any::Base'; @@ -46,15 +45,10 @@ sub load { my $file = shift; my $args = shift || {}; - # work around bug (?) in Config::General - # return if $class->_test_perl($file); - $args->{ -ConfigFile } = $file; require Config::General; - - croak "Config::General 2.47 or later required" - unless Config::General->VERSION('2.47'); + Config::General->VERSION( '2.47' ); $args->{ -ForceArray } = 1 unless exists $args->{ -ForceArray }; @@ -64,27 +58,13 @@ sub load { return $config; } -# this is a bit of a hack but necessary, because Config::General is *far* too lax -# about what it will load -- specifically, it seems to be quite happy to load a Perl -# config file (ie, a file which is valid Perl and creates a hashref) as if it were -# an Apache-style configuration file, presumably due to laziness on the part of the -# developer. - -sub _test_perl { - my ( $class, $file ) = @_; - my $is_perl_src; - eval { $is_perl_src = do "$file"; }; - delete $INC{ $file }; # so we don't screw stuff later on - return defined $is_perl_src; -} - =head2 requires_all_of( ) Specifies that this module requires L in order to work. =cut -sub requires_all_of { [ 'Config::General' ] } +sub requires_all_of { [ 'Config::General' => '2.47' ] } =head1 AUTHOR @@ -92,11 +72,11 @@ Brian Cassidy Ebricas@cpan.orgE =head1 CONTRIBUTORS -Joel Bernstein C<< >> +Joel Bernstein Erataxis@cpan.orgE =head1 COPYRIGHT AND LICENSE -Copyright 2006-2010 by Brian Cassidy +Copyright 2006-2016 by Brian Cassidy Portions Copyright 2006 Portugal Telecom @@ -118,4 +98,3 @@ it under the same terms as Perl itself. =cut 1; -