more code updates, before i look in depth at the _load() routine

[p5sagit/Config-Any.git] / lib / Config / Any.pm

diff --git a/lib/Config/Any.pm b/lib/Config/Any.pm
index 4f9b401..07f7a9c 100644 (file)
--- a/lib/Config/Any.pm
+++ b/lib/Config/Any.pm
@@ -5,7 +5,6 @@ use warnings;
 
 use Carp;
 use Module::Pluggable::Object ();
-use English qw(-no_match_vars);
 
 our $VERSION = '0.09';
 
@@ -15,7 +14,7 @@ Config::Any - Load configuration from different file formats, transparently
 
 =head1 VERSION
 
-This document describes Config::Any version 0.0.8
+This document describes Config::Any version 0.09
 
 =head1 SYNOPSIS
 
@@ -49,7 +48,7 @@ configuration formats.
 
 =cut
 
-=head2 load_files( )
+=head2 load_files( \%args )
 
     Config::Any->load_files( { files => \@files } );
     Config::Any->load_files( { files => \@files, filter  => \&filter } );
@@ -95,11 +94,11 @@ sub load_files {
     return $class->_load( $args );
 }
 
-=head2 load_stems( )
+=head2 load_stems( \%args )
 
-    Config::Any->load_stems({stems => \@stems]});
-    Config::Any->load_stems({stems => \@stems, filter  => \&filter});
-    Config::Any->load_stems({stems => \@stems, use_ext => 1});
+    Config::Any->load_stems( { stems => \@stems } );
+    Config::Any->load_stems( { stems => \@stems, filter  => \&filter } );
+    Config::Any->load_stems( { stems => \@stems, use_ext => 1 } );
 
 C<load_stems()> attempts to load configuration from a list of files which it generates
 by combining the filename stems list passed in the C<stems> parameter with the 
@@ -112,36 +111,23 @@ parameters. Please read the C<load_files()> documentation before using this meth
 
 sub load_stems {
     my ( $class, $args ) = @_;
-    return unless defined $args;
-    unless ( exists $args->{ stems } ) {
-        warn "no stems specified";
+
+    unless ( $args && exists $args->{ stems } ) {
+        warn "No stems specified!";
         return;
     }
 
-    my %load_args
-        = map { $_ => defined $args->{ $_ } ? $args->{ $_ } : undef }
-        qw(filter use_ext force_plugins driver_args);
-
-    $load_args{ files } = $class->_stems_to_files( $args->{ stems } );
-    return $class->_load( \%load_args );
-}
-
-sub _stems_to_files {
-    my ( $class, $stems ) = @_;
-    return unless defined $stems;
-
+    my $stems = delete $args->{ stems };
     my @files;
     for my $s ( @$stems ) {
         for my $ext ( $class->extensions ) {
             push @files, "$s.$ext";
         }
     }
-    return \@files;
-}
 
-sub _maphash { # syntactic sugar
-    map { $_ => 1 } @_;
-} 
+    $args->{ files } = \@files;
+    return $class->_load( $args );
+}
 
 # this is where we do the real work
 # it's a private class-method because users should use the interface described
@@ -152,9 +138,9 @@ sub _load {
         = @{ $args }{ qw(files filter use_ext force_plugins) };
     croak "_load requires a arrayref of file paths" unless defined $files_ref;
 
-    my %files         = _maphash @$files_ref;
-    my %force_plugins = _maphash @$force_plugins_ref;
-    my $enforcing     = keys %force_plugins ? 1 : 0;
+    my %files         = map { $_ => 1 } @$files_ref;
+    my %force_plugins = map { $_ => 1 } @$force_plugins_ref;
+    my $enforcing = keys %force_plugins ? 1 : 0;
 
     my $final_configs     = [];
     my $originally_loaded = {};
@@ -163,7 +149,7 @@ sub _load {
     for my $loader ( $class->plugins ) {
         next if $enforcing && not defined $force_plugins{ $loader };
         last unless keys %files;
-        my %ext = _maphash $loader->extensions;
+        my %ext = map { $_ => 1 } $loader->extensions;
 
         my ( $loader_class ) = $loader =~ /::([^:]+)$/;
         my $driver_args = $args->{ driver_args }{ $loader_class } || {};
@@ -189,7 +175,7 @@ sub _load {
             my $config;
             eval { $config = $loader->load( $filename, $driver_args ); };
 
-            next if $EVAL_ERROR;    # if it croaked or warned, we can't use it
+            next if $@;         # if it croaked or warned, we can't use it
             next if !$config;
             delete $files{ $filename };
 
@@ -199,7 +185,8 @@ sub _load {
             push @$final_configs, { $filename => $config };
         }
     }
-    $final_configs;
+
+    return $final_configs;
 }
 
 =head2 finder( )
@@ -217,7 +204,7 @@ sub finder {
         search_path => [ __PACKAGE__ ],
         require     => 1
     );
-    $finder;
+    return $finder;
 }
 
 =head2 plugins( )
@@ -250,7 +237,7 @@ sub extensions {
 
 =over
 
-=item C<no files specified> or C<no stems specified>
+=item C<No files specified!> or C<No stems specified!>
 
 The C<load_files()> and C<load_stems()> methods will issue this warning if
 called with an empty list of files/stems to load.