From: Graham Knop <haarg@haarg.org>
Date: Mon, 24 Feb 2014 05:55:08 +0000 (-0500)
Subject: comments and caveats for applying overloads to instances
X-Git-Tag: v1.003003~14
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FRole-Tiny.git;a=commitdiff_plain;h=3f9b723f98c8af029f9da06e9dcd63b98e782b91

comments and caveats for applying overloads to instances
---

diff --git a/lib/Role/Tiny.pm b/lib/Role/Tiny.pm
index ca3d0fe..67e5c05 100644
--- a/lib/Role/Tiny.pm
+++ b/lib/Role/Tiny.pm
@@ -100,8 +100,9 @@ sub apply_roles_to_object {
   my ($me, $object, @roles) = @_;
   die "No roles supplied!" unless @roles;
   my $class = ref($object);
-  bless($object, $me->create_class_with_roles($class, @roles));
-  $object;
+  # on perl < 5.8.9, magic isn't copied to all ref copies. bless the parameter
+  # directly, so at least the variable passed to us will get any magic applied
+  bless($_[1], $me->create_class_with_roles($class, @roles));
 }
 
 my $role_suffix = 'A000';
@@ -365,6 +366,7 @@ sub _install_methods {
     *$glob = $methods->{$i};
 
     # overloads using method names have the method stored in the scalar slot
+    # and &overload::nil in the code slot.
     next
       unless $i =~ /^\(/
         && defined &overload::nil
@@ -638,6 +640,13 @@ New class is returned.
 
 Returns true if the given package is a role.
 
+=head1 CAVEATS
+
+=over 4
+
+=item * On perl 5.8.8 and earlier, applying a role to an object won't apply any
+overloads from the role to all copies of the object.
+
 =head1 SEE ALSO
 
 L<Role::Tiny> is the attribute-less subset of L<Moo::Role>; L<Moo::Role> is