From: Jesse Luehrs Date: Tue, 29 Nov 2011 20:34:53 +0000 (-0600) Subject: properly conditionalize these on the PP implementation X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FPackage-Stash.git;a=commitdiff_plain;h=ace6563db0b4154744704087b763f76f847bf590 properly conditionalize these on the PP implementation --- diff --git a/t/anon-basic.t b/t/anon-basic.t index 661430a..bfa80e1 100644 --- a/t/anon-basic.t +++ b/t/anon-basic.t @@ -10,7 +10,8 @@ use Package::Stash; use Symbol; plan skip_all => "Anonymous stashes in PP need at least perl 5.14" - if Package::Stash::BROKEN_GLOB_ASSIGNMENT; + if Package::Stash::BROKEN_GLOB_ASSIGNMENT + && $Package::Stash::IMPLEMENTATION eq 'PP'; my $Foo = Package::Anon->new('Foo'); $Foo->{SOME_CONSTANT} = \1; diff --git a/t/anon.t b/t/anon.t index 1816534..575de06 100644 --- a/t/anon.t +++ b/t/anon.t @@ -11,7 +11,8 @@ use Package::Stash; use Symbol; plan skip_all => "Anonymous stashes in PP need at least perl 5.14" - if Package::Stash::BROKEN_GLOB_ASSIGNMENT; + if Package::Stash::BROKEN_GLOB_ASSIGNMENT + && $Package::Stash::IMPLEMENTATION eq 'PP'; my $anon = Package::Anon->new; my $stash = Package::Stash->new($anon); diff --git a/t/bare-anon-basic.t b/t/bare-anon-basic.t index 5a1601a..3291cd3 100644 --- a/t/bare-anon-basic.t +++ b/t/bare-anon-basic.t @@ -9,7 +9,8 @@ use Package::Stash; use Symbol; plan skip_all => "Anonymous stashes in PP need at least perl 5.14" - if Package::Stash::BROKEN_GLOB_ASSIGNMENT; + if Package::Stash::BROKEN_GLOB_ASSIGNMENT + && $Package::Stash::IMPLEMENTATION eq 'PP'; my $Foo = {}; $Foo->{SOME_CONSTANT} = \1; diff --git a/t/bare-anon.t b/t/bare-anon.t index 3c96ec8..e24647d 100644 --- a/t/bare-anon.t +++ b/t/bare-anon.t @@ -9,7 +9,8 @@ use Package::Stash; use Symbol; plan skip_all => "Anonymous stashes in PP need at least perl 5.14" - if Package::Stash::BROKEN_GLOB_ASSIGNMENT; + if Package::Stash::BROKEN_GLOB_ASSIGNMENT + && $Package::Stash::IMPLEMENTATION eq 'PP'; my $anon = {}; my $stash = Package::Stash->new($anon); diff --git a/t/edge-cases.t b/t/edge-cases.t index b1e5bb8..1d26176 100755 --- a/t/edge-cases.t +++ b/t/edge-cases.t @@ -57,7 +57,9 @@ SKIP: { skip "PP doesn't support anon stashes before 5.14", 4 if $Package::Stash::IMPLEMENTATION eq 'PP' && Package::Stash::BROKEN_GLOB_ASSIGNMENT; - local $TODO = "don't know how to properly inflate a stash entry"; + local $TODO = ($Package::Stash::IMPLEMENTATION eq 'PP') + ? "don't know how to properly inflate a stash entry" + : undef; my $anon = {}; # not using Package::Anon $anon->{foo} = -1; # stub