X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FRole.pm;h=987239763cee603e176c84cb664ed77faebc79bd;hp=710473622d1308ede945eeb4322b22774bb39a69;hb=6d28c5cf89bfd4c00e675e95aff6c31b61aeb805;hpb=1d86420d34a7bbe8596b08035d7fb6c8c81d00a3 diff --git a/lib/Mouse/Role.pm b/lib/Mouse/Role.pm index 7104736..9872397 100644 --- a/lib/Mouse/Role.pm +++ b/lib/Mouse/Role.pm @@ -3,11 +3,11 @@ use strict; use warnings; use base 'Exporter'; -use Carp 'confess', 'croak'; +use Carp 'confess'; use Scalar::Util 'blessed'; -use Mouse::Meta::Role; -use Mouse::Util qw(load_class); +use Mouse::Util qw(load_class not_supported); +use Mouse (); our @EXPORT = qw(before after around super override inner augment has extends with requires excludes confess blessed); our %is_removable = map{ $_ => undef } @EXPORT; @@ -56,8 +56,8 @@ sub override { my $fullname = "${classname}::${name}"; defined &$fullname - && confess "Cannot add an override of method '$fullname' " . - "because there is a local version of '$fullname'"; + && $meta->throw_error("Cannot add an override of method '$fullname' " + . "because there is a local version of '$fullname'"); $meta->add_override_method_modifier($name => sub { local $Mouse::SUPER_PACKAGE = shift; @@ -70,11 +70,11 @@ sub override { # We keep the same errors messages as Moose::Role emits, here. sub inner { - croak "Moose::Role cannot support 'inner'"; + Carp::croak "Roles cannot support 'inner'"; } sub augment { - croak "Moose::Role cannot support 'augment'"; + Carp::croak "Roles cannot support 'augment'"; } sub has { @@ -86,7 +86,9 @@ sub has { $meta->add_attribute($name => \%opts); } -sub extends { confess "Roles do not support 'extends'" } +sub extends { + Carp::croak "Roles do not support 'extends'" +} sub with { my $meta = Mouse::Meta::Role->initialize(scalar caller); @@ -95,11 +97,13 @@ sub with { sub requires { my $meta = Mouse::Meta::Role->initialize(scalar caller); - Carp::croak "Must specify at least one method" unless @_; + $meta->throw_error("Must specify at least one method") unless @_; $meta->add_required_methods(@_); } -sub excludes { confess "Mouse::Role does not currently support 'excludes'" } +sub excludes { + not_supported; +} sub import { my $class = shift;