X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FRole.pm;h=c030b702c4c4e4143b94ada1156f44cbf0945eb4;hp=e1f3f7187ff679a6afab8a9e7db594452c003a9c;hb=f3e1112299b631f1ab6150159eaa414dca37a42c;hpb=cb60d0b55962e6ff8cdc07e51e59f7dd5feafd43 diff --git a/lib/Mouse/Meta/Role.pm b/lib/Mouse/Meta/Role.pm index e1f3f71..c030b70 100644 --- a/lib/Mouse/Meta/Role.pm +++ b/lib/Mouse/Meta/Role.pm @@ -149,13 +149,13 @@ sub _apply_modifiers{ } for my $modifier_type (qw/before around after/) { - my $modifiers = $role->{"${modifier_type}_method_modifiers"} + my $table = $role->{"${modifier_type}_method_modifiers"} or next; my $add_modifier = "add_${modifier_type}_method_modifier"; - foreach my $method_name (keys %{$modifiers}){ - foreach my $code(@{ $modifiers->{$method_name} }){ + while(my($method_name, $modifiers) = each %{$table}){ + foreach my $code(@{ $modifiers }){ next if $consumer->{"_applied_$modifier_type"}{$method_name, $code}++; # skip applied modifiers $consumer->$add_modifier($method_name => $code); } @@ -167,10 +167,10 @@ sub _apply_modifiers{ sub _append_roles{ my($role, $consumer, $args) = @_; - my $roles = ($args->{_to} eq 'role') ? $consumer->get_roles : $consumer->roles; + my $roles = $consumer->{roles}; foreach my $r($role, @{$role->get_roles}){ - if(!$consumer->does_role($r->name)){ + if(!$consumer->does_role($r)){ push @{$roles}, $r; } } @@ -288,6 +288,8 @@ sub does_role { (defined $role_name) || $self->throw_error("You must supply a role name to look for"); + $role_name = $role_name->name if ref $role_name; + # if we are it,.. then return true return 1 if $role_name eq $self->name; # otherwise.. check our children