X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FRole.pm;h=a41d5a69c2b763df0d0a0e46bc93736eab4e5616;hp=bdaacf0dee9ec5c4a6c8a0fddbdce2f98a9c9e13;hb=467c4815ec15a74e6aa4970b6d69bcb4a6fa0b7f;hpb=d990f7911dfd6a36d1dcc072e7adb72bf0379349 diff --git a/lib/Mouse/Meta/Role.pm b/lib/Mouse/Meta/Role.pm index bdaacf0..a41d5a6 100644 --- a/lib/Mouse/Meta/Role.pm +++ b/lib/Mouse/Meta/Role.pm @@ -149,13 +149,13 @@ sub _apply_modifiers{ } for my $modifier_type (qw/before around after/) { - my $modifiers = $role->{"${modifier_type}_method_modifiers"} + my $table = $role->{"${modifier_type}_method_modifiers"} or next; my $add_modifier = "add_${modifier_type}_method_modifier"; - foreach my $method_name (keys %{$modifiers}){ - foreach my $code(@{ $modifiers->{$method_name} }){ + while(my($method_name, $modifiers) = each %{$table}){ + foreach my $code(@{ $modifiers }){ next if $consumer->{"_applied_$modifier_type"}{$method_name, $code}++; # skip applied modifiers $consumer->$add_modifier($method_name => $code); } @@ -167,7 +167,7 @@ sub _apply_modifiers{ sub _append_roles{ my($role, $consumer, $args) = @_; - my $roles = ($args->{_to} eq 'role') ? $consumer->get_roles : $consumer->roles; + my $roles = $consumer->{roles}; foreach my $r($role, @{$role->get_roles}){ if(!$consumer->does_role($r->name)){ @@ -255,37 +255,13 @@ sub combine { return $composite; } -sub add_before_method_modifier { - my ($self, $method_name, $method) = @_; - - push @{ $self->{before_method_modifiers}{$method_name} ||= [] }, $method; - return; -} -sub add_around_method_modifier { - my ($self, $method_name, $method) = @_; - - push @{ $self->{around_method_modifiers}{$method_name} ||= [] }, $method; - return; -} -sub add_after_method_modifier { - my ($self, $method_name, $method) = @_; - - push @{ $self->{after_method_modifiers}{$method_name} ||= [] }, $method; - return; -} +sub add_before_method_modifier; +sub add_around_method_modifier; +sub add_after_method_modifier; -sub get_before_method_modifiers { - my ($self, $method_name) = @_; - return @{ $self->{before_method_modifiers}{$method_name} ||= [] } -} -sub get_around_method_modifiers { - my ($self, $method_name) = @_; - return @{ $self->{around_method_modifiers}{$method_name} ||= [] } -} -sub get_after_method_modifiers { - my ($self, $method_name) = @_; - return @{ $self->{after_method_modifiers}{$method_name} ||= [] } -} +sub get_before_method_modifiers; +sub get_around_method_modifiers; +sub get_after_method_modifiers; sub add_override_method_modifier{ my($self, $method_name, $method) = @_; @@ -330,7 +306,7 @@ Mouse::Meta::Role - The Mouse Role metaclass =head1 VERSION -This document describes Mouse version 0.50_02 +This document describes Mouse version 0.50_03 =head1 SEE ALSO