X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FMethod%2FConstructor.pm;h=2e848a75ed6ff061144dd08d6d944615dacac548;hp=f6287db6647d1ab20c47cc00385dc593f73f4d33;hb=1e5823974a557bd35b4aa4a5c1d1aecf1e5483d2;hpb=0bfc7290b1efb0dcbe6fcff1461ef9beea5a3f07

diff --git a/lib/Mouse/Meta/Method/Constructor.pm b/lib/Mouse/Meta/Method/Constructor.pm
index f6287db..2e848a7 100644
--- a/lib/Mouse/Meta/Method/Constructor.pm
+++ b/lib/Mouse/Meta/Method/Constructor.pm
@@ -1,7 +1,12 @@
 package Mouse::Meta::Method::Constructor;
 use Mouse::Util; # enables strict and warnings
 
-sub _generate_constructor_method {
+sub _inline_slot{
+    my(undef, $self_var, $attr_name) = @_;
+    return sprintf '%s->{q{%s}}', $self_var, $attr_name;
+}
+
+sub _generate_constructor {
     my ($class, $metaclass, $args) = @_;
 
     my $associated_metaclass_name = $metaclass->name;
@@ -38,13 +43,11 @@ sub _generate_constructor_method {
         $@;
     };
     die $e if $e;
-
-    $metaclass->add_method($args->{constructor_name} => $code);
-    return;
+    return $code;
 }
 
 sub _generate_processattrs {
-    my ($class, $metaclass, $attrs) = @_;
+    my ($method_class, $metaclass, $attrs) = @_;
     my @res;
 
     my $has_triggers;
@@ -59,7 +62,7 @@ sub _generate_processattrs {
         my $type_constraint = $attr->type_constraint;
         my $need_coercion;
 
-        my $instance_slot  = "\$instance->{q{$key}}";
+        my $instance_slot  = $method_class->_inline_slot('$instance', $key);
         my $attr_var       = "\$attrs[$index]";
         my $constraint_var;
 
@@ -85,7 +88,7 @@ sub _generate_processattrs {
             $code .= "if (exists $value) {\n";
 
             if($need_coercion){
-                $value = "$instance_slot = $constraint_var->coerce($value);\n";
+                $value = "$constraint_var->coerce($value)";
             }
 
             $code .= "$instance_slot = $value;\n";
@@ -93,7 +96,7 @@ sub _generate_processattrs {
 
             if ($attr->has_trigger) {
                 $has_triggers++;
-                $code .= "push \@triggers, [$attr_var\->{trigger}, $value];\n";
+                $code .= "push \@triggers, [$attr_var\->{trigger}, $instance_slot];\n";
             }
 
             $code .= "\n} else {\n";
@@ -135,7 +138,7 @@ sub _generate_processattrs {
     }
 
     if($metaclass->is_anon_class){
-        push @res, q{$instnace->{__METACLASS__} = $metaclass;};
+        push @res, q{$instance->{__METACLASS__} = $metaclass;};
     }
 
     if($has_triggers){
@@ -174,10 +177,7 @@ sub _generate_BUILDALL {
 
     my @code;
     for my $class ($metaclass->linearized_isa) {
-        no strict 'refs';
-        no warnings 'once';
-
-        if (*{ $class . '::BUILD' }{CODE}) {
+        if (Mouse::Util::get_code_ref($class, 'BUILD')) {
             unshift  @code, qq{${class}::BUILD(\$instance, \$args);};
         }
     }
@@ -185,3 +185,18 @@ sub _generate_BUILDALL {
 }
 
 1;
+__END__
+
+=head1 NAME
+
+Mouse::Meta::Method::Constructor - A Mouse method generator for constructors
+
+=head1 VERSION
+
+This document describes Mouse version 0.40_06
+
+=head1 SEE ALSO
+
+L<Moose::Meta::Method::Constructor>
+
+=cut