X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FMethod%2FConstructor.pm;h=0621135743ad5edc41e56572ad82455e268e54f3;hp=0c929a764471cbe6196615edacda92f86f9c77aa;hb=8801a6e6a8356e193b0ec0b67f92d741801d4fb8;hpb=e128626c409797822ffd8a4079f833eb3dc0fd37 diff --git a/lib/Mouse/Meta/Method/Constructor.pm b/lib/Mouse/Meta/Method/Constructor.pm index 0c929a7..0621135 100644 --- a/lib/Mouse/Meta/Method/Constructor.pm +++ b/lib/Mouse/Meta/Method/Constructor.pm @@ -51,10 +51,9 @@ sub _generate_processattrs { my @res; my $has_triggers; - my $strict_constructor = $metaclass->__strict_constructor; + my $strict = $metaclass->__strict_constructor; - - if($strict_constructor){ + if($strict){ push @res, 'my $used = 0;'; } @@ -106,8 +105,8 @@ sub _generate_processattrs { $code .= "push \@triggers, [$attr_var\->{trigger}, $instance_slot];\n"; } - if ($strict_constructor){ - $code .= '$used++;' . "\n"; + if ($strict){ + $code .= '++$used;' . "\n"; } $code .= "\n} else {\n"; # $value exists @@ -151,9 +150,9 @@ sub _generate_processattrs { push @res, $code; } - if($strict_constructor){ + if($strict){ push @res, q{if($used < keys %{$args})} - . q{{ Mouse::Meta::Method::Constructor::_report_unknown_args($metaclass, \@attrs, $instance, $args) }}; + . sprintf q{{ %s->_report_unknown_args($metaclass, \@attrs, $args) }}, $method_class; } if($metaclass->is_anon_class){ @@ -204,7 +203,7 @@ sub _generate_BUILDALL { } sub _report_unknown_args { - my($metaclass, $attrs, $instance, $args) = @_; + my(undef, $metaclass, $attrs, $args) = @_; my @unknowns; my %init_args; @@ -223,7 +222,7 @@ sub _report_unknown_args { $metaclass->throw_error( sprintf "Unknown attribute passed to the constructor of %s: %s", - ref($instance), join ', ', @unknowns + $metaclass->name, Mouse::Util::english_list(@unknowns), ); } @@ -236,7 +235,7 @@ Mouse::Meta::Method::Constructor - A Mouse method generator for constructors =head1 VERSION -This document describes Mouse version 0.50_01 +This document describes Mouse version 0.50_03 =head1 SEE ALSO