X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FMethod%2FAccessor.pm;h=99c1e3d3940b17206ad932c5da3de7f02e3f09aa;hp=9c5b746a3bf6b02e0949cc362a74e0f3831067a3;hb=2b68f76d78d96325821e9a6360c3639f8c5637df;hpb=95ecd6f132112c6763cdaf2e6bc72c39e9ab76b5 diff --git a/lib/Mouse/Meta/Method/Accessor.pm b/lib/Mouse/Meta/Method/Accessor.pm index 9c5b746..99c1e3d 100755 --- a/lib/Mouse/Meta/Method/Accessor.pm +++ b/lib/Mouse/Meta/Method/Accessor.pm @@ -2,8 +2,13 @@ package Mouse::Meta::Method::Accessor; use Mouse::Util; # enables strict and warnings use Scalar::Util qw(blessed); +sub _inline_slot{ + my(undef, $self_var, $attr_name) = @_; + return sprintf '%s->{q{%s}}', $self_var, $attr_name; +} + sub _generate_accessor{ - my (undef, $attribute, $class, $type) = @_; + my ($method_class, $attribute, $class, $type) = @_; my $name = $attribute->name; my $default = $attribute->default; @@ -17,8 +22,7 @@ sub _generate_accessor{ my $compiled_type_constraint = defined($constraint) ? $constraint->_compiled_type_constraint : undef; my $self = '$_[0]'; - my $key = "q{$name}"; - my $slot = "$self\->{$key}"; + my $slot = $method_class->_inline_slot($self, $name);; $type ||= 'accessor'; @@ -74,8 +78,7 @@ sub _generate_accessor{ $class->throw_error("Unknown accessor type '$type'"); } - # XXX: an anon class can be a runtime created class - if ($attribute->is_lazy || $class->is_anon_class) { + if ($attribute->is_lazy) { my $value; if (defined $builder){ @@ -94,8 +97,9 @@ sub _generate_accessor{ } elsif(defined $constraint){ $accessor .= "my \$tmp = $value;\n"; + $accessor .= "\$compiled_type_constraint->(\$tmp)"; - $accessor .= "or \$attribute->verify_type_constraint_error(\$name, \$tmp, \$constraint);\n"; + $accessor .= " || \$attribute->verify_type_constraint_error(\$name, \$tmp, \$constraint);\n"; $accessor .= "$slot = \$tmp;\n"; } else{ @@ -160,27 +164,19 @@ sub _generate_clearer { }; } -sub _generate_delegation{ - my (undef, $attribute, $class, $reader, $handle_name, $method_to_call) = @_; - - return sub { - my $instance = shift; - my $proxy = $instance->$reader(); - - my $error = !defined($proxy) ? ' is not defined' - : ref($proxy) && !blessed($proxy) ? qq{ is not an object (got '$proxy')} - : undef; - if ($error) { - $instance->meta->throw_error( - "Cannot delegate $handle_name to $method_to_call because " - . "the value of " - . $attribute->name - . $error - ); - } - $proxy->$method_to_call(@_); - }; -} +1; +__END__ +=head1 NAME -1; +Mouse::Meta::Method::Accessor - A Mouse method generator for accessors + +=head1 VERSION + +This document describes Mouse version 0.40_03 + +=head1 SEE ALSO + +L + +=cut