X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FMethod%2FAccessor.pm;h=438d5be27f94a30fc9fae3961c379b92e184c0ae;hp=810fbc0c401757bfe43f87b77d47e32b6e157d53;hb=5176a3e41f75dc3f0de6049ac642087580f94680;hpb=3821b191b0493223e0f67b05ad351e3753fcfc66 diff --git a/lib/Mouse/Meta/Method/Accessor.pm b/lib/Mouse/Meta/Method/Accessor.pm index 810fbc0..438d5be 100755 --- a/lib/Mouse/Meta/Method/Accessor.pm +++ b/lib/Mouse/Meta/Method/Accessor.pm @@ -6,8 +6,8 @@ sub _inline_slot{ return sprintf '%s->{q{%s}}', $self_var, $attr_name; } -sub _generate_accessor{ - my ($method_class, $attribute, $class, $type) = @_; +sub _generate_accessor_any{ + my($method_class, $type, $attribute, $class) = @_; my $name = $attribute->name; my $default = $attribute->default; @@ -23,13 +23,11 @@ sub _generate_accessor{ my $self = '$_[0]'; my $slot = $method_class->_inline_slot($self, $name);; - $type ||= 'accessor'; - my $accessor = sprintf(qq{package %s;\n#line 1 "%s for %s (%s)"\n}, $class->name, $type, $name, __FILE__) . "sub {\n"; - if ($type eq 'accessor' || $type eq 'writer') { - if($type eq 'accessor'){ + if ($type eq 'rw' || $type eq 'wo') { + if($type eq 'rw'){ $accessor .= 'if (scalar(@_) >= 2) {' . "\n"; } @@ -70,7 +68,7 @@ sub _generate_accessor{ $accessor .= "}\n"; } - elsif($type eq 'reader') { + elsif($type eq 'ro') { $accessor .= 'Carp::confess("Cannot assign a value to a read-only accessor") if scalar(@_) >= 2;' . "\n"; } else{ @@ -136,16 +134,20 @@ sub _generate_accessor{ return $code; } -sub _generate_reader{ +sub _generate_accessor{ my $class = shift; - return $class->_generate_accessor(@_, 'reader'); + return $class->_generate_accessor_any(rw => @_); } -sub _generate_writer{ +sub _generate_reader { my $class = shift; - return $class->_generate_accessor(@_, 'writer'); + return $class->_generate_accessor_any(ro => @_); } +sub _generate_writer { + my $class = shift; + return $class->_generate_accessor_any(wo => @_); +} sub _generate_predicate { my (undef, $attribute, $class) = @_; @@ -160,8 +162,7 @@ sub _generate_clearer { my (undef, $attribute, $class) = @_; my $slot = $attribute->name; - - return sub{ + return sub{ delete $_[0]->{$slot}; }; } @@ -175,7 +176,7 @@ Mouse::Meta::Method::Accessor - A Mouse method generator for accessors =head1 VERSION -This document describes Mouse version 0.40_08 +This document describes Mouse version 0.42 =head1 SEE ALSO