X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FMethod%2FAccessor.pm;h=2ca2faabfc6482e212363b2572a9996ced30ca0f;hp=dc866c37db27ebeb56022df5a2c886ded7de2875;hb=f7e41edaceee0d549a2d664378cfcf85dcf9454b;hpb=f8cbb121afb89df0feb90dfa413eeaa4cebec85f diff --git a/lib/Mouse/Meta/Method/Accessor.pm b/lib/Mouse/Meta/Method/Accessor.pm index dc866c3..2ca2faa 100755 --- a/lib/Mouse/Meta/Method/Accessor.pm +++ b/lib/Mouse/Meta/Method/Accessor.pm @@ -1,6 +1,5 @@ package Mouse::Meta::Method::Accessor; use Mouse::Util; # enables strict and warnings -use Scalar::Util qw(blessed); sub _inline_slot{ my(undef, $self_var, $attr_name) = @_; @@ -26,7 +25,7 @@ sub _generate_accessor{ $type ||= 'accessor'; - my $accessor = sprintf(qq{#line 1 "%s for %s (%s)"\n}, $type, $name, __FILE__) + my $accessor = sprintf(qq{package %s;\n#line 1 "%s for %s (%s)"\n}, $class->name, $type, $name, __FILE__) . "sub {\n"; if ($type eq 'accessor' || $type eq 'writer') { @@ -97,8 +96,6 @@ sub _generate_accessor{ } elsif(defined $constraint){ $accessor .= "my \$tmp = $value;\n"; - #XXX: The following 'defined and' check is for backward compatibility - $accessor .= "defined(\$tmp) and "; $accessor .= "\$compiled_type_constraint->(\$tmp)"; $accessor .= " || \$attribute->verify_type_constraint_error(\$name, \$tmp, \$constraint);\n"; @@ -107,6 +104,9 @@ sub _generate_accessor{ else{ $accessor .= "$slot = $value;\n"; } + if ($is_weak) { + $accessor .= "Scalar::Util::weaken($slot) if ref $slot;\n"; + } $accessor .= "}\n"; } @@ -124,7 +124,7 @@ sub _generate_accessor{ $accessor .= "return $slot;\n}\n"; - #print "# class ", $class->name, "\n", $accessor, "\n"; + #print $accessor, "\n"; my $code; my $e = do{ local $@; @@ -166,29 +166,6 @@ sub _generate_clearer { }; } -sub _generate_delegation{ - my (undef, $attribute, $class, $reader, $handle_name, $method_to_call) = @_; - - return sub { - my $instance = shift; - my $proxy = $instance->$reader(); - - my $error = !defined($proxy) ? ' is not defined' - : ref($proxy) && !blessed($proxy) ? qq{ is not an object (got '$proxy')} - : undef; - if ($error) { - $instance->meta->throw_error( - "Cannot delegate $handle_name to $method_to_call because " - . "the value of " - . $attribute->name - . $error - ); - } - $proxy->$method_to_call(@_); - }; -} - - 1; __END__ @@ -198,7 +175,7 @@ Mouse::Meta::Method::Accessor - A Mouse method generator for accessors =head1 VERSION -This document describes Mouse version 0.40 +This document describes Mouse version 0.40_08 =head1 SEE ALSO