X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FClass.pm;h=bfcbaa0ae85e67c01fa00c713b8d325389fbb6d8;hp=85066c7b2f81b60cdda03ebc8c1763a60e622cbc;hb=85bd3f44fbee036b39fedb1e2ca2b566c1a6d08f;hpb=2a464664052830d5fad036569d5ccb3964c7f592 diff --git a/lib/Mouse/Meta/Class.pm b/lib/Mouse/Meta/Class.pm index 85066c7..bfcbaa0 100644 --- a/lib/Mouse/Meta/Class.pm +++ b/lib/Mouse/Meta/Class.pm @@ -11,7 +11,8 @@ use Mouse::Meta::Method::Destructor; use Mouse::Meta::Module; our @ISA = qw(Mouse::Meta::Module); -sub method_metaclass(){ 'Mouse::Meta::Method' } # required for get_method() +sub method_metaclass() { 'Mouse::Meta::Method' } +sub attribute_metaclass() { 'Mouse::Meta::Attribute' } sub _construct_meta { my($class, %args) = @_; @@ -26,7 +27,7 @@ sub _construct_meta { }; my $self = bless \%args, ref($class) || $class; - if($class ne __PACKAGE__){ + if(ref($self) ne __PACKAGE__){ $self->meta->_initialize_object($self, \%args); } return $self; @@ -103,6 +104,7 @@ sub add_attribute { if ($name =~ s/^\+//) { # inherited attributes my $inherited_attr; + # find_attribute_by_name foreach my $class($self->linearized_isa){ my $meta = Mouse::Util::get_metaclass_by_name($class) or next; $inherited_attr = $meta->get_attribute($name) and last; @@ -111,10 +113,10 @@ sub add_attribute { defined($inherited_attr) or $self->throw_error("Could not find an attribute by the name of '$name' to inherit from in ".$self->name); - $attr = $inherited_attr->clone_and_inherit_options($name, \%args); + $attr = $inherited_attr->clone_and_inherit_options(%args); } else{ - my($attribute_class, @traits) = Mouse::Meta::Attribute->interpolate_class($name, \%args); + my($attribute_class, @traits) = $self->attribute_metaclass->interpolate_class(\%args); $args{traits} = \@traits if @traits; $attr = $attribute_class->new($name, %args); @@ -395,12 +397,23 @@ sub add_after_method_modifier { sub add_override_method_modifier { my ($self, $name, $code) = @_; + if($self->has_method($name)){ + $self->throw_error("Cannot add an override method if a local method is already present"); + } + my $package = $self->name; - my $body = $package->can($name) + my $super_body = $package->can($name) or $self->throw_error("You cannot override '$name' because it has no super method"); - $self->add_method($name => sub { $code->($package, $body, @_) }); + $self->add_method($name => sub { + local $Mouse::SUPER_PACKAGE = $package; + local $Mouse::SUPER_BODY = $super_body; + local @Mouse::SUPER_ARGS = @_; + + $code->(@_); + }); + return; } sub does_role {