X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FClass.pm;h=afe92940c085a385a7861c6cd2aecb6796889a8d;hp=90331ad542dbc5b71577f61be56701c67582b2ca;hb=815f725aeff0bd44da8d75e7cd4ac456e9e60238;hpb=ad958001acda8f0903f6f6f6deac9d5c0b2fb90f diff --git a/lib/Mouse/Meta/Class.pm b/lib/Mouse/Meta/Class.pm index 90331ad..afe9294 100644 --- a/lib/Mouse/Meta/Class.pm +++ b/lib/Mouse/Meta/Class.pm @@ -63,6 +63,7 @@ sub add_method { my $pkg = $self->name; no strict 'refs'; + no warnings 'redefine'; $self->{'methods'}->{$name}++; # Moose stores meta object here. *{ $pkg . '::' . $name } = $code; } @@ -159,37 +160,40 @@ sub is_immutable { $_[0]->{is_immutable} } sub attribute_metaclass { "Mouse::Meta::Class" } +sub _install_modifier { + my ( $self, $into, $type, $name, $code ) = @_; + if (eval "require Class::Method::Modifiers::Fast; 1") { + Class::Method::Modifiers::Fast::_install_modifier( + $into, + $type, + $name, + $code + ); + } + else { + require Class::Method::Modifiers; + Class::Method::Modifiers::_install_modifier( + $into, + $type, + $name, + $code + ); + } +} + sub add_before_method_modifier { - my ($self, $name, $code) = @_; - require Class::Method::Modifiers; - Class::Method::Modifiers::_install_modifier( - $self->name, - 'before', - $name, - $code, - ); + my ( $self, $name, $code ) = @_; + $self->_install_modifier( $self->name, 'before', $name, $code ); } sub add_around_method_modifier { - my ($self, $name, $code) = @_; - require Class::Method::Modifiers; - Class::Method::Modifiers::_install_modifier( - $self->name, - 'around', - $name, - $code, - ); + my ( $self, $name, $code ) = @_; + $self->_install_modifier( $self->name, 'around', $name, $code ); } sub add_after_method_modifier { - my ($self, $name, $code) = @_; - require Class::Method::Modifiers; - Class::Method::Modifiers::_install_modifier( - $self->name, - 'after', - $name, - $code, - ); + my ( $self, $name, $code ) = @_; + $self->_install_modifier( $self->name, 'after', $name, $code ); } sub roles { $_[0]->{roles} } @@ -208,12 +212,7 @@ sub does_role { } sub create { - my ( $class, @args ) = @_; - - unshift @args, 'package' if @args % 2 == 1; - - my (%options) = @args; - my $package_name = $options{package}; + my ($self, $package_name, %options) = @_; (ref $options{superclasses} eq 'ARRAY') || confess "You must pass an ARRAY ref of superclasses" @@ -228,9 +227,6 @@ sub create { if exists $options{methods}; do { - # XXX should I implement Mouse::Meta::Module? - my $package_name = $options{package}; - ( defined $package_name && $package_name ) || confess "You must pass a package name"; @@ -244,7 +240,7 @@ sub create { confess "creation of $package_name failed : $@" if $@; }; - my (%initialize_options) = @args; + my %initialize_options = %options; delete @initialize_options{qw( package superclasses @@ -253,11 +249,11 @@ sub create { version authority )}; - my $meta = $class->initialize( $package_name => %initialize_options ); + my $meta = $self->initialize( $package_name => %initialize_options ); # FIXME totally lame $meta->add_method('meta' => sub { - $class->initialize(ref($_[0]) || $_[0]); + $self->initialize(ref($_[0]) || $_[0]); }); $meta->superclasses(@{$options{superclasses}}) @@ -332,7 +328,7 @@ this class and its superclasses. Returns a mapping of attribute names to their corresponding L objects. -=head2 has_attribute Name -> Boool +=head2 has_attribute Name -> Bool Returns whether we have a L with the given name.