X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FClass.pm;h=6683d52f2738eeb6cdbb8f8e0f259582d0ddc821;hp=84c36d5a0ea09a074dd85f563eba601c15a945d6;hb=c2168931940aa681120ba25c60658fe33c42cc1d;hpb=637d4f17e6965551c032a3115dcbbb4d8e01fbf5 diff --git a/lib/Mouse/Meta/Class.pm b/lib/Mouse/Meta/Class.pm index 84c36d5..6683d52 100644 --- a/lib/Mouse/Meta/Class.pm +++ b/lib/Mouse/Meta/Class.pm @@ -6,6 +6,8 @@ use Scalar::Util qw/blessed weaken/; use Mouse::Meta::Module; our @ISA = qw(Mouse::Meta::Module); +our @CARP_NOT = qw(Mouse); # trust Mouse + sub attribute_metaclass; sub method_metaclass; @@ -94,7 +96,7 @@ sub _reconcile_with_superclass_meta { my @roles; foreach my $role($super_meta->meta->calculate_all_roles){ - if(!$self->meta->does_role($role->name)){ + if(!$self->meta->does_role($role)){ push @roles, $role->name; } } @@ -187,8 +189,9 @@ sub add_attribute { $self->{attributes}{$attr->name} = $attr; $attr->install_accessors(); - if(Mouse::Util::_MOUSE_VERBOSE && !$attr->{associated_methods} && ($attr->{is} || '') ne 'bare'){ - Carp::cluck(qq{Attribute (}.$attr->name.qq{) of class }.$self->name.qq{ has no associated methods (did you mean to provide an "is" argument?)}); + if(!$attr->{associated_methods} && ($attr->{is} || '') ne 'bare'){ + Carp::carp(qq{Attribute ($name) of class }.$self->name + .qq{ has no associated methods (did you mean to provide an "is" argument?)}); } return $attr; } @@ -359,10 +362,7 @@ sub _install_modifier { my $into = $self->name; $install_modifier->($into, $type, $name, $code); - $self->add_method($name => do{ - no strict 'refs'; - \&{ $into . '::' . $name }; - }); + $self->add_method($name => Mouse::Util::get_code_ref($into, $name)); return; }; } @@ -439,6 +439,8 @@ sub does_role { (defined $role_name) || $self->throw_error("You must supply a role name to look for"); + $role_name = $role_name->name if ref $role_name; + for my $class ($self->linearized_isa) { my $meta = Mouse::Util::get_metaclass_by_name($class) or next; @@ -461,7 +463,7 @@ Mouse::Meta::Class - The Mouse class metaclass =head1 VERSION -This document describes Mouse version 0.50_03 +This document describes Mouse version 0.50_04 =head1 METHODS