X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FClass.pm;h=1220d290e30cf9c7e3043b7ebe167b5a521d3172;hp=45297bc1da1ff4d0db0db8d2a36d09a7b7841422;hb=bc69ee88207ce5c53f5c02dbd44cfabfbe6bae70;hpb=7eb3a8d52207d71fe91dad750a74c9f04bea568d diff --git a/lib/Mouse/Meta/Class.pm b/lib/Mouse/Meta/Class.pm index 45297bc..1220d29 100644 --- a/lib/Mouse/Meta/Class.pm +++ b/lib/Mouse/Meta/Class.pm @@ -1,11 +1,8 @@ package Mouse::Meta::Class; -use strict; -use warnings; +use Mouse::Util qw/:meta get_linear_isa not_supported/; # enables strict and warnings use Scalar::Util qw/blessed weaken/; -use Mouse::Util qw/:meta get_linear_isa not_supported/; - use Mouse::Meta::Method::Constructor; use Mouse::Meta::Method::Destructor; use Mouse::Meta::Module; @@ -79,6 +76,16 @@ sub get_all_method_names { $self->linearized_isa; } +sub find_attribute_by_name{ + my($self, $name) = @_; + my $attr; + foreach my $class($self->linearized_isa){ + my $meta = Mouse::Util::get_metaclass_by_name($class) or next; + $attr = $meta->get_attribute($name) and last; + } + return $attr; +} + sub add_attribute { my $self = shift; @@ -102,20 +109,13 @@ sub add_attribute { or $self->throw_error('You must provide a name for the attribute'); if ($name =~ s/^\+//) { # inherited attributes - my $inherited_attr; - - foreach my $class($self->linearized_isa){ - my $meta = Mouse::Util::get_metaclass_by_name($class) or next; - $inherited_attr = $meta->get_attribute($name) and last; - } - - defined($inherited_attr) + my $inherited_attr = $self->find_attribute_by_name($name) or $self->throw_error("Could not find an attribute by the name of '$name' to inherit from in ".$self->name); - $attr = $inherited_attr->clone_and_inherit_options($name, \%args); + $attr = $inherited_attr->clone_and_inherit_options(%args); } else{ - my($attribute_class, @traits) = $self->attribute_metaclass->interpolate_class($name, \%args); + my($attribute_class, @traits) = $self->attribute_metaclass->interpolate_class(\%args); $args{traits} = \@traits if @traits; $attr = $attribute_class->new($name, %args); @@ -396,12 +396,43 @@ sub add_after_method_modifier { sub add_override_method_modifier { my ($self, $name, $code) = @_; + if($self->has_method($name)){ + $self->throw_error("Cannot add an override method if a local method is already present"); + } + my $package = $self->name; - my $body = $package->can($name) + my $super_body = $package->can($name) or $self->throw_error("You cannot override '$name' because it has no super method"); - $self->add_method($name => sub { $code->($package, $body, @_) }); + $self->add_method($name => sub { + local $Mouse::SUPER_PACKAGE = $package; + local $Mouse::SUPER_BODY = $super_body; + local @Mouse::SUPER_ARGS = @_; + + $code->(@_); + }); + return; +} + +sub add_augment_method_modifier { + my ($self, $name, $code) = @_; + if($self->has_method($name)){ + $self->throw_error("Cannot add an augment method if a local method is already present"); + } + + my $super = $self->find_method_by_name($name) + or $self->throw_error("You cannot augment '$name' because it has no super method"); + + my $super_package = $super->package_name; + my $super_body = $super->body; + + $self->add_method($name => sub{ + local $Mouse::INNER_BODY{$super_package} = $code; + local $Mouse::INNER_ARGS{$super_package} = [@_]; + $super_body->(@_); + }); + return; } sub does_role {