X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMouse.git;a=blobdiff_plain;f=lib%2FMouse%2FExporter.pm;h=e3cb85a848be0546f216482683baf1bb67294bec;hp=e21a029460430c61f1984ad10e4a67ad2c7af0c3;hb=3d7c6ec96a92be50258d124bdec61fb91bca3830;hpb=4c0fe06fa87e7c2c4ed1666e77ed52ae020f19d7 diff --git a/lib/Mouse/Exporter.pm b/lib/Mouse/Exporter.pm index e21a029..e3cb85a 100644 --- a/lib/Mouse/Exporter.pm +++ b/lib/Mouse/Exporter.pm @@ -171,7 +171,7 @@ sub do_import { if($spec->{INIT_META}){ my $meta; foreach my $init_meta(@{$spec->{INIT_META}}){ - $meta = $into->$init_meta(for_class => $into); + $meta = $package->$init_meta(for_class => $into); } if(@traits){ @@ -183,9 +183,11 @@ sub do_import { } @traits; require Mouse::Util::MetaRole; - Mouse::Util::MetaRole::apply_metaclass_roles( - for_class => $into, - metaclass_roles => \@traits, + Mouse::Util::MetaRole::apply_metaroles( + for => $into, + Mouse::Util::is_a_metarole($into->meta) + ? (role_metaroles => { role => \@traits }) + : (class_metaroles => { class => \@traits }), ); } } @@ -225,6 +227,7 @@ sub do_unimport { }; for my $keyword (@{ $spec->{REMOVABLES} }) { + next if !exists $stash->{$keyword}; my $gv = \$stash->{$keyword}; if(ref($gv) eq 'GLOB' && *{$gv}{CODE} == $spec->{EXPORTS}{$keyword}){ # make sure it is from us delete $stash->{$keyword}; @@ -233,20 +236,18 @@ sub do_unimport { return; } -# 1 extra level because it's called by import so there's a layer -# of indirection -sub _LEVEL(){ 1 } - sub _get_caller_package { my($arg) = @_; + # We need one extra level because it's called by import so there's a layer + # of indirection if(ref $arg){ return defined($arg->{into}) ? $arg->{into} - : defined($arg->{into_level}) ? scalar caller(_LEVEL + $arg->{into_level}) - : scalar caller(_LEVEL); + : defined($arg->{into_level}) ? scalar caller(1 + $arg->{into_level}) + : scalar caller(1); } else{ - return scalar caller(_LEVEL); + return scalar caller(1); } } @@ -261,46 +262,46 @@ Mouse::Exporter - make an import() and unimport() just like Mouse.pm =head1 VERSION -This document describes Mouse version 0.41 +This document describes Mouse version 0.49 =head1 SYNOPSIS - package MyApp::Mouse; - - use Mouse (); - use Mouse::Exporter; - - Mouse::Exporter->setup_import_methods( - as_is => [ 'has_rw', 'other_sugar', \&Some::Random::thing ], - also => 'Mouse', - ); - + package MyApp::Mouse; + + use Mouse (); + use Mouse::Exporter; + + Mouse::Exporter->setup_import_methods( + as_is => [ 'has_rw', 'other_sugar', \&Some::Random::thing ], + also => 'Mouse', + ); + sub has_rw { - my $meta = caller->meta; - my ( $name, %options ) = @_; - $meta->add_attribute( - $name, - is => 'rw', - %options, - ); - } - - # then later ... - package MyApp::User; - - use MyApp::Mouse; - - has 'name'; - has_rw 'size'; - thing; - + my $meta = caller->meta; + my ( $name, %options ) = @_; + $meta->add_attribute( + $name, + is => 'rw', + %options, + ); + } + + # then later ... + package MyApp::User; + + use MyApp::Mouse; + + has 'name'; + has_rw 'size'; + thing; + no MyApp::Mouse; =head1 DESCRIPTION -This module encapsulates the exporting of sugar functions in a -C-like manner. It does this by building custom C, -C methods for your module, based on a spec you provide. +This module encapsulates the exporting of sugar functions in a +C-like manner. It does this by building custom C, +C methods for your module, based on a spec you provide. Note that C does not provide the C option, but you can easily get the metaclass by C<< caller->meta >> as L shows.