Optimize Method::Delegation

[gitmo/Mouse.git] / t / 001_mouse / 019-handles.t

diff --git a/t/001_mouse/019-handles.t b/t/001_mouse/019-handles.t
index 9208a3c..3dbf314 100644 (file)
--- a/t/001_mouse/019-handles.t
+++ b/t/001_mouse/019-handles.t
@@ -1,22 +1,21 @@
 #!/usr/bin/env perl
 use strict;
 use warnings;
-use Test::More tests => 28;
+use Test::More;
 use Test::Exception;
 
 do {
     package Person;
+    use Mouse;
 
-    sub new {
-        my $class = shift;
-        my %args  = @_;
+    has name => (is => 'rw');
+    has age  => (is => 'rw');
 
-        bless \%args, $class;
+    sub make_string {
+        my($self, $template) = @_;
+        return sprintf $template, $self->name;
     }
 
-    sub name { $_[0]->{name} = $_[1] if @_ > 1; $_[0]->{name} }
-    sub age { $_[0]->{age} = $_[1] if @_ > 1; $_[0]->{age} }
-
     package Class;
     use Mouse;
 
@@ -28,55 +27,18 @@ do {
         handles   => {
             person_name => 'name',
             person_age  => 'age',
+            person_hello => [make_string => 'Hello, %s'],
         },
     );
 
     has me => (
-        is => 'rw',
+        is  => 'rw',
+        isa => 'Person',
         default => sub { Person->new(age => 21, name => "Shawn") },
         predicate => 'quid',
         handles => [qw/name age/],
     );
 
-    TODO: {
-        local our $TODO = "Mouse lacks this";
-        eval {
-            has error => (
-                handles => "string",
-            );
-        };
-        ::ok(!$@, "handles => role");
-    }
-
-    TODO: {
-        local our $TODO = "Mouse lacks this";
-        eval {
-            has error2 => (
-                handles => \"ref_to_string",
-            );
-        };
-        ::ok(!$@, "handles => \\str");
-    }
-
-    TODO: {
-        local our $TODO = "Mouse lacks this";
-        eval {
-            has error3 => (
-                handles => qr/regex/,
-            );
-        };
-        ::ok(!$@, "handles => qr/re/");
-    }
-
-    TODO: {
-        local our $TODO = "Mouse lacks this";
-        eval {
-            has error4 => (
-                handles => sub { "code" },
-            );
-        };
-        ::ok(!$@, "handles => sub { code }");
-    }
 };
 
 can_ok(Class => qw(person has_person person_name person_age name age quid));
@@ -91,6 +53,7 @@ is($object->person_name, "Todd", "handles method");
 is($object->person->name, "Todd", "traditional lookup");
 is($object->person_age, 37, "handles method");
 is($object->person->age, 37, "traditional lookup");
+is($object->person_hello, 'Hello, Todd', 'curring');
 
 my $object2 = Class->new(person => Person->new(name => "Philbert"));
 ok($object2->has_person, "we have a person from the constructor");
@@ -98,7 +61,7 @@ is($object2->person_name, "Philbert", "handles method");
 is($object2->person->name, "Philbert", "traditional lookup");
 is($object2->person_age, undef, "no age because we didn't use the default");
 is($object2->person->age, undef, "no age because we didn't use the default");
-
+is($object2->person_hello, 'Hello, Philbert', 'currying');
 
 ok($object->quid, "we have a Shawn");
 is($object->name, "Shawn", "name handle");
@@ -114,34 +77,30 @@ is_deeply(
 
 is_deeply(
     $object->meta->get_attribute('person')->handles,
-    { person_name => 'name', person_age => 'age' },
+    { person_name => 'name', person_age => 'age', person_hello => [make_string => 'Hello, %s']},
     "correct handles layout for 'person'",
 );
 
+throws_ok{
+    $object->person(undef);
+    $object->person_name();
+} qr/Cannot delegate person_name to name because the value of person is not defined/;
 
-{
-    local $TODO = "failed on some environment, but I don't know why it happens (gfx)";
-    throws_ok{
-        $object->person(undef);
-        $object->person_name();
-    } qr/Cannot delegate person_name to name because the value of person is not defined/;
-
-    throws_ok{
-        $object->person([]);
-        $object->person_age();
-    } qr/Cannot delegate person_age to age because the value of person is not an object/;
-}
+throws_ok{
+    $object->person([]);
+    $object->person_age();
+} qr/Cannot delegate person_age to age because the value of person is not an object/;
 
-eval{
+throws_ok{
     $object->person(undef);
     $object->person_name();
-};
-like $@, qr/Cannot delegate person_name to name because the value of person is not defined/;
+} qr/Cannot delegate person_name to name because the value of person is not defined/;
 
-eval{
+throws_ok{
     $object->person([]);
     $object->person_age();
-};
-like $@, qr/Cannot delegate person_age to age because the value of person is not an object/;
+} qr/Cannot delegate person_age to age because the value of person is not an object/;
+
 
+done_testing;