Some fixes and test improvements for roles

[gitmo/Mouse.git] / lib / Mouse / Role.pm

diff --git a/lib/Mouse/Role.pm b/lib/Mouse/Role.pm
index 312f1ad..10621cc 100644 (file)
--- a/lib/Mouse/Role.pm
+++ b/lib/Mouse/Role.pm
@@ -32,10 +32,18 @@ do {
             return sub { }
         },
         has => sub {
-            return sub { }
+            my $caller = $CALLER;
+            return sub {
+                my $name = shift;
+                my %opts = @_;
+
+                $caller->meta->add_attribute($name => \%opts);
+            }
         },
         with => sub {
-            return sub { }
+            return sub {
+                confess "Role does not currently support 'with'";
+            }
         },
         requires => sub {
             return sub { }
@@ -66,6 +74,13 @@ do {
     }
 
     sub unimport {
+        my $caller = caller;
+
+        no strict 'refs';
+        for my $keyword (keys %exports) {
+            next if $keyword eq 'meta'; # we don't delete this one
+            delete ${ $caller . '::' }{$keyword};
+        }
     }
 };