with_immutable needs to test both mutable and immutable conditions

[gitmo/MooseX-UndefTolerant.git] / t / defaults.t

diff --git a/t/defaults.t b/t/defaults.t
index cca5ed8..34f25cd 100644 (file)
--- a/t/defaults.t
+++ b/t/defaults.t
@@ -1,3 +1,6 @@
+use strict;
+use warnings;
+
 use Test::More;
 use Test::Fatal;
 use Test::Moose;
@@ -86,22 +89,23 @@ sub do_tests_with_class
     }
 
     TODO: {
-        local $TODO;
-
         my $e = exception {
             my $obj = $class->new(attr1 => undef, attr3 => undef);
             {
                 local $TODO = 'not sure why this fails still... needs attr trait rewrite' if $obj->meta->is_immutable;
+                # FIXME: the object is successfully constructed, and the value
+                # for attr1 is properly removed, but the default is not then
+                # used instead...
+                # note "### constructed object: ", $obj->dump(2);
                 ok($obj->has_attr1, 'UT attr1 has a value when assigned undef in constructor');
-                ok($obj->has_attr3, 'attr3 retains its undef value when assigned undef in constructor');
-
                 is($obj->attr1, 1, 'attr1\'s value is its default');
             }
+            ok($obj->has_attr3, 'attr3 retains its undef value when assigned undef in constructor');
 
             is($obj->attr2, 2, 'attr2\'s value is its default');
             is($obj->attr3, undef, 'attr3\'s value is not its default (explicitly set)');
         };
-        $TODO = 'some immutable cases are not handled yet; see CAVEATS'
+        local $TODO = 'some immutable cases are not handled yet; see CAVEATS'
             if $class->meta->is_immutable and $class eq 'Foo';
 
         is($e, undef, 'these tests do not die');