From: Karen Etheridge Date: Sat, 14 Sep 2013 20:46:53 +0000 (-0700) Subject: fix spelling, whitespace, unused vars release test failures X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo%2FMooseX-Types-Common.git;a=commitdiff_plain;h=d174f7682d8e311e9743fa3383779b2531721673;hp=3ebb788b98575c2a4e0187c61145bf291f23db1b fix spelling, whitespace, unused vars release test failures --- diff --git a/lib/MooseX/Types/Common.pm b/lib/MooseX/Types/Common.pm index 92f894d..91ef68c 100644 --- a/lib/MooseX/Types/Common.pm +++ b/lib/MooseX/Types/Common.pm @@ -6,7 +6,7 @@ use warnings; use Carp qw/cluck/; sub import { - my $package = shift; + my $self = shift; return unless @_; cluck("Tried to import the symbols " . join(', ', @_) . " from MooseX::Types::Common.\nDid you mean " diff --git a/lib/MooseX/Types/Common/Numeric.pm b/lib/MooseX/Types/Common/Numeric.pm index ae3e57e..5336fed 100644 --- a/lib/MooseX/Types/Common/Numeric.pm +++ b/lib/MooseX/Types/Common/Numeric.pm @@ -144,23 +144,23 @@ default. =over -=item * PositiveNum +=item * C -=item * PositiveOrZeroNum +=item * C -=item * PositiveInt +=item * C -=item * PositiveOrZeroInt +=item * C -=item * NegativeNum +=item * C -=item * NegativeOrZeroNum +=item * C -=item * NegativeInt +=item * C -=item * NegativeOrZeroInt +=item * C -=item * SingleDigit +=item * C =back diff --git a/lib/MooseX/Types/Common/String.pm b/lib/MooseX/Types/Common/String.pm index 6d34354..ac1f37a 100644 --- a/lib/MooseX/Types/Common/String.pm +++ b/lib/MooseX/Types/Common/String.pm @@ -134,7 +134,7 @@ subtype LowerCaseSimpleStr, } : () ); - + coerce LowerCaseSimpleStr, from NonEmptySimpleStr, via { lc }; @@ -176,46 +176,46 @@ default. =over -=item * SimpleStr +=item * C -A Str with no new-line characters. +A C with no new-line characters. -=item * NonEmptySimpleStr +=item * C -A Str with no new-line characters and length > 0 +A C with no new-line characters and length > 0 -=item * LowerCaseSimpleStr +=item * C -A Str with no new-line characters, length > 0 and no uppercase characters -A coercion exists via C from NonEmptySimpleStr +A C with no new-line characters, length > 0 and no uppercase characters +A coercion exists via C from C -=item * UpperCaseSimpleStr +=item * C -A Str with no new-line characters, length > 0 and no lowercase characters -A coercion exists via C from NonEmptySimpleStr +A C with no new-line characters, length > 0 and no lowercase characters +A coercion exists via C from C -=item * Password +=item * C -=item * StrongPassword +=item * C -=item * NonEmptyStr +=item * C -A Str with length > 0 +A C with length > 0 -=item * LowerCaseStr +=item * C -A Str with length > 0 and no uppercase characters. -A coercion exists via C from NonEmptyStr +A C with length > 0 and no uppercase characters. +A coercion exists via C from C -=item * UpperCaseStr +=item * C -A Str with length > 0 and no lowercase characters. -A coercion exists via C from NonEmptyStr +A C with length > 0 and no lowercase characters. +A coercion exists via C from C -=item * NumericCode +=item * C -A Str with no new-line characters that consists of only Numeric characters. -Examples include, Social Security Numbers, PINs, Postal Codes, HTTP Status +A C with no new-line characters that consists of only Numeric characters. +Examples include, Social Security Numbers, Personal Identification Numbers, Postal Codes, HTTP Status Codes, etc. Supports attempting to coerce from a string that has punctuation in it ( e.g credit card number 4111-1111-1111-1111 ).