Make the meta classes more Moose-y.

[gitmo/MooseX-StrictConstructor.git] / lib / MooseX / StrictConstructor / Meta / Method / Constructor.pm

diff --git a/lib/MooseX/StrictConstructor/Meta/Method/Constructor.pm b/lib/MooseX/StrictConstructor/Meta/Method/Constructor.pm
index 7d2017c..45b1fd8 100644 (file)
--- a/lib/MooseX/StrictConstructor/Meta/Method/Constructor.pm
+++ b/lib/MooseX/StrictConstructor/Meta/Method/Constructor.pm
@@ -3,29 +3,68 @@ package MooseX::StrictConstructor::Meta::Method::Constructor;
 use strict;
 use warnings;
 
+use Carp ();
 use Moose;
 
 extends 'Moose::Meta::Method::Constructor';
 
-sub _generate_BUILDALL ## no critic RequireArgUnpacking
+override '_generate_BUILDALL' => sub ## no critic RequireArgUnpacking
 {
     my $self = shift;
 
-    my $calls = $self->SUPER::_generate_BUILDALL(@_);
+    my $source = $self->SUPER::_generate_BUILDALL(@_);
+    $source .= ";\n" if $source;
 
-    $calls .= <<'EOF';
-    my %attrs = map { $_->name() => 1 } $self->meta()->compute_all_applicable_attributes();
+    my @attrs = map { $_->name() . ' => 1,' } @{ $self->attributes() };
 
-    my @bad = sort grep { ! $attrs{$_} }  keys %params;
+    $source .= <<"EOF";
+my \%attrs = (@attrs);
 
-    if (@bad)
-    {
-        confess "Found unknown attribute(s) passed to the constructor: @bad";
-    }
+my \@bad = sort grep { ! \$attrs{\$_} }  keys \%params;
+
+if (\@bad) {
+    Carp::confess "Found unknown attribute(s) passed to the constructor: \@bad";
+}
 EOF
 
-    return $calls;
+    return $source;
 };
 
+no Moose;
+
 
 1;
+
+__END__
+
+=pod
+
+=head1 NAME
+
+MooseX::StrictConstructor::Meta::Method::Constructor - A meta class to make immutable constructors strict
+
+=head1 SYNOPSIS
+
+  use MooseX::StrictConstructor;
+
+=head1 DESCRIPTION
+
+This class simply overrides C<_generate_BUILDALL()> in
+C<Moose::Meta::Method::Constructor> so that classes that are made
+immutable have a strict constructor.
+
+You should never have to use this class directly.
+
+=head1 AUTHOR
+
+Dave Rolsky, C<< <autarch@urth.org> >>
+
+=head1 COPYRIGHT & LICENSE
+
+Copyright 2007 Dave Rolsky, All Rights Reserved.
+
+This program is free software; you can redistribute it and/or modify
+it under the same terms as Perl itself.
+
+=cut
+