use B 'perlstring';
use Scalar::Util 'blessed';
use overload ();
+use Module::Runtime qw(use_module);
BEGIN {
our $CAN_HAZ_XS =
!$ENV{MOO_XS_DISABLE}
;
}
+sub _die_overwrite
+{
+ my ($pkg, $method, $type) = @_;
+ die "You cannot overwrite a locally defined method ($method) with @{[ $type || 'an accessor' ]}";
+}
+
sub generate_method {
my ($self, $into, $name, $spec, $quote_opts) = @_;
- $name =~ s/^\+//;
+ $spec->{allow_overwrite}++ if $name =~ s/^\+//;
die "Must have an is" unless my $is = $spec->{is};
if ($is eq 'ro') {
$spec->{reader} = $name unless exists $spec->{reader};
} elsif ($is eq 'rw') {
- $spec->{accessor} = $name unless exists $spec->{accessor};
+ $spec->{accessor} = $name unless exists $spec->{accessor}
+ or ( $spec->{reader} and $spec->{writer} );
} elsif ($is eq 'lazy') {
$spec->{reader} = $name unless exists $spec->{reader};
$spec->{lazy} = 1;
} elsif ($is ne 'bare') {
die "Unknown is ${is}";
}
- $spec->{builder} = '_build_'.$name if ($spec->{builder}||0) eq 1;
- die "Invalid builder for $into->$name - not a string"
- if exists $spec->{builder} and ref $spec->{builder};
+ if (exists $spec->{builder}) {
+ if(ref $spec->{builder}) {
+ die "Invalid builder for $into->$name - not a method name, coderef or"
+ . " code-convertible object"
+ unless ref $spec->{builder} eq 'CODE'
+ or (blessed($spec->{builder}) and eval { \&{$spec->{builder}} });
+ $spec->{builder_sub} = $spec->{builder};
+ $spec->{builder} = 1;
+ }
+ $spec->{builder} = '_build_'.$name if ($spec->{builder}||0) eq 1;
+ die "Invalid builder for $into->$name - not a valid method name"
+ if $spec->{builder} !~ /\A[A-Za-z_][A-Za-z0-9_]*(?:::[A-Za-z_][A-Za-z0-9_]*)*\z/;
+ }
if (($spec->{predicate}||0) eq 1) {
$spec->{predicate} = $name =~ /^_/ ? "_has${name}" : "has_${name}";
}
$spec->{trigger} = quote_sub('shift->_trigger_'.$name.'(@_)');
}
- for my $setting (qw( default coerce )) {
- next if !exists $spec->{$setting};
- my $value = $spec->{$setting};
- my $invalid = "Invalid $setting '" . overload::StrVal($value)
+ if (exists $spec->{coerce}) {
+ my $value = $spec->{coerce};
+ my $invalid = "Invalid coerce '" . overload::StrVal($value)
. "' for $into->$name - not a coderef";
die "$invalid or code-convertible object"
unless ref $value and (ref $value eq 'CODE' or blessed($value));
if !eval { \&$value };
}
+ if (exists $spec->{default}) {
+ my $value = $spec->{default};
+ if (!defined $value || ref $value) {
+ my $invalid = "Invalid default '" . overload::StrVal($value)
+ . "' for $into->$name - not a coderef or non-ref";
+ die "$invalid or code-convertible object"
+ unless ref $value and (ref $value eq 'CODE' or blessed($value));
+ die "$invalid and could not be converted to a coderef: $@"
+ if !eval { \&$value };
+ }
+ }
+
+
my %methods;
if (my $reader = $spec->{reader}) {
+ _die_overwrite($into, $reader, 'a reader')
+ if !$spec->{allow_overwrite} && *{_getglob("${into}::${reader}")}{CODE};
if (our $CAN_HAZ_XS && $self->is_simple_get($name, $spec)) {
$methods{$reader} = $self->_generate_xs(
getters => $into, $reader, $name, $spec
}
}
if (my $accessor = $spec->{accessor}) {
+ _die_overwrite($into, $accessor, 'an accessor')
+ if !$spec->{allow_overwrite} && *{_getglob("${into}::${accessor}")}{CODE};
if (
our $CAN_HAZ_XS
&& $self->is_simple_get($name, $spec)
}
}
if (my $writer = $spec->{writer}) {
+ _die_overwrite($into, $writer, 'a writer')
+ if !$spec->{allow_overwrite} && *{_getglob("${into}::${writer}")}{CODE};
if (
our $CAN_HAZ_XS
&& $self->is_simple_set($name, $spec)
}
}
if (my $pred = $spec->{predicate}) {
+ _die_overwrite($into, $pred, 'a predicate')
+ if !$spec->{allow_overwrite} && *{_getglob("${into}::${pred}")}{CODE};
$methods{$pred} =
quote_sub "${into}::${pred}" =>
' '.$self->_generate_simple_has('$_[0]', $name, $spec)."\n"
;
}
+ if (my $pred = $spec->{builder_sub}) {
+ _install_coderef( "${into}::$spec->{builder}" => $spec->{builder_sub} );
+ }
if (my $cl = $spec->{clearer}) {
+ _die_overwrite($into, $cl, 'a clearer')
+ if !$spec->{allow_overwrite} && *{_getglob("${into}::${cl}")}{CODE};
$methods{$cl} =
quote_sub "${into}::${cl}" =>
$self->_generate_simple_clear('$_[0]', $name, $spec)."\n"
map [ $_ => ref($hspec->{$_}) ? @{$hspec->{$_}} : $hspec->{$_} ],
keys %$hspec;
} elsif (!ref($hspec)) {
- map [ $_ => $_ ], Role::Tiny->methods_provided_by($hspec);
+ map [ $_ => $_ ], use_module('Role::Tiny')->methods_provided_by(use_module($hspec))
} else {
die "You gave me a handles of ${hspec} and I have no idea why";
}
};
- foreach my $spec (@specs) {
- my ($proxy, $target, @args) = @$spec;
+ foreach my $delegation_spec (@specs) {
+ my ($proxy, $target, @args) = @$delegation_spec;
+ _die_overwrite($into, $proxy, 'a delegation')
+ if !$spec->{allow_overwrite} && *{_getglob("${into}::${proxy}")}{CODE};
$self->{captures} = {};
$methods{$proxy} =
quote_sub "${into}::${proxy}" =>
}
if (my $asserter = $spec->{asserter}) {
$self->{captures} = {};
+
+
$methods{$asserter} =
- quote_sub "${into}::${asserter}" =>
- 'do { '.$self->_generate_get($name, $spec).qq! }||die "Attempted to access '${name}' but it is not set"!,
+ quote_sub "${into}::${asserter}" => $self->_generate_asserter($name, $spec),
delete $self->{captures}
;
}
sub _generate_get_default {
my ($self, $me, $name, $spec) = @_;
- $spec->{default}
- ? $self->_generate_call_code($name, 'default', $me, $spec->{default})
- : "${me}->${\$spec->{builder}}"
+ if (exists $spec->{default}) {
+ ref $spec->{default}
+ ? $self->_generate_call_code($name, 'default', $me, $spec->{default})
+ : perlstring $spec->{default};
+ }
+ else {
+ "${me}->${\$spec->{builder}}"
+ }
}
sub generate_simple_get {
($code, delete $self->{captures});
}
+sub _attr_desc {
+ my ($name, $init_arg) = @_;
+ return perlstring($name) if !defined($init_arg) or $init_arg eq $name;
+ return perlstring($name).' (constructor argument: '.perlstring($init_arg).')';
+}
+
sub _generate_coerce {
- my ($self, $name, $value, $coerce) = @_;
+ my ($self, $name, $value, $coerce, $init_arg) = @_;
$self->_generate_die_prefix(
- "coercion for ${\perlstring($name)} failed: ",
+ "coercion for ${\_attr_desc($name, $init_arg)} failed: ",
$self->_generate_call_code($name, 'coerce', "${value}", $coerce)
);
}
}
sub _generate_isa_check {
- my ($self, $name, $value, $check) = @_;
+ my ($self, $name, $value, $check, $init_arg) = @_;
$self->_generate_die_prefix(
- "isa check for ${\perlstring($name)} failed: ",
+ "isa check for ${\_attr_desc($name, $init_arg)} failed: ",
$self->_generate_call_code($name, 'isa_check', $value, $check)
);
}
sub _generate_call_code {
my ($self, $name, $type, $values, $sub) = @_;
+ $sub = \&{$sub} if blessed($sub); # coderef if blessed
if (my $quoted = quoted_from_sub($sub)) {
my $code = $quoted->[1];
if (my $captures = $quoted->[2]) {
}
sub _generate_populate_set {
- my ($self, $me, $name, $spec, $source, $test) = @_;
+ my ($self, $me, $name, $spec, $source, $test, $init_arg) = @_;
if ($self->has_eager_default($name, $spec)) {
my $get_indent = ' ' x ($spec->{isa} ? 6 : 4);
my $get_default = $self->_generate_get_default(
if ($spec->{coerce}) {
$get_value = $self->_generate_coerce(
$name, $get_value,
- $spec->{coerce}
+ $spec->{coerce}, $init_arg
)
}
($spec->{isa}
? " {\n my \$value = ".$get_value.";\n "
.$self->_generate_isa_check(
- $name, '$value', $spec->{isa}
+ $name, '$value', $spec->{isa}, $init_arg
).";\n"
.' '.$self->_generate_simple_set($me, $name, $spec, '$value').";\n"
." }\n"
? " $source = "
.$self->_generate_coerce(
$name, $source,
- $spec->{coerce}
+ $spec->{coerce}, $init_arg
).";\n"
: ""
)
.($spec->{isa}
? " "
.$self->_generate_isa_check(
- $name, $source, $spec->{isa}
+ $name, $source, $spec->{isa}, $init_arg
).";\n"
: ""
)
#
# but requires XS and is just too damn crazy
# so simply throw a better exception
- my $weak_simple = "my \$preserve; Scalar::Util::weaken(${simple})";
+ my $weak_simple = "my \$preserve; Scalar::Util::weaken(${simple}); no warnings 'void'; \$preserve";
Moo::_Utils::lt_5_8_3() ? <<"EOC" : $weak_simple;
my \$preserve;
- eval { Scalar::Util::weaken($simple); 1 } or do {
- if( \$@ =~ /Modification of a read-only value attempted/) {
- require Carp;
- Carp::croak( sprintf (
- 'Reference to readonly value in "%s" can not be weakened on Perl < 5.8.3',
- $name_str,
- ) );
- } else {
- die \$@;
+ eval { Scalar::Util::weaken($simple); 1 }
+ ? do { no warnings 'void'; \$preserve; }
+ : do {
+ if( \$@ =~ /Modification of a read-only value attempted/) {
+ require Carp;
+ Carp::croak( sprintf (
+ 'Reference to readonly value in "%s" can not be weakened on Perl < 5.8.3',
+ $name_str,
+ ) );
+ } else {
+ die \$@;
+ }
}
- };
EOC
} else {
$self->_generate_core_set($me, $name, $spec, $value);
."\n : ".$self->_generate_get($name, $spec)."\n )";
}
+sub _generate_asserter {
+ my ($self, $name, $spec) = @_;
+
+ "do {\n"
+ ." my \$val = ".$self->_generate_get($name, $spec).";\n"
+ ." unless (".$self->_generate_simple_has('$_[0]', $name, $spec).") {\n"
+ .qq! die "Attempted to access '${name}' but it is not set";\n!
+ ." }\n"
+ ." \$val;\n"
+ ."}\n";
+}
sub _generate_delegation {
my ($self, $asserter, $target, $args) = @_;
my $arg_string = do {
projects / gitmo/Moo.git / blobdiff