14 years agoFix RT49301
Peter Rabbitson [Sat, 3 Oct 2009 18:08:31 +0000]
Fix RT49301

14 years agoFix TT templates and tests
Peter Rabbitson [Sat, 3 Oct 2009 18:06:40 +0000]
Fix TT templates and tests

14 years agoAdd numeric/decimal precision support to DB2 producer
Peter Rabbitson [Sat, 3 Oct 2009 18:01:27 +0000]
Add numeric/decimal precision support to DB2 producer

14 years agoAdd a size/precision field to test file, make sure xml parser/producer work fine
Peter Rabbitson [Sat, 3 Oct 2009 17:57:32 +0000]
Add a size/precision field to test file, make sure xml parser/producer work fine

14 years agoRelease 0.11003
Peter Rabbitson [Mon, 28 Sep 2009 06:49:11 +0000]
Release 0.11003

14 years agoDep fixes and changes
Peter Rabbitson [Mon, 28 Sep 2009 06:19:12 +0000]
Dep fixes and changes

14 years agoMake maybe_plan insufficent-version-aware
Peter Rabbitson [Mon, 28 Sep 2009 06:14:55 +0000]
Make maybe_plan insufficent-version-aware

14 years agoEnforce XML::LibXML version requirements
Peter Rabbitson [Thu, 24 Sep 2009 21:36:12 +0000]
Enforce XML::LibXML version requirements

14 years agoFix RT#27438
Peter Rabbitson [Thu, 24 Sep 2009 07:16:11 +0000]
Fix RT#27438

14 years agoproper pg timestamp parsing (by mo)
Peter Rabbitson [Fri, 18 Sep 2009 22:47:52 +0000]
proper pg timestamp parsing (by mo)

14 years agoSomeone claimed this doesn't work
Peter Rabbitson [Fri, 18 Sep 2009 19:26:57 +0000]
Someone claimed this doesn't work

14 years agoCleanup changelog
Peter Rabbitson [Mon, 7 Sep 2009 11:03:31 +0000]
Cleanup changelog

14 years agoChanges
Peter Rabbitson [Thu, 3 Sep 2009 07:08:56 +0000]
Changes

14 years agoFix pg matchtype parsing
Peter Rabbitson [Thu, 3 Sep 2009 07:06:25 +0000]
Fix pg matchtype parsing

14 years agoReal 0.11002 release
Peter Rabbitson [Sun, 30 Aug 2009 09:50:44 +0000]
Real 0.11002 release

14 years agoSanify test
Peter Rabbitson [Sun, 30 Aug 2009 09:40:11 +0000]
Sanify test

14 years agoRelease 0.11002
Peter Rabbitson [Fri, 28 Aug 2009 12:11:02 +0000]
Release 0.11002

14 years agoMakefile fixes + changes
Peter Rabbitson [Fri, 28 Aug 2009 12:09:27 +0000]
Makefile fixes + changes

14 years agoAdded "skip_tables" options.
Ken Youens-Clark [Wed, 26 Aug 2009 16:30:37 +0000]
Added "skip_tables" options.

14 years agoChanged "no_columns" arg to "num_columns" (I used to use "no_" for both
Ken Youens-Clark [Wed, 26 Aug 2009 16:18:10 +0000]
Changed "no_columns" arg to "num_columns" (I used to use "no_" for both
"number" and "not", but I maintain backward compatibility on this arg name),
added simple docs on all the producer args, made some args more flexible,
added "skip_tables(_like)" arg.

14 years agoRelease 0.11001
Peter Rabbitson [Tue, 18 Aug 2009 20:36:21 +0000]
Release 0.11001

14 years agoYAML is a test-dep (or at least it's a good thing to have)
Peter Rabbitson [Tue, 18 Aug 2009 20:29:26 +0000]
YAML is a test-dep (or at least it's a good thing to have)
Remove last piece of Readonly

14 years agoChanges + Reverts for 0.11000, see Changes file for info
Jess Robinson [Tue, 18 Aug 2009 06:57:49 +0000]
Changes + Reverts for 0.11000, see Changes file for info

14 years agoChanged version number to stay consistent with new scheme.
Ken Youens-Clark [Fri, 14 Aug 2009 16:25:33 +0000]
Changed version number to stay consistent with new scheme.

14 years agoUpped version numbers, cleaned up code, fixed my name.
Ken Youens-Clark [Thu, 13 Aug 2009 19:04:24 +0000]
Upped version numbers, cleaned up code, fixed my name.

14 years agoRemoving, make dist smaller.
Ken Youens-Clark [Thu, 13 Aug 2009 18:44:06 +0000]
Removing, make dist smaller.

14 years agoJust a cleaner version of "next_unused_name."
Ken Youens-Clark [Thu, 13 Aug 2009 16:38:31 +0000]
Just a cleaner version of "next_unused_name."

14 years agoFixed test.
Ken Youens-Clark [Thu, 13 Aug 2009 16:38:10 +0000]
Fixed test.

14 years agoLeave out empty bits.
Ken Youens-Clark [Thu, 13 Aug 2009 16:18:05 +0000]
Leave out empty bits.

14 years agoFixed test.
Ken Youens-Clark [Thu, 13 Aug 2009 16:07:31 +0000]
Fixed test.

14 years agoAdded tests for RT#37814 (parsing of double quotes, autoincrement).
Ken Youens-Clark [Thu, 13 Aug 2009 15:55:03 +0000]
Added tests for RT#37814 (parsing of double quotes, autoincrement).

14 years agoFixes per RT#37814 (parsing of field/index names with double quotes, also fix
Ken Youens-Clark [Thu, 13 Aug 2009 15:54:30 +0000]
Fixes per RT#37814 (parsing of field/index names with double quotes, also fix
to AUTOINCREMENT col attr).

14 years agoAdded patch from user (RT#42548).
Ken Youens-Clark [Thu, 13 Aug 2009 15:21:29 +0000]
Added patch from user (RT#42548).

14 years agoSome whitespace fixes, resolve RT#42548 (incorrectly inserts the size in
Ken Youens-Clark [Thu, 13 Aug 2009 15:20:21 +0000]
Some whitespace fixes, resolve RT#42548 (incorrectly inserts the size in
'time(stamp)? with(out) time zone' fields).

14 years agoUpping version per RT#43173, fixed my name.
Ken Youens-Clark [Thu, 13 Aug 2009 15:01:52 +0000]
Upping version per RT#43173, fixed my name.

14 years agoUpped version for 0.10 release.
Ken Youens-Clark [Wed, 12 Aug 2009 21:21:16 +0000]
Upped version for 0.10 release.

14 years agoFixed some whitespace, resolve RT#13915 by requiring XML and YAML libs.
Ken Youens-Clark [Wed, 12 Aug 2009 21:20:44 +0000]
Fixed some whitespace, resolve RT#13915 by requiring XML and YAML libs.

14 years agoResolves RT#8847.
Ken Youens-Clark [Wed, 12 Aug 2009 21:17:43 +0000]
Resolves RT#8847.

14 years agoResolves RT#21065.
Ken Youens-Clark [Wed, 12 Aug 2009 21:08:39 +0000]
Resolves RT#21065.

14 years agoResolves RT#35448.
Ken Youens-Clark [Wed, 12 Aug 2009 21:00:37 +0000]
Resolves RT#35448.

14 years agoJust fixed some whitespace.
Ken Youens-Clark [Wed, 12 Aug 2009 20:14:31 +0000]
Just fixed some whitespace.

14 years agoFixed my name, fixed some use of uninitialized vars.
Ken Youens-Clark [Wed, 12 Aug 2009 15:18:45 +0000]
Fixed my name, fixed some use of uninitialized vars.

14 years agoSmoother regex (thanks Jim Thomason).
Ken Youens-Clark [Wed, 12 Aug 2009 15:08:49 +0000]
Smoother regex (thanks Jim Thomason).

14 years agoJust whitespace changes -- I wouldn't normally commit something like this, but
Ken Youens-Clark [Wed, 12 Aug 2009 15:06:14 +0000]
Just whitespace changes -- I wouldn't normally commit something like this, but
I got to working on this and realized I was changing the wrong thing.

14 years agoSome whitespace changes, create a default index name if one is not provided.
Ken Youens-Clark [Wed, 12 Aug 2009 15:05:27 +0000]
Some whitespace changes, create a default index name if one is not provided.

14 years agoAdding patch from user.
Ken Youens-Clark [Wed, 12 Aug 2009 15:04:51 +0000]
Adding patch from user.

14 years agoAdded parsing of index types (btree, rtree, hash).
Ken Youens-Clark [Wed, 12 Aug 2009 15:03:19 +0000]
Added parsing of index types (btree, rtree, hash).

14 years agoAdded "using btree" for test.
Ken Youens-Clark [Wed, 12 Aug 2009 15:01:16 +0000]
Added "using btree" for test.

14 years agoUse Readonly for constant value, some aesthetic changes.
Ken Youens-Clark [Wed, 12 Aug 2009 13:54:35 +0000]
Use Readonly for constant value, some aesthetic changes.

14 years agoResolves RT#48025.
Ken Youens-Clark [Tue, 11 Aug 2009 21:36:43 +0000]
Resolves RT#48025.

14 years agoParsing of foreign keys.
Ken Youens-Clark [Tue, 11 Aug 2009 21:33:03 +0000]
Parsing of foreign keys.

14 years agoTest and data for FK in SQLite.
Ken Youens-Clark [Tue, 11 Aug 2009 21:32:31 +0000]
Test and data for FK in SQLite.

14 years agoAdded tests for check constraint.
Ken Youens-Clark [Tue, 11 Aug 2009 21:04:32 +0000]
Added tests for check constraint.

14 years agoChanges to handle a constraint like:
Ken Youens-Clark [Tue, 11 Aug 2009 21:03:20 +0000]
Changes to handle a constraint like:
CONSTRAINT AVCON_4287_PARAM_000 CHECK
(trait_category IN ('S', 'A', 'E')) ENABLE

14 years agoAdded return of diff as array in list context.
Ken Youens-Clark [Tue, 11 Aug 2009 18:07:04 +0000]
Added return of diff as array in list context.

14 years agoAdded test for list context return.
Ken Youens-Clark [Tue, 11 Aug 2009 18:06:45 +0000]
Added test for list context return.

14 years agoUse accessors instead of reaching down object guts
Peter Rabbitson [Mon, 10 Aug 2009 21:48:04 +0000]
Use accessors instead of reaching down object guts

14 years agoAdding.
Ken Youens-Clark [Fri, 7 Aug 2009 21:07:59 +0000]
Adding.

14 years agoFixing my name (is this vain?).
Ken Youens-Clark [Fri, 7 Aug 2009 21:06:44 +0000]
Fixing my name (is this vain?).

14 years agoAdded a little more POD on clustering.
Ken Youens-Clark [Fri, 7 Aug 2009 21:03:53 +0000]
Added a little more POD on clustering.

14 years agoCatch case of specifying 'DBI-Driver' and quietly fix this.
Ken Youens-Clark [Fri, 7 Aug 2009 21:03:16 +0000]
Catch case of specifying 'DBI-Driver' and quietly fix this.

14 years agoMake a little more flexible.
Ken Youens-Clark [Fri, 7 Aug 2009 21:01:48 +0000]
Make a little more flexible.

14 years agoNeed to call "load" as a class method rather than an object method.
Ken Youens-Clark [Fri, 7 Aug 2009 20:48:46 +0000]
Need to call "load" as a class method rather than an object method.

14 years agoJust made a little more readable.
Ken Youens-Clark [Fri, 7 Aug 2009 18:37:57 +0000]
Just made a little more readable.

14 years agoFix for bleadperl
Peter Rabbitson [Tue, 30 Jun 2009 10:14:49 +0000]
Fix for bleadperl

14 years agoThe indexer does not understand license links
Peter Rabbitson [Fri, 26 Jun 2009 18:31:25 +0000]
The indexer does not understand license links

14 years agoRelease 0.09007
Peter Rabbitson [Thu, 25 Jun 2009 00:01:41 +0000]
Release 0.09007

14 years agoMSSQL fixes and improvements
Peter Rabbitson [Wed, 24 Jun 2009 23:59:50 +0000]
MSSQL fixes and improvements
No additional tests as things are a mess. Besides t/60roundtrip.t does exactly what it is supposed to do

14 years agoDo not cache the P::RD grammar - it breaks stuff
Peter Rabbitson [Wed, 24 Jun 2009 22:43:41 +0000]
Do not cache the P::RD grammar - it breaks stuff

14 years agoMssql does not understand ON DELETE RESTRICT
Peter Rabbitson [Thu, 18 Jun 2009 12:20:57 +0000]
Mssql does not understand ON DELETE RESTRICT

14 years agoWhy the fuck did I do that ???
Peter Rabbitson [Mon, 15 Jun 2009 20:06:29 +0000]
Why the fuck did I do that ???

14 years agoBackout teejay's changes to get trunk stable again
Peter Rabbitson [Mon, 15 Jun 2009 07:26:52 +0000]
Backout teejay's changes to get trunk stable again

14 years agofixed triggers
Aaron Trevena [Sat, 13 Jun 2009 19:29:15 +0000]
fixed triggers

14 years agoadded expected trigger and stored procedure output
Aaron Trevena [Sat, 13 Jun 2009 19:28:24 +0000]
added expected trigger and stored procedure output

14 years agoadded triggers and procedures
Aaron Trevena [Fri, 12 Jun 2009 20:31:15 +0000]
added triggers and procedures

14 years ago(bugfixed) release 0.09006
Peter Rabbitson [Wed, 10 Jun 2009 13:12:35 +0000]
(bugfixed) release 0.09006

14 years agoSaner Changes
Peter Rabbitson [Tue, 9 Jun 2009 21:06:08 +0000]
Saner Changes

14 years agoProper support for size in pg timestamp columns (patch by mo)
Peter Rabbitson [Tue, 9 Jun 2009 21:04:41 +0000]
Proper support for size in pg timestamp columns (patch by mo)

14 years agoMore test sanification
Peter Rabbitson [Tue, 9 Jun 2009 20:59:36 +0000]
More test sanification

14 years agoSwitch the roundtrip test to the yaml base source. Add test skips
Peter Rabbitson [Tue, 9 Jun 2009 20:52:28 +0000]
Switch the roundtrip test to the yaml base source. Add test skips

14 years agoCreate a YAML copy of the main roundtrip schema - this is what we use to run t/60roun...
Peter Rabbitson [Tue, 9 Jun 2009 20:49:32 +0000]
Create a YAML copy of the main roundtrip schema - this is what we use to run t/60roundtrip.t without depending on LibXML. The YAML is regenerated on every Makefile.PL run

14 years agoTeach YAML producer to encode extra attributes
Peter Rabbitson [Tue, 9 Jun 2009 20:45:34 +0000]
Teach YAML producer to encode extra attributes

14 years agoFix a couple of tests and add forgotten dependency
Peter Rabbitson [Mon, 8 Jun 2009 22:46:43 +0000]
Fix a couple of tests and add forgotten dependency

14 years agoRelease 0.09005
Peter Rabbitson [Mon, 8 Jun 2009 20:26:56 +0000]
Release 0.09005

14 years agoFill in changes, todoify non-passing tests (to draw attention)
Peter Rabbitson [Sun, 7 Jun 2009 10:39:40 +0000]
Fill in changes, todoify non-passing tests (to draw attention)

14 years agoStrip exe bit
Peter Rabbitson [Sun, 7 Jun 2009 10:25:38 +0000]
Strip exe bit

14 years agoMerge 'roundtrip' into 'trunk'
Peter Rabbitson [Sun, 7 Jun 2009 10:20:47 +0000]
Merge 'roundtrip' into 'trunk'

r1509@Thesaurus (orig r1508):  ribasushi | 2009-04-27 17:38:24 +0200
Branch off to work on proper parser/producer roundtrips
r1512@Thesaurus (orig r1511):  ribasushi | 2009-04-28 09:34:49 +0200
Somewhat working global roundtrip test
r1513@Thesaurus (orig r1512):  ribasushi | 2009-04-28 09:36:46 +0200
Add an oversized varchar to schema.xml
r1514@Thesaurus (orig r1513):  ribasushi | 2009-04-28 09:43:29 +0200
Fix mysql roundtrip glitch
r1515@Thesaurus (orig r1514):  ribasushi | 2009-04-28 09:50:34 +0200
Test seems to be finioshed - massive bowl of FAIL
r1516@Thesaurus (orig r1515):  ribasushi | 2009-04-28 10:06:28 +0200
Bail out from failing tests early
r1517@Thesaurus (orig r1516):  ribasushi | 2009-04-28 10:14:59 +0200
Translator/schema dependency test
r1518@Thesaurus (orig r1517):  ribasushi | 2009-04-28 10:33:06 +0200
Todoify test - probably not in this lifetime
r1519@Thesaurus (orig r1518):  ribasushi | 2009-04-29 00:59:41 +0200
Changes to tests to go along r1512
r1527@Thesaurus (orig r1526):  ribasushi | 2009-05-03 04:46:58 +0200
Test XML roundtrip as well (also fail)
r1528@Thesaurus (orig r1527):  ribasushi | 2009-05-03 04:47:30 +0200
re-fix tests after merge
r1531@Thesaurus (orig r1530):  ribasushi | 2009-05-04 08:37:06 +0200
Rewind exhausted globs before attempting a read
(on a side note all this IO::Scalar business is just silly, not touching because a rewrite is imminent anyway)
r1532@Thesaurus (orig r1531):  ribasushi | 2009-05-04 09:10:44 +0200
Do not add xml comment header if no_comments is set
r1533@Thesaurus (orig r1532):  ribasushi | 2009-05-04 09:16:00 +0200
Better debug output
r1534@Thesaurus (orig r1533):  ribasushi | 2009-05-04 09:17:36 +0200
table/field counts are held per-object, not globally
Tests adjusted (no idea why they were initially written this way...)
r1535@Thesaurus (orig r1534):  ribasushi | 2009-05-04 09:30:12 +0200
Concentrate on testing the 'big 3' for now
r1536@Thesaurus (orig r1535):  ribasushi | 2009-05-04 10:13:51 +0200
Variable table and column names? wtf?!
r1537@Thesaurus (orig r1536):  ribasushi | 2009-05-04 10:16:19 +0200
SQLite improvements:
- Support parsing of all DROP clauses
- Support parsing of field-level comments
- When producing do not append table names to constraint/index names - it's useless
r1538@Thesaurus (orig r1537):  ribasushi | 2009-05-04 14:49:16 +0200
Adjust insane tests to pass (the expected returns at times are mind-boggling)
r1539@Thesaurus (orig r1538):  ribasushi | 2009-05-05 09:06:33 +0200
Fix a couple of mistakes in the PG parser
r1541@Thesaurus (orig r1540):  ribasushi | 2009-05-16 08:14:58 +0200
Add disabled YAML roundtrip test
r1551@Thesaurus (orig r1550):  ribasushi | 2009-06-07 10:11:01 +0200
VIEW support for Pg parser, also some cleanups
r1552@Thesaurus (orig r1551):  ribasushi | 2009-06-07 10:18:16 +0200
Add parenthesis into the VIEW definition to make sure the pg parser still can deal with them
r1553@Thesaurus (orig r1552):  ribasushi | 2009-06-07 10:26:06 +0200
The way we generate create view statements is not standards compliant (per RhodiumToad in #postgresql)
r1554@Thesaurus (orig r1553):  ribasushi | 2009-06-07 12:12:08 +0200
Multiple fixes for the SQLServer producer/parser combo
- Rip out braindead parts of mk_name (just like sqlite)
- Disable view/procedure production - they never worked in the first place
- Improvements to the parser to be able to actually parse what the producer spits out (no functional changes)

r1556@Thesaurus (orig r1555):  ribasushi | 2009-06-07 12:19:54 +0200
Make perlpod happy

14 years agoMake perlpod happy
Peter Rabbitson [Sun, 7 Jun 2009 10:19:54 +0000]
Make perlpod happy

14 years agoMerge 'trunk' into 'roundtrip'
Peter Rabbitson [Sun, 7 Jun 2009 10:13:16 +0000]
Merge 'trunk' into 'roundtrip'

r1529@Thesaurus (orig r1528):  ribasushi | 2009-05-03 10:34:46 +0200
Bring version bump back - there is still work to be done (reoundtrip branch), I think this is too early
r1530@Thesaurus (orig r1529):  ribasushi | 2009-05-04 07:49:50 +0200
Remove duplicate req
r1542@Thesaurus (orig r1541):  jawnsy | 2009-05-17 17:24:11 +0200
Applied patch to switch dependency on XML::XPath to XML::LibXML (Closes: RT#32130)
r1543@Thesaurus (orig r1542):  ribasushi | 2009-05-17 18:11:36 +0200
Update changelog
r1544@Thesaurus (orig r1543):  plutooth | 2009-05-28 00:24:13 +0200
MySQL producer skips length attribute for columns which do not support that attribute. Currently following column types are added to that list: date time timestamp datetime year
r1545@Thesaurus (orig r1544):  ribasushi | 2009-05-31 09:21:10 +0200
Add POD checker and fix a couple of POD errors
r1546@Thesaurus (orig r1545):  ribasushi | 2009-05-31 09:35:38 +0200
Reorder authors and consolidate them in one point (AUTHORS). Add link from main POD
r1547@Thesaurus (orig r1546):  ribasushi | 2009-06-01 13:53:44 +0200
Switch to Module::Install
Create a 'share' directory to be used with Module::Install::ShareDir / File::ShareDir
Move DiaUml tt2 files to share, adjust DiaUml producer (no tests but I think I got it right)
Move grammar files to sharedir too (only one for now, but this is where we will eventually keep all of them)

r1548@Thesaurus (orig r1547):  jgoulah | 2009-06-02 23:04:00 +0200
added parser support for MySQL default values with a single quote
r1549@Thesaurus (orig r1548):  ribasushi | 2009-06-03 12:44:44 +0200
Merge forgotten rewrite of the GraphViz producer - keep all the logic intact but do not do any parameter sanity checking - just pass things straight to GraphViz.pm
r1550@Thesaurus (orig r1549):  ribasushi | 2009-06-04 00:05:05 +0200
Graphviz does not like empty hahsrefs - prune those

14 years agoMultiple fixes for the SQLServer producer/parser combo
Peter Rabbitson [Sun, 7 Jun 2009 10:12:08 +0000]
Multiple fixes for the SQLServer producer/parser combo
- Rip out braindead parts of mk_name (just like sqlite)
- Disable view/procedure production - they never worked in the first place
- Improvements to the parser to be able to actually parse what the producer spits out (no functional changes)

14 years agoThe way we generate create view statements is not standards compliant (per RhodiumToa...
Peter Rabbitson [Sun, 7 Jun 2009 08:26:06 +0000]
The way we generate create view statements is not standards compliant (per RhodiumToad in #postgresql)

14 years agoAdd parenthesis into the VIEW definition to make sure the pg parser still can deal...
Peter Rabbitson [Sun, 7 Jun 2009 08:18:16 +0000]
Add parenthesis into the VIEW definition to make sure the pg parser still can deal with them

14 years agoVIEW support for Pg parser, also some cleanups
Peter Rabbitson [Sun, 7 Jun 2009 08:11:01 +0000]
VIEW support for Pg parser, also some cleanups

14 years agoGraphviz does not like empty hahsrefs - prune those
Peter Rabbitson [Wed, 3 Jun 2009 22:05:05 +0000]
Graphviz does not like empty hahsrefs - prune those

14 years agoMerge forgotten rewrite of the GraphViz producer - keep all the logic intact but...
Peter Rabbitson [Wed, 3 Jun 2009 10:44:44 +0000]
Merge forgotten rewrite of the GraphViz producer - keep all the logic intact but do not do any parameter sanity checking - just pass things straight to GraphViz.pm

14 years agoadded parser support for MySQL default values with a single quote
John Goulah [Tue, 2 Jun 2009 21:04:00 +0000]
added parser support for MySQL default values with a single quote

14 years agoSwitch to Module::Install
Peter Rabbitson [Mon, 1 Jun 2009 11:53:44 +0000]
Switch to Module::Install
Create a 'share' directory to be used with Module::Install::ShareDir / File::ShareDir
Move DiaUml tt2 files to share, adjust DiaUml producer (no tests but I think I got it right)
Move grammar files to sharedir too (only one for now, but this is where we will eventually keep all of them)

14 years agoReorder authors and consolidate them in one point (AUTHORS). Add link from main POD
Peter Rabbitson [Sun, 31 May 2009 07:35:38 +0000]
Reorder authors and consolidate them in one point (AUTHORS). Add link from main POD

14 years agoAdd POD checker and fix a couple of POD errors
Peter Rabbitson [Sun, 31 May 2009 07:21:10 +0000]
Add POD checker and fix a couple of POD errors

14 years agoMySQL producer skips length attribute for columns which do not support that attribute...
Johannes Plunien [Wed, 27 May 2009 22:24:13 +0000]
MySQL producer skips length attribute for columns which do not support that attribute. Currently following column types are added to that list: date time timestamp datetime year