'Class::Data::Inheritable' => 0.02,
'Class::MakeMethods' => 0,
'Digest::SHA1' => 2.00,
+ 'Carp::Clan', => 0,
'IO::Dir' => 0,
'Parse::RecDescent' => 1.95,
'Pod::Usage' => 0,
$DEBUG = 0 unless defined $DEBUG;
use Data::Dumper;
+use Carp::Clan qw/^SQL::Translator/;
use Exporter;
use base qw(Exporter);
@EXPORT_OK = qw(parse);
);
foreach (@nodes) {
my %data = get_tagfields($xp, $_, "sqlf:", qw/
- name perform_action_when database_event fields on_table action order
+ name perform_action_when database_event database_events fields on_table action order
extra
/);
+
+ # back compat
+ if (my $evt = $data{database_event} and $translator->{show_warnings}) {
+ carp 'The database_event tag is deprecated - please use database_events (which can take one or more comma separated event names)';
+ $data{database_events} = join (', ',
+ $data{database_events} || (),
+ $evt,
+ );
+ }
+
+ # split into arrayref
+ if (my $evts = $data{database_events}) {
+ $data{database_events} = [split (/\s*,\s*/, $evts) ];
+ }
+
$schema->add_trigger( %data ) or die $schema->error;
}
my ($trigger, $options) = @_;
my $add_drop = $options->{add_drop_trigger};
- my $name = $trigger->name;
- my @create;
-
- push @create, "DROP TRIGGER IF EXISTS $name" if $add_drop;
+ my @statements;
+ my $trigger_name = $trigger->name;
my $events = $trigger->database_events;
- die "Can't handle multiple events in triggers" if @{ $events || [] } > 1;
+ for my $evt ( @$events ) {
- my $action = "";
+ my $trig_name = $trigger_name;
+ if (@$events > 1) {
+ $trig_name .= "_$evt";
- $DB::single = 1;
- unless (ref $trigger->action) {
- $action .= "BEGIN " . $trigger->action . " END";
- } else {
- $action = $trigger->action->{for_each} . " "
- if $trigger->action->{for_each};
+ warn "Multiple database events supplied for trigger '$trigger_name', ",
+ "creating trigger '$trig_name' for the '$evt' event.\n" if $WARN;
+ }
- $action = $trigger->action->{when} . " "
- if $trigger->action->{when};
+ push @statements, "DROP TRIGGER IF EXISTS $trig_name" if $add_drop;
- my $steps = $trigger->action->{steps} || [];
- $action .= "BEGIN ";
- for (@$steps) {
- $action .= $_ . "; "
+ $DB::single = 1;
+ my $action = "";
+ if (not ref $trigger->action) {
+ $action .= "BEGIN " . $trigger->action . " END";
}
- $action .= "END";
- }
+ else {
+ $action = $trigger->action->{for_each} . " "
+ if $trigger->action->{for_each};
+
+ $action = $trigger->action->{when} . " "
+ if $trigger->action->{when};
- push @create, "CREATE TRIGGER $name " .
- $trigger->perform_action_when . " " .
- $events->[0] .
- " on " . $trigger->on_table . " " .
- $action;
+ my $steps = $trigger->action->{steps} || [];
+
+ $action .= "BEGIN ";
+ $action .= $_ . "; " for (@$steps);
+ $action .= "END";
+ }
+
+ push @statements, sprintf (
+ 'CREATE TRIGGER %s %s %s on %s %s',
+ $trig_name,
+ $trigger->perform_action_when,
+ $evt,
+ $trigger->on_table,
+ $action
+ );
+ }
- return @create;
-
+ return @statements;
}
sub alter_table { } # Noop
#=============================================================================
BEGIN {
- maybe_plan(204, 'SQL::Translator::Parser::XML::SQLFairy');
+ maybe_plan(212, 'SQL::Translator::Parser::XML::SQLFairy');
}
my $testschema = "$Bin/data/xml/schema.xml";
add_drop_table => 1,
);
die "Can't find test schema $testschema" unless -e $testschema;
-my $sql = $sqlt->translate(
+
+my $sql;
+{
+ my @w;
+ local $SIG{__WARN__} = sub { push @w, $_[0] if $_[0] =~ /The database_event tag is deprecated - please use database_events/ };
+
+ $sql = $sqlt->translate(
from => 'XML-SQLFairy',
to => 'MySQL',
filename => $testschema,
-) or die $sqlt->error;
-print $sql if DEBUG;
+ ) or die $sqlt->error;
+ print $sql if DEBUG;
+
+ ok (@w, 'database_event deprecation warning issued');
+}
# Test the schema objs generted from the XML
#
bar => "baz",
},
},
+ {
+ name => 'bar_trigger',
+ perform_action_when => 'before',
+ database_events => 'insert,update',
+ on_table => 'Basic',
+ action => 'update modified2=timestamp();',
+ extra => {
+ hello => "aliens",
+ },
+ },
],
procedures => [
{
my $obj;
$obj = SQL::Translator->new(
- show_warnings => 1,
+ show_warnings => 0,
from => "XML-SQLFairy",
filename => "$Bin/data/xml/schema.xml",
to => "TTSchema",
[%- END %]};
my $obj;
$obj = SQL::Translator->new(
- show_warnings => 1,
+ show_warnings => 0,
from => "XML-SQLFairy",
filename => "$Bin/data/xml/schema.xml",
to => "TTSchema",
my $obj;
$obj = SQL::Translator->new(
debug => 0,
- show_warnings => 1,
+ show_warnings => 0,
add_drop_table => 1,
from => "XML-SQLFairy",
filename => "$Bin/data/xml/schema.xml",
my $sqlt;
$sqlt = SQL::Translator->new(
no_comments => 1,
- show_warnings => 1,
+ show_warnings => 0,
add_drop_table => 1,
);
SELECT email FROM Basic WHERE email IS NOT NULL;
CREATE TRIGGER foo_trigger after insert ON Basic REFERENCING OLD AS oldrow NEW AS newrow FOR EACH ROW MODE DB2SQL update modified=timestamp();
+
+CREATE TRIGGER bar_trigger before insert, update ON Basic REFERENCING OLD AS oldrow NEW AS newrow FOR EACH ROW MODE DB2SQL update modified2=timestamp();
SQL
my $sqlt;
$sqlt = SQL::Translator->new(
no_comments => 1,
- show_warnings => 1,
+ show_warnings => 0,
add_drop_table => 1,
);
'CREATE VIEW email_list AS
SELECT email FROM Basic WHERE email IS NOT NULL;',
-'CREATE TRIGGER foo_trigger after insert ON Basic REFERENCING OLD AS oldrow NEW AS newrow FOR EACH ROW MODE DB2SQL update modified=timestamp();'
+'CREATE TRIGGER foo_trigger after insert ON Basic REFERENCING OLD AS oldrow NEW AS newrow FOR EACH ROW MODE DB2SQL update modified=timestamp();',
+
+'CREATE TRIGGER bar_trigger before insert, update ON Basic REFERENCING OLD AS oldrow NEW AS newrow FOR EACH ROW MODE DB2SQL update modified2=timestamp();',
];
is_deeply(\@sql, $want, 'Got correct DB2 statements in list context');
my $sqlt;
$sqlt = SQL::Translator->new(
no_comments => 1,
- show_warnings => 1,
+ show_warnings => 0,
add_drop_table => 1,
);
CREATE TRIGGER foo_trigger after insert on Basic BEGIN update modified=timestamp(); END;
+DROP TRIGGER IF EXISTS bar_trigger_insert;
+
+CREATE TRIGGER bar_trigger_insert before insert on Basic BEGIN update modified2=timestamp(); END;
+
+DROP TRIGGER IF EXISTS bar_trigger_update;
+
+CREATE TRIGGER bar_trigger_update before update on Basic BEGIN update modified2=timestamp(); END;
+
COMMIT;
SQL
SELECT email FROM Basic WHERE email IS NOT NULL',
'DROP TRIGGER IF EXISTS foo_trigger',
'CREATE TRIGGER foo_trigger after insert on Basic BEGIN update modified=timestamp(); END',
- 'COMMIT'
+ 'DROP TRIGGER IF EXISTS bar_trigger_insert',
+ 'CREATE TRIGGER bar_trigger_insert before insert on Basic BEGIN update modified2=timestamp(); END',
+ 'DROP TRIGGER IF EXISTS bar_trigger_update',
+ 'CREATE TRIGGER bar_trigger_update before update on Basic BEGIN update modified2=timestamp(); END',
+ 'COMMIT',
+
], 'SQLite translate in list context matches');
</views>
<triggers>
- <trigger name="foo_trigger" database_events="insert" on_table="Basic"
+ <trigger name="foo_trigger" database_event="insert" on_table="Basic"
perform_action_when="after" order="1">
<action>update modified=timestamp();</action>
<extra foo="bar" hello="world" bar="baz" />
</trigger>
+ <trigger name="bar_trigger" database_events="insert , update" on_table="Basic"
+ perform_action_when="before" order="1">
+ <action>update modified2=timestamp();</action>
+ <extra hello="aliens" />
+ </trigger>
</triggers>
<procedures>
projects / dbsrgits/SQL-Translator.git / commitdiff