Add trigger support to PostgreSQL producer and parser (including trigger scope)
[dbsrgits/SQL-Translator.git] / Changes
CommitLineData
c96cd4a8 1* Support for triggers in PostgreSQL producer and parser
a23f9a9d 2* Correct Data Type in SQLT::Parser::DBI::PostgreSQL (patch from Andrew Pam)
c601ca5d 3* Fix index issue in SQLT::Parser::DBI::PostgreSQL
fd52d7dd 4* Add column and table comments in SQLT::Parser::DBI::PostgreSQL(patch from Andrew Pam)
c50d1a0a 5* Fixed alter_drop_constraint for foreign keys and applying multiple changes
6 via alter_field to a column in Postgres Producer
681dc480 7* added a working mechanism for naming foreign keys in the PostgreSQL producer
56785c01 8* Fix possible name duplication in SQLlite producer
0d3badf1 9* Oracle does not accept ON DELETE/UPDATE RESTRICT (though it is the actual default)
10 fix by not adding the ON DELETE/UPDATE clause at all
a23f9a9d 11
685e67e2 12# ----------------------------------------------------------
13# 0.11010 2011-10-05
14# ----------------------------------------------------------
0e758018 15
16* Add "if exists" to drop view statements in Pg.
17
3e814930 18# ----------------------------------------------------------
aa4dc4dc 19# 0.11009 2011-09-02
0e758018 20# ----------------------------------------------------------
aa4dc4dc 21
22* Fix MySQL producer to properly quote all table names on output (patch from geistteufel)
23
24# ----------------------------------------------------------
3e814930 25# 0.11008 2011-05-04
26# ----------------------------------------------------------
5f31ed66 27
0dbd2362 28* Correctly create and parse FK constraints in SQLite
140a1dad 29* Correct postgis geography type insertion and linebreak fix for multiple geometry/geography columns
5f31ed66 30* made PostgreSQL producer consistent with other producers in terms of
31 quoting and allowing functions in constraints and indices
4426fb84 32* Add distinction of autoinc and regular primary keys to the GraphViz producer
f8a4f3b4 33* Fix odd invocation of Test::More::pass() in t/36-filters.t (RT#64728)
0a6e5a56 34* Quote everything in SQL Server
d02c3cd2 35* Turn off constraints before dropping tables in SQL Server
66444b41 36* Make true unique constraints if needed in SQL Server
3e814930 37* Fixed Producer::PostgresSQL to output array type after type size,
aacb3187 38 i.e. varchar(64)[] rather than varchar[](64)
140a1dad 39
7edba2c1 40# ----------------------------------------------------------
41# 0.11007 2010-11-30
42# ----------------------------------------------------------
e83ad71c 43
cb490ce5 44* Fix POD typo in SQL/Translator/Schema/Trigger.pm
dd184b2c 45* Add explicit Scalar::Util to the deplist for really old perls
e83ad71c 46* Add support for PostGIS Geometry and Geography data types in the Pg producer
56b9e6a5 47* Some minor fixes to squash warnings on new perls
79f55d7e 48* Support a custom_type_name hint when creating enum types in PostgreSQL
1a45aefd 49* Fix sqlt options/pod mismatch (RT#58318)
104507a6 50* Oracle Producer multicolumn constraint support
3ebe2ce5 51* Add support for triggers in the MySQL producer
52* Fix unstable order of View's in MySQL parser
dd184b2c 53
e40faf47 54# ----------------------------------------------------------
55# 0.11006 2010-06-03
56# ----------------------------------------------------------
05e77abf 57* Fix Producer::Oracle varchar2 without size def (ORA-00906: missing right
58 parenthesis)
59* Fix Producer::Oracle translate float and double to float instead of number
3b9249fb 60* Fix Producer::Oracle generation of too long unique constraint names
05e77abf 61* Fix Producer::SQLite when generating VIEWs with add_drop_table => 1
20476859 62* Fix Producer::MySQL not quoting index names when requested (RT#56173)
1c8ec56e 63* Fix Producer::MySQL wrapping extra ()s around VIEW SELECT-ors (RT#56419)
644145cd 64* Fix Field::default_value to behave like a real accessor (allow undef as
65 an unsetting argument)
06baeb21 66* Fix Mysql/Pg/SQLite/MSSQL producers to properly *not* quote numeric default
67 values (RT#57059)
3b9249fb 68* Producer::Oracle tests now use Test::Differences
6af0ff59 69* Prettify output of SQLite producer (less bogus newlines)
05e77abf 70* Augment SQLite and Pg producers to accept a perl-formatted (%d.%03d%03d)
71 and regular no-leading-zero (X.X.X) *_version producer args
7b8cffe3 72
73# ----------------------------------------------------------
e0ae2f7d 74# 0.11005 2010-02-24
75# ----------------------------------------------------------
1f5b2625 76* Fix Parser::DBI::Oracle reading too many tables (RT#49413)
77* Fix Parser::MySQL tripping up on PRIMARY KEY ... USING (currently value is ignored) (RT#50468)
78* Fix runaway debug trace (RT#52276)
79* Fix Parser::PostgreSQL choking on commit; statements in DDL (#RT52277)
e0ae2f7d 80* Producer::Oracle now respects quote_field|table_names, and
fb2ccad1 81 no longer does name munging of reserved table names
06debaa8 82* Producer::Oracle now correctly outputs databse-unique index names
1f5b2625 83
84# ----------------------------------------------------------
85# 0.11004 2010-02-14
86# ----------------------------------------------------------
f4428c33 87* Fix PG producer numeric precision regression (RT#49301)
88* Add DB2 producer numeric/decimal precision output
64ac5763 89* Fix Oracle producer creating numeric precision statements that the test case expects (no whitespace)
90* Add Oracle producer creating drop view statements like PG producer does
1f5b2625 91* Fix SQL::Translator::Diff to use producer_args instead of producer_options
f4428c33 92
6142e635 93# ----------------------------------------------------------
94# 0.11003 2009-09-28
95# ----------------------------------------------------------
343e2a8c 96* Pg parser fixes to deal properly with MATCH <type>
b5a782a0 97* Pg parser fixes to parse timestamp attributes correctly
3e1ed76b 98* Fix broken default detection in script/sqlt (RT#27438)
99* Fix dependency issues with LibXML and TT
343e2a8c 100
1d195bd6 101# ----------------------------------------------------------
b6790235 102# 0.11002 2009-08-30
475a7db7 103# ----------------------------------------------------------
104* Depend on fixed Parse::RecDescent
105* Added skip-tables and skip-tables-like options to Diagram
106
107# ----------------------------------------------------------
1d195bd6 108# 0.11001 2009-08-18
109# ----------------------------------------------------------
110* Removed last use of Readonly
111* Adjusted YAML dependency
11ad2df9 112
113# ----------------------------------------------------------
114# 0.11000 2009-08-18
115# ----------------------------------------------------------
116* Re-add version numbers to files, else cpan's "upgrade" gets very confused
117* Replaced code using Readonly, since most of the rest uses constant, and thats already a dep
118* Moved YAML and XML::LibXML back to recommends, the tests for both now skip if not installed
119* Bumped to 0.11000 to supercede 0.10 which has incorrect numbering scheme
120
347abf9d 121# ----------------------------------------------------------
ba506e52 122# 0.10 2009-08-13
8d693a85 123# ----------------------------------------------------------
ba506e52 124* Resolved the following RT bugs (thanks to everyone for reporting!):
9d69b5b7 12525791 does not recognize PostgreSQL ON_ERROR_STOP
12629265 sqlt-diagram: --natural-join needs Graph::Directed
12737814 SQLite translator failing to parse schema
ba506e52 12842548 Producer::PostgreSQL incorrectly inserts the size in
129 'time(stamp)? with(out) time zone' fields
9d69b5b7 13043173 SQL::Translator::Parser without versionnumber - will install
131 old 0.09002
13246805 (No subject)
13347026 META.yml is not packaged due to MANIFEST.SKIP (easyfix)
13432130 Move from XML::XPath to XML::LibXML::XPathContext
13522261 MySQL parse
13613915 missing optional prerequisite cause make test to fail
1378847 Diagram.pm: BINMODE missing in printing of graphic file.
13821065 GraphViz producer fails on tables named 'node'
13935448 Producer::PostgreSQL types without size
14022026 sqlt-diagram uses -f arg twice
14147897 [PATCH] Fix uninitialized value within @_ in (uc|lc)
14247668 Mysql Parser doesn't recognize key types
14346448 sqlt-graph errors out on MySQL DDL with btree keys
14447176 Add Foreign Key support to Parser::DBI::PostgreSQL.pm
14548025 MySQL Producer: Case inconsistency between elements in
146 @no_length_attr and $data_type
14748569 sqlt-diagram fails to load SQLite schema
14848596 SQL::Translator::Diff::schema_diff should produce a list in
149 list context
15044907 SQL::Translator::Producer::PostgreSQL produce() in list context
ba506e52 151 should return a list of statements
c1e2579f 152
b245a5f3 153# ----------------------------------------------------------
154# 0.09007 2009-06-25
155# ----------------------------------------------------------
9fa2a755 156* Fixed Pg parser - caching the compiled P::RD schema is a *very*
157 bad idea
f9a5ee79 158* Fix MSSQL handling of ON UPDATE/DELETE RESTRICT
159* Delay MSSQL FK constraint deployment until after all CREATE TABLE
160 statements
161* Coerce other engine's bytea/blob/clob datatypes to VarBinary
9fa2a755 162
c1e2579f 163# ----------------------------------------------------------
164# 0.09006 2009-06-10
165# ----------------------------------------------------------
01bdc5ca 166* Multiple test and dependency adhustments to make smokers happy
167* Fix YAML producer wrt extra attribute
ad258776 168* Added support for "time(stamp) (p) with time zone" for Pg producer (mo)
169
bd3c4e06 170# ----------------------------------------------------------
171# 0.09005 2009-06-08
172# ----------------------------------------------------------
8b075c9f 173* Add parser support for MySQL default values with a single quote
8d693a85 174* Properly quote absolute table names in the MySQL producer
ba506e52 175* Added CREATE VIEW subrules for mysql parser (wreis)
176* Many fixes to code and tests for trigger's "database_events"
938464ee 177* Added semi-colon for (DROP|CREATE) TYPE statements in the Pg producer (wreis)
90726ffd 178* ALTER TABLE/ALTER COLUMN/DROP DEFAULT support in Pg producer (mo)
19f36a90 179* XML parser support for multi-event triggers
180* SQLite producer support for multi-event triggers
181* XML parser switched from XML::XPath to XML::LibXML
182* Pg producer ALTER TABLE/COLUMN and DROP DEFAULT support
de176728 183* MySQL producer skips length attribute for columns which do not support that
184 attribute. Currently following column types are added to that list:
185 date time timestamp datetime year
0a2d7cf1 186* Switch to Module::Install (mandates minimum perl 5.005)
bd3c4e06 187* Major cleanup of GraphViz proucer
0a2d7cf1 188* Massive amount of fixes to SQLite/Pg/Mysql/MSSQL parsers/producers
189 Fix most of the problems uncovered by the roundtrip test framework
190 Some highlights:
191 - Rewind exhausted globs before attempting a read
192 - Do not add xml comment header if no_comments is set
193 - table/field counts are held per schema object, not globally
194 - no more variable table and column names in SQLite and MSSQL
0a2d7cf1 195 - VIEW support for Pg parser, also some cleanups
196 - The way we generate Pg create view statements was not standards compliant
197 (per RhodiumToad in #postgresql)
bd3c4e06 198 - Disable MSSQL view/procedure production - they never worked in the first place
0a2d7cf1 199 - SQLite/MSSQL improvements:
200 - Support parsing of all DROP clauses
201 - Support parsing of field-level comments
202 - When producing do not append table names to constraint/index names
8d693a85 203
204# ----------------------------------------------------------
b419bb2c 205# 0.09004 2009-02-13
347abf9d 206# ----------------------------------------------------------
3e98f7d9 207* Add support for temporary tables in Pg (nachos)
d0fcb05d 208* Create Trigger support for SQLite
347abf9d 209* GraphViz producer improvements
d0fcb05d 210
ec59a597 211# ----------------------------------------------------------
b419bb2c 212# 0.09003 2009-02-07
213# ----------------------------------------------------------
214 <BORKED RELEASE DELETED OFF CPAN>
215
216# ----------------------------------------------------------
5094211e 217# 0.09002 2008-12-05
ec59a597 218# ----------------------------------------------------------
0a6e5a56 219* parsing MySQL CURRENT_TIMESTAMP as scalar ref so it can be produced without
3406fd5b 220 quotes (jgoulah)
f7f81963 221* Add ignore_opts parser arg (to ignore table options) in Parser::MySQL (jgoulah)
cc48d354 222* Skip tests for buggy Spreadsheet::ParseExcel versions (rbo)
7d89539d 223* Add support for skip tables parser arg in Parser::DBI::MySQL (jgoulah)
0a6e5a56 224* Changed behaviour of ::Producer::Oracle when returning an array of statements
3406fd5b 225 to make it compatible to DBI->do()
64f82436 226* Fixed a few bugs in ::Producer::Oracle
9a96648f 227* Applied patch from jgoulah to support mysql's MERGE option
8742e408 228* Applied patch from rbo to add support of multiple database events on a trigger
0a6e5a56 229* Applied patch from lukes to allow drop if exists in sqlite producer, with
3406fd5b 230 version >= 3.3
0a6e5a56 231* Applied patch from rjbs with minor changes, now we support scalar refs in
3406fd5b 232 default values!
24d9fe69 233* Fixed SQLite producer to end index statements in newlines, in scalar context
234* Decreed that all list context statements shall not end in ; or ;\n
235* Fixed SQLite, Diff and MySQL producers to agree with Decree.
296c2701 236* Added support for CREATE VIEW + tests in the Pg producer (wreis)
ec59a597 237* Added support for CREATE VIEW + tests in the sqlite producer (groditi)
0a6e5a56 238* Added proper argument parsing and documentation to MySQL Parser and
3406fd5b 239 Producer (ribasushi)
0a6e5a56 240* Using DROP VIEW instead of OR REPLACE clause in the Pg producer, as replace
3406fd5b 241 only allows replacement with identical set of columns (wreis)
0a6e5a56 242* Added support for DROP VIEW and fixed CREATE VIEW statement in the sqlite
3406fd5b 243 producer (wreis)
0a6e5a56 244* Removed source_db and target_db accessors from Diff (throwback to old version,
3406fd5b 245 only output_db is used)
e30b71b8 246
247
3406fd5b 248* Support for longer varchar fields in MySQL
e802b210 249
c6e5ac68 250# ----------------------------------------------------------
251# 0.09001 2008-08-19
252# ----------------------------------------------------------
d28afa66 253* Added support for CREATE VIEW + tests in the mysql producer (groditi)
7c1aae02 254* Added support for SET fields in the mysql producer + test (groditi)
0a6e5a56 255* Added support for proper booleans in the mysql producer, when a mysql version
3406fd5b 256 of at least 4.x is supplied
0a6e5a56 257* Added support for proper enums under pg (as of 8.3), with pg version check,
3406fd5b 258 and deferrable constraints
0a6e5a56 259* Added support to truncate long constraint and index names in the mysql
260 producer, because of a change to DBIx::Class to produce such long names in
3406fd5b 261 some cases.
e802b210 262
13243123 263# ----------------------------------------------------------
c6e5ac68 264# 0.09000 2008-02-25
13243123 265# ----------------------------------------------------------
da5a1bae 266
296c2701 267* Fix Pg produces idea of which field types need a size param (wreis)
a7f49dfb 268* Add support for COLLATE table option to MySQL parser
bb4c66d1 269* Allow DEFAULT CHARACTER SET without '=' (as produced by mysqldump)
a7f49dfb 270
da5a1bae 271# -----------------------------------------------------------
11bebd6e 272# 0.0899_02 2008-01-29
273# ----------------------------------------------------------
274
275* Major refactoring of SQL::Translator::Diff again:
0a6e5a56 276* Diff is no longer one huge monolithic function.
277* Added more tests for diff
278* When producing diffs for MySQL you will (by default) get single alter
3406fd5b 279 statements per table
0a6e5a56 280* SQLite can also do remove columns (by creating a temp table as shown in
3406fd5b 281 http://sqlite.org/faq.html#q11
282* Columns can be renamed if the new schema is from a form that can have metadata
0a6e5a56 283 (which is pretty much anything but an SQL file.) It does this by looking at
284 renamed_from in the $field->extra
11bebd6e 285* Updated Oracle and Postgres producers
286* More tests!
287
288# -----------------------------------------------------------
da5a1bae 289# 0.0899_01 2007-10-21
290# ----------------------------------------------------------
291
292* SQL::Translator::Diff now uses the ::Producer modules to create diffs
293 This *will* break back-compatibility
294 Use sqlt-diff-old for the previous one, and fix producers!
295
18a8d640 296# -----------------------------------------------------------
f51d8e46 297# 0.08001 2007-09-26
298# ----------------------------------------------------------
299
300* Patched to ignore all TT versions >= 2.15 until TT is fixed :(
301
302# -----------------------------------------------------------
303# 0.08 2006-12-07
304# -----------------------------------------------------------
305
0a6e5a56 306* Patched 18ttschema-producer.t and 33tt-table-producter.t to skip on TT 2.15,
3406fd5b 307 thanks Ash!
f51d8e46 308
309# -----------------------------------------------------------
af27376e 310# 0.08_04 2006-11-10
311# -----------------------------------------------------------
312
fb149f81 313* Patched MySQL producer to name constraints sanely, thanks Ash
af27376e 314* Added patch to Producer::DB2 to avoid dependency issues with foreign keys
315* Added patch to remove single quotes for numeric default values in Producer::DB2
316* Fixed Parser::SQLite to require a semicolon after a create trigger statement
ca1b7c76 317* Added patch from avinash to add CASCADE to pg table drops
af27376e 318
319# -----------------------------------------------------------
f39e9c12 320# 0.08_03
321# -----------------------------------------------------------
322
323* Added patch to use default values for Pg timestamp fields
324
325# -----------------------------------------------------------
326# 0.08_02 2006-11-03
327# -----------------------------------------------------------
328
0a6e5a56 329* Added patch from Ash to separate DROP statements in mysql producer in
3406fd5b 330 list-context
f39e9c12 331* Fixed up SQLites usage of no-comments
332
333# -----------------------------------------------------------
18a8d640 334# 0.08_01 2006-07-23
335# -----------------------------------------------------------
6cedfc23 336
18a8d640 337* Made Trigger check that a give table exists in on_table - castaway
3406fd5b 338* Split some producers (DB2, MySQL, SQLite, PostgreSQL) into sub methods (others
339 to follow) - castaway
340* Add alter_* methods to some Producers and docs to Producer.pm (for use by Diff
341 later) - castaway
18a8d640 342* Made changes to allow producers to return a list of statements - castaway
343* Split sqlt-diff into script and module - castaway
344* Added quote_table_names and quote_field_names patch (omega, zamolxes) - castaway
345* Added DB2 Producer - castaway
6cedfc23 346* Added mysql_character_set for 4.1+ -mda
8dc6a4a3 347* New filters, Names and Globals. -mda
35a1938f 348* Added the initial work on a template based Dia UML producer. -mda
6cedfc23 349
f5d44dd7 350# -----------------------------------------------------------
18a8d640 351# 0.07 2005-06-10
f5d44dd7 352# -----------------------------------------------------------
1ded8513 353* YAML parser supports extra attributes on tables.
354
7fc38348 355* All schema objects now support the extra attribute, so can
356 have arbitary name/value data attached to them.
357
0a6e5a56 358* Refactoring: Added SQL::Translator::Schema::Object - base
7fc38348 359 class for all Schema objects.
360
13aec984 361* Changes to MySQL Parser (Dave Howorth)
362 - ignore INSERT statements
363 - permit ALTER TABLE ADD FOREIGN KEY
364 - allow trailing comma on last field in CREATE statements
365 - collect the database name
366
f9725390 367* TTSchema Producer
368 - Can pass extra variables using tt_vars producer arg.
369 - Can pass extra config using tt_conf producer arg.
370 - Variables and config can be passed on the command line
371 with --tt-var and --tt-conf options to sqlt.
372
185c34d5 373* Added schema filters.
f9725390 374
5a0c7b43 375* MySQL Producer
376 - Added 'mysql_table_type' extra attribute on tables.
377 - Works out InnoDB tables from constraints.
1ded8513 378 - mysql_charset and mysql_collate extra attributes for tables and fiels.
5a0c7b43 379
380
c4bf7f53 381# -----------------------------------------------------------
382# 0.06 2004-05-13
383# -----------------------------------------------------------
384* Added SQL::Translator::Manual
385
386* Installation process now uses Module::Build
387
388* Added new "Dumper" producer
389
3e069fa1 390* Changed the native SQL Fairy XML format to a fixed mapping.
391 *NB:* You should convert your existing XML schema. See the
392 SQL::Translator::Parser::XML::SQLFairy docs.
393
394* Added producers: TT::Base and TT::Table.
395
eabd66e6 396# -----------------------------------------------------------
7c67b302 397# 0.05 2004-02-27
398# -----------------------------------------------------------
bc40219c 399* Added "COMMENT ON *" syntax to PostgreSQL parser
400
401* Some fixes to Oracle parser as reported by Gail Binkley
402
403* Added support in PostgreSQL parser for all "ALTER TABLE" statements
7c67b302 404
405* Now distributing sqlt-diff script as it's pretty usable
406
407* Added new options to sqlt-graph and GraphViz producer (Dave Cash)
408
409# -----------------------------------------------------------
d6b47dd5 410# 0.04 2003-11-07
eabd66e6 411# -----------------------------------------------------------
b9952639 412
0a6e5a56 413* Increased version of Constants module to 1.41 to avoid a problem
d6b47dd5 414 where 0.02 has 1.4 of that file and 0.03 had 1.06 which confused
415 CPAN
416
417* Hard-coded all the PREREQ_PM modules in Makefile.PL (rather than
418 setting them dynamically) so that automated tests would pass
419
420# -----------------------------------------------------------
421# 0.03 2003-11-06
422# -----------------------------------------------------------
423
0a6e5a56 424* Added parsers: XML::SQLFairy, Sybase, SQLite, DBI-MySQL,
d6b47dd5 425 DBI-PostgreSQL, DBI-SQLite, DBI-Sybase, Storable, YAML
426
427* Added producers: XML::SQLFairy, TTSchema, Storable, YAML
428
429* HTML producer now uses stylesheets to allow easy customization of colors
430
431* Many bug fixes to most every module
432
433* Added "sqlt-dumper" script to help create a script for dumping
434 a database a la "mysqldump"
435
0a6e5a56 436* Reversed the arrowheads on the graphical producers to show the
d6b47dd5 437 relationships in a more standard way
438
439* Changes all included script names to start with "sqlt"
440
441* Added capturing and printing most embedded table and field comments
b9952639 442
eabd66e6 443# -----------------------------------------------------------
444# 0.02 2003-06-17
445# -----------------------------------------------------------
b9952639 446
eabd66e6 447* Added parsers for Excel and Oracle
b9952639 448
eabd66e6 449* Removed Sybase parser because it didn't actually work
b9952639 450
eabd66e6 451* Added ClassDBI, Diagram, GraphViz, HTML, POD, SQLite, Sybase producers
b9952639 452
eabd66e6 453* Added Schema classes to represent schema as objects
b9952639 454
eabd66e6 455* Removed "Raw" producer in favor of the Schema classes
b9952639 456
eabd66e6 457* Removed "Validator" class as the Schema classes validate themselves
b9952639 458
0a6e5a56 459* Improved all existing parsers and producers, expanding them to
eabd66e6 460 handle foreign keys much better, produce better output, etc.
b9952639 461
0a6e5a56 462* Added sqlt-diagram.pl and sqlt-graphviz.pl as CLI frontends to the
eabd66e6 463 graphical producers
b9952639 464
eabd66e6 465* Added sql_translator.cgi as a web-form frontend to graphical producers
150797b1 466
eabd66e6 467* Expanded test suite
d3e95970 468
469# -----------------------------------------------------------
d6b47dd5 470# 0.01 2003-02-27
f6aed479 471# -----------------------------------------------------------
472
0a6e5a56 473* Added parsers: XML::SQLFairy, Sybase, SQLite, DBI-MySQL,
7c67b302 474 DBI-PostgreSQL, DBI-SQLite, DBI-Sybase, Storable, YAML
475
476* Added producers: XML::SQLFairy, TTSchema, Storable, YAML
477
478* HTML producer now uses stylesheets to allow easy customization of colors
479
480* Many bug fixes to most every module
481
482* Added "sqlt-dumper" script to help create a script for dumping
483 a database a la "mysqldump"
484
0a6e5a56 485* Reversed the arrowheads on the graphical producers to show the
7c67b302 486 relationships in a more standard way
487
488* Changes all included script names to start with "sqlt"
489
490* Added capturing and printing most embedded table and field comments