From: Peter Rabbitson <ribasushi@cpan.org>
Date: Sun, 8 Mar 2009 22:43:57 +0000 (+0000)
Subject: Clarify insanedness of test
X-Git-Tag: v1.70~221
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits%2FSQL-Abstract.git;a=commitdiff_plain;h=397986c42758b382e96b4dde9736ab578a761d10

Clarify insanedness of test
---

diff --git a/t/03values.t b/t/03values.t
index f88debb..27f3013 100644
--- a/t/03values.t
+++ b/t/03values.t
@@ -85,17 +85,23 @@ for my $record (@data) {
 }
 
 # test values() with literal sql
+#
+# NOTE:
+# The example is deliberately complicated by the addition of a literal ? in xfunc
+# This is an intentional test making sure literal ? remains untouched.
+# It is rather impractical in the field, as the user will have to insert
+# a bindvalue for the literal position(s) in the correct offset of \@bind
 {
   my $sql = SQL::Abstract->new;
 
-  my $data = { event => 'rapture', time => \ 'now()', func => \ 'somefunc(?)', stuff => 'fluff', };
+  my $data = { event => 'rapture', time => \ 'now()', xfunc => \ 'somefunc(?)', stuff => 'fluff', };
 
   my ($stmt, @bind) = $sql->insert ('table', $data);
 
   is_same_sql_bind (
     $stmt,
     \@bind,
-    'INSERT INTO table ( event, func, stuff, time) VALUES ( ?, somefunc (?), ?, now() )',
+    'INSERT INTO table ( event, stuff, time, xfunc) VALUES ( ?, ?, now(), somefunc (?) )',
     [qw/rapture fluff/],  # event < stuff
   );
 
@@ -103,5 +109,5 @@ for my $record (@data) {
     [$sql->values ($data)],
     [\@bind],
     'values() output matches that of initial bind'
-  );
+  ) || diag "Corresponding SQL statement: $stmt";
 }