-#!/usr/bin/perl
-
use strict;
use warnings;
use Test::More;
+use Test::Warn;
use Test::Exception;
-use SQL::Abstract::Test import => ['is_same_sql_bind'];
+use SQL::Abstract::Test import => [qw(is_same_sql_bind diag_where)];
-use Data::Dumper;
use SQL::Abstract;
my @in_between_tests = (
bind => [],
test => '-between with literal sql with a literal (\"\'this\' AND \'that\'")',
},
+
+ # generate a set of invalid -between tests
+ ( map { {
+ where => { x => { -between => $_ } },
+ test => 'invalid -between args',
+ throws => qr|Operator 'BETWEEN' requires either an arrayref with two defined values or expressions, or a single literal scalarref/arrayref-ref|,
+ } } (
+ [ 1, 2, 3 ],
+ [ 1, undef, 3 ],
+ [ undef, 2, 3 ],
+ [ 1, 2, undef ],
+ [ 1, undef ],
+ [ undef, 2 ],
+ [ undef, undef ],
+ [ 1 ],
+ [ undef ],
+ [],
+ 1,
+ undef,
+ )),
{
where => {
start0 => { -between => [ 1, { -upper => 2 } ] },
],
test => '-between POD test',
},
+ {
+ where => { 'test1.a' => { 'In', ['boom', 'bang'] } },
+ stmt => ' WHERE ( test1.a IN ( ?, ? ) )',
+ bind => ['boom', 'bang'],
+ test => 'In (no dash, initial cap) with qualified column',
+ },
+ {
+ where => { a => { 'between', ['boom', 'bang'] } },
+ stmt => ' WHERE ( a BETWEEN ? AND ? )',
+ bind => ['boom', 'bang'],
+ test => 'between (no dash) with two placeholders',
+ },
{
parenthesis_significant => 1,
bind => [],
test => '-in with a literal scalarref',
},
+
+ # note that outer parens are opened even though literal was requested below
{
parenthesis_significant => 1,
where => { x => { -in => \['( ( ?,?,lower(y) ) )', 1, 2] } },
- stmt => "WHERE ( x IN ( ?,?,lower(y) ) )", # note that outer parens are opened even though literal was requested (RIBASUSHI)
+ stmt => "WHERE ( x IN ( ?,?,lower(y) ) )",
bind => [1, 2],
test => '-in with a literal arrayrefref',
},
where => {
status => { -in => \"(SELECT status_codes\nFROM states)" },
},
- # failed to open outer parens on a multi-line query in 1.61 (semifor)
stmt => " WHERE ( status IN ( SELECT status_codes FROM states )) ",
bind => [],
test => '-in multi-line subquery test',
bind => [2000],
test => '-in POD test',
},
+
{
where => { x => { -in => [ \['LOWER(?)', 'A' ], \'LOWER(b)', { -lower => 'c' } ] } },
stmt => " WHERE ( x IN ( LOWER(?), LOWER(b), LOWER ? ) )",
test => '-in with an array of function array refs with args',
},
{
+ throws => qr/
+ \QSQL::Abstract before v1.75 used to generate incorrect SQL \E
+ \Qwhen the -IN operator was given an undef-containing list: \E
+ \Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
+ \Qversion of SQL::Abstract will emit the logically correct SQL \E
+ \Qinstead of raising this exception)\E
+ /x,
where => { x => { -in => [ 1, undef ] } },
- stmt => " WHERE ( x IN ( ?, NULL ) )",
+ stmt => " WHERE ( x IN ( ? ) OR x IS NULL )",
bind => [ 1 ],
- test => '-in with undef as an element',
+ test => '-in with undef as an element',
},
{
+ throws => qr/
+ \QSQL::Abstract before v1.75 used to generate incorrect SQL \E
+ \Qwhen the -IN operator was given an undef-containing list: \E
+ \Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
+ \Qversion of SQL::Abstract will emit the logically correct SQL \E
+ \Qinstead of raising this exception)\E
+ /x,
where => { x => { -in => [ 1, undef, 2, 3, undef ] } },
- stmt => " WHERE ( x IN ( ?, NULL, ?, ?, NULL ) )",
+ stmt => " WHERE ( x IN ( ?, ?, ? ) OR x IS NULL )",
bind => [ 1, 2, 3 ],
- test => '-in with undef as an element',
+ test => '-in with multiple undef elements',
+ },
+ {
+ where => { a => { -in => 42 }, b => { -not_in => 42 } },
+ stmt => ' WHERE a IN ( ? ) AND b NOT IN ( ? )',
+ bind => [ 42, 42 ],
+ test => '-in, -not_in with scalar',
+ },
+ {
+ where => { a => { -in => [] }, b => { -not_in => [] } },
+ stmt => ' WHERE ( 0=1 AND 1=1 )',
+ bind => [],
+ test => '-in, -not_in with empty arrays',
+ },
+ {
+ throws => qr/
+ \QSQL::Abstract before v1.75 used to generate incorrect SQL \E
+ \Qwhen the -IN operator was given an undef-containing list: \E
+ \Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
+ \Qversion of SQL::Abstract will emit the logically correct SQL \E
+ \Qinstead of raising this exception)\E
+ /x,
+ where => { a => { -in => [42, undef] }, b => { -not_in => [42, undef] } },
+ stmt => ' WHERE ( ( a IN ( ? ) OR a IS NULL ) AND b NOT IN ( ? ) AND b IS NOT NULL )',
+ bind => [ 42, 42 ],
+ test => '-in, -not_in with undef among elements',
+ },
+ {
+ throws => qr/
+ \QSQL::Abstract before v1.75 used to generate incorrect SQL \E
+ \Qwhen the -IN operator was given an undef-containing list: \E
+ \Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
+ \Qversion of SQL::Abstract will emit the logically correct SQL \E
+ \Qinstead of raising this exception)\E
+ /x,
+ where => { a => { -in => [undef] }, b => { -not_in => [undef] } },
+ stmt => ' WHERE ( a IS NULL AND b IS NOT NULL )',
+ bind => [],
+ test => '-in, -not_in with just undef element',
+ },
+ {
+ where => { a => { -in => undef } },
+ throws => qr/Argument passed to the 'IN' operator can not be undefined/,
+ test => '-in with undef argument',
},
);
-plan tests => @in_between_tests*4;
-
for my $case (@in_between_tests) {
TODO: {
local $TODO = $case->{todo} if $case->{todo};
local $SQL::Abstract::Test::parenthesis_significant = $case->{parenthesis_significant};
+ my $label = $case->{test} || 'in-between test';
- local $Data::Dumper::Terse = 1;
+ my $sql = SQL::Abstract->new ($case->{args} || {});
- lives_ok (sub {
+ if (my $e = $case->{throws}) {
+ throws_ok { $sql->where($case->{where}) } $e, "$label throws correctly";
+ }
+ else {
+ my ($stmt, @bind);
+ warnings_are {
+ ($stmt, @bind) = $sql->where($case->{where});
+ } [], "$label gives no warnings";
- my @w;
- local $SIG{__WARN__} = sub { push @w, @_ };
- my $sql = SQL::Abstract->new ($case->{args} || {});
- lives_ok (sub {
- my ($stmt, @bind) = $sql->where($case->{where});
- is_same_sql_bind(
- $stmt,
- \@bind,
- $case->{stmt},
- $case->{bind},
- )
- || diag "Search term:\n" . Dumper $case->{where};
- });
- is (@w, 0, $case->{test} || 'No warnings within in-between tests')
- || diag join "\n", 'Emitted warnings:', @w;
- }, "$case->{test} doesn't die");
+ is_same_sql_bind(
+ $stmt,
+ \@bind,
+ $case->{stmt},
+ $case->{bind},
+ "$label generates correct SQL and bind",
+ ) || diag_where ( $case->{where} );
+ }
}
}
+
+done_testing;
projects / dbsrgits/SQL-Abstract.git / blobdiff