use strict;
use warnings;
use Test::More;
+use Test::Warn;
use Test::Exception;
-use SQL::Abstract::Test import => [qw(is_same_sql_bind diag_where)];
+use SQL::Abstract::Test import => [qw(is_same_sql_bind diag_where dumper)];
use SQL::Abstract;
( map { {
where => { x => { -between => $_ } },
test => 'invalid -between args',
- exception => qr|Operator 'BETWEEN' requires either an arrayref with two defined values or expressions, or a single literal scalarref/arrayref-ref|,
+ throws => qr|Operator 'BETWEEN' requires either an arrayref with two defined values or expressions, or a single literal scalarref/arrayref-ref|,
} } (
[ 1, 2, 3 ],
[ 1, undef, 3 ],
],
test => '-between POD test',
},
+ {
+ where => { 'test1.a' => { 'In', ['boom', 'bang'] } },
+ stmt => ' WHERE ( test1.a IN ( ?, ? ) )',
+ bind => ['boom', 'bang'],
+ test => 'In (no dash, initial cap) with qualified column',
+ },
+ {
+ where => { a => { 'between', ['boom', 'bang'] } },
+ stmt => ' WHERE ( a BETWEEN ? AND ? )',
+ bind => ['boom', 'bang'],
+ test => 'between (no dash) with two placeholders',
+ },
{
- parenthesis_significant => 1,
where => { x => { -in => [ 1 .. 3] } },
- stmt => "WHERE ( x IN (?, ?, ?) )",
- bind => [ 1 .. 3],
+ stmt => "WHERE x IN (?, ?, ?)",
+ bind => [ 1 .. 3 ],
test => '-in with an array of scalars',
},
{
- parenthesis_significant => 1,
where => { x => { -in => [] } },
- stmt => "WHERE ( 0=1 )",
+ stmt => "WHERE 0=1",
bind => [],
test => '-in with an empty array',
},
{
- parenthesis_significant => 1,
where => { x => { -in => \'( 1,2,lower(y) )' } },
- stmt => "WHERE ( x IN ( 1,2,lower(y) ) )",
+ stmt => "WHERE x IN ( 1,2,lower(y) )",
bind => [],
test => '-in with a literal scalarref',
},
# note that outer parens are opened even though literal was requested below
{
- parenthesis_significant => 1,
where => { x => { -in => \['( ( ?,?,lower(y) ) )', 1, 2] } },
- stmt => "WHERE ( x IN ( ?,?,lower(y) ) )",
+ stmt => "WHERE x IN ( ?,?,lower(y) )",
bind => [1, 2],
test => '-in with a literal arrayrefref',
},
{
- parenthesis_significant => 1,
where => {
status => { -in => \"(SELECT status_codes\nFROM states)" },
},
- stmt => " WHERE ( status IN ( SELECT status_codes FROM states )) ",
+ stmt => " WHERE status IN ( SELECT status_codes FROM states )",
bind => [],
test => '-in multi-line subquery test',
},
+
+ # check that the outer paren opener is not too agressive
+ # note: this syntax *is not legal* on SQLite (maybe others)
+ # see end of https://rt.cpan.org/Ticket/Display.html?id=99503
+ {
+ where => { foo => { -in => \ '(SELECT 1) UNION (SELECT 2)' } },
+ stmt => 'WHERE foo IN ( (SELECT 1) UNION (SELECT 2) )',
+ bind => [],
+ test => '-in paren-opening works on balanced pairs only',
+ },
+
{
- parenthesis_significant => 1,
where => {
customer => { -in => \[
'SELECT cust_id FROM cust WHERE balance > ?',
status => { -in => \'SELECT status_codes FROM states' },
},
stmt => "
- WHERE ((
+ WHERE
customer IN ( SELECT cust_id FROM cust WHERE balance > ? )
AND status IN ( SELECT status_codes FROM states )
- ))
",
bind => [2000],
test => '-in POD test',
test => '-in with an array of function array refs with args',
},
{
- exception => qr/
+ throws => qr/
\QSQL::Abstract before v1.75 used to generate incorrect SQL \E
\Qwhen the -IN operator was given an undef-containing list: \E
\Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
test => '-in with undef as an element',
},
{
- exception => qr/
+ throws => qr/
\QSQL::Abstract before v1.75 used to generate incorrect SQL \E
\Qwhen the -IN operator was given an undef-containing list: \E
\Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
bind => [ 1, 2, 3 ],
test => '-in with multiple undef elements',
},
+ {
+ where => { a => { -in => 42 }, b => { -not_in => 42 } },
+ stmt => ' WHERE a IN ( ? ) AND b NOT IN ( ? )',
+ bind => [ 42, 42 ],
+ test => '-in, -not_in with scalar',
+ },
+ {
+ where => { a => { -in => [] }, b => { -not_in => [] } },
+ stmt => ' WHERE ( 0=1 AND 1=1 )',
+ bind => [],
+ test => '-in, -not_in with empty arrays',
+ },
+ {
+ throws => qr/
+ \QSQL::Abstract before v1.75 used to generate incorrect SQL \E
+ \Qwhen the -IN operator was given an undef-containing list: \E
+ \Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
+ \Qversion of SQL::Abstract will emit the logically correct SQL \E
+ \Qinstead of raising this exception)\E
+ /x,
+ where => { a => { -in => [42, undef] }, b => { -not_in => [42, undef] } },
+ stmt => ' WHERE ( ( a IN ( ? ) OR a IS NULL ) AND b NOT IN ( ? ) AND b IS NOT NULL )',
+ bind => [ 42, 42 ],
+ test => '-in, -not_in with undef among elements',
+ },
+ {
+ throws => qr/
+ \QSQL::Abstract before v1.75 used to generate incorrect SQL \E
+ \Qwhen the -IN operator was given an undef-containing list: \E
+ \Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
+ \Qversion of SQL::Abstract will emit the logically correct SQL \E
+ \Qinstead of raising this exception)\E
+ /x,
+ where => { a => { -in => [undef] }, b => { -not_in => [undef] } },
+ stmt => ' WHERE ( a IS NULL AND b IS NOT NULL )',
+ bind => [],
+ test => '-in, -not_in with just undef element',
+ },
+ {
+ where => { a => { -in => undef } },
+ throws => qr/Argument passed to the 'IN' operator can not be undefined/,
+ test => '-in with undef argument',
+ },
+
+ {
+ where => { -in => [42] },
+ throws => qr/Illegal use of top-level '-in'/,
+ test => 'Top level -in',
+ },
+ {
+ where => { -between => [42, 69] },
+ throws => qr/Illegal use of top-level '-between'/,
+ test => 'Top level -between',
+ },
);
for my $case (@in_between_tests) {
TODO: {
local $TODO = $case->{todo} if $case->{todo};
local $SQL::Abstract::Test::parenthesis_significant = $case->{parenthesis_significant};
+ my $label = $case->{test} || 'in-between test';
+ my $sql = SQL::Abstract->new($case->{args} || {});
- my @w;
- local $SIG{__WARN__} = sub { push @w, @_ };
-
- my $sql = SQL::Abstract->new ($case->{args} || {});
-
- if ($case->{exception}) {
- throws_ok { $sql->where($case->{where}) } $case->{exception};
+ if (my $e = $case->{throws}) {
+ my $stmt;
+ throws_ok { ($stmt) = $sql->where($case->{where}) } $e, "$label throws correctly"
+ or diag dumper ({ where => $case->{where}, result => $stmt });
}
else {
- my ($stmt, @bind) = $sql->where($case->{where});
+ my ($stmt, @bind);
+ warnings_are {
+ ($stmt, @bind) = $sql->where($case->{where});
+ } [], "$label gives no warnings";
+
is_same_sql_bind(
$stmt,
\@bind,
$case->{stmt},
$case->{bind},
+ "$label generates correct SQL and bind",
) || diag_where ( $case->{where} );
}
-
- is (@w, 0, $case->{test} || 'No warnings within in-between tests')
- || diag join "\n", 'Emitted warnings:', @w;
}
}
projects / dbsrgits/SQL-Abstract.git / blobdiff