use INNER for old mysqls

[dbsrgits/Data-Query.git] / lib / Data / Query / Renderer / SQL / Naive.pm

diff --git a/lib/Data/Query/Renderer/SQL/Naive.pm b/lib/Data/Query/Renderer/SQL/Naive.pm
index df2fe36..dbe4b80 100644 (file)
--- a/lib/Data/Query/Renderer/SQL/Naive.pm
+++ b/lib/Data/Query/Renderer/SQL/Naive.pm
@@ -336,18 +336,9 @@ sub _render_literal {
 sub _render_join {
   my ($self, $dq) = @_;
   my ($left, $right) = @{$dq}{qw(left right)};
-  my $join = do {
-    if ($dq->{outer}) {
-      $self->_format_keyword(uc($dq->{outer}).' JOIN');
-    } elsif ($dq->{on}) {
-      $self->_format_keyword('JOIN');
-    } else {
-      ','
-    }
-  };
   my $rhs = $self->_render($right);
   [
-    $self->_render($left), $join,
+    $self->_render($left), $self->_format_join_keyword($dq),
     (is_Join($right) ? ('(', $rhs, ')') : $rhs),
     ($dq->{on}
       ? ($self->_format_keyword('ON'), $self->_render($dq->{on}))
@@ -355,6 +346,17 @@ sub _render_join {
   ];
 }
 
+sub _format_join_keyword {
+  my ($self, $dq) = @_;
+  if ($dq->{outer}) {
+    $self->_format_keyword(uc($dq->{outer}).' JOIN');
+  } elsif ($dq->{on}) {
+    $self->_format_keyword('JOIN');
+  } else {
+    ','
+  }
+}
+
 sub _render_where {
   my ($self, $dq) = @_;
   my ($from, $where) = @{$dq}{qw(from where)};