11 years agoFix incorrect handling of $? in travis preconf script
Peter Rabbitson [Tue, 11 Dec 2012 11:47:42 +0000]
Fix incorrect handling of $? in travis preconf script

11 years agoTemporarily stop requiring podinherit on < 5.10.1, until we fix it
Peter Rabbitson [Tue, 11 Dec 2012 11:33:35 +0000]
Temporarily stop requiring podinherit on < 5.10.1, until we fix it

11 years agoFix RT#78436 - a replicated storage does not have a conninfo as such
Peter Rabbitson [Sat, 3 Nov 2012 17:50:18 +0000]
Fix RT#78436 - a replicated storage does not have a conninfo as such

11 years agoSmoke bleadperl as well
Peter Rabbitson [Mon, 3 Dec 2012 11:46:24 +0000]
Smoke bleadperl as well

11 years agoStop using deprecated regex syntax
Peter Rabbitson [Tue, 11 Dec 2012 11:01:25 +0000]
Stop using deprecated regex syntax

11 years agoPartial fix for the hash randomization issues in 5.17.6+
Peter Rabbitson [Tue, 11 Dec 2012 11:00:18 +0000]
Partial fix for the hash randomization issues in 5.17.6+

NOTE: this is *not* a complete fix. There are at least two other places
which do not manifest themselves due to lack of tests. Work underway...

11 years agoRevert 50e6c52e0 - the crash was most likely due to old Moo (same as dfd722ef)
Peter Rabbitson [Tue, 11 Dec 2012 10:51:20 +0000]
Revert 50e6c52e0 - the crash was most likely due to old Moo (same as dfd722ef)

11 years agoDBIC::Carp not primetime ready - hide
Peter Rabbitson [Tue, 11 Dec 2012 10:47:38 +0000]
DBIC::Carp not primetime ready - hide

11 years agoDo not grab a global lock if test won't run
Peter Rabbitson [Tue, 11 Dec 2012 10:28:52 +0000]
Do not grab a global lock if test won't run

11 years agoFill gaps in documentation: alias ($rs attr), table_alias, result_class
Brendan Byrd [Mon, 10 Dec 2012 22:10:26 +0000]
Fill gaps in documentation: alias ($rs attr), table_alias, result_class

11 years agoFINALLY document DBIC @bind_vals
Brendan Byrd [Mon, 10 Dec 2012 17:41:23 +0000]
FINALLY document DBIC @bind_vals

11 years agoClarify purpose and deprecation of search_literal
Peter Rabbitson [Tue, 11 Dec 2012 10:11:40 +0000]
Clarify purpose and deprecation of search_literal

11 years agoVarious other POD fixes
Brendan Byrd [Tue, 27 Mar 2012 01:31:45 +0000]
Various other POD fixes

Change docs to reflect new Manual::ResultClass
Stop using "moniker"
There is no Row; there is only Zuul.
Arguments, Return Values, and Linking -will- be enforced!

11 years agoUtilize Pod::Inherit to add an INHERITED METHODS section to docs
Brendan Byrd [Tue, 27 Mar 2012 01:31:45 +0000]
Utilize Pod::Inherit to add an INHERITED METHODS section to docs

11 years agoVarious method POD changes
Brendan Byrd [Fri, 23 Mar 2012 15:09:04 +0000]
Various method POD changes

Apply very small doc correction to search_related
Add "official" method entries for $rel and $col
Add more doc clarification changes to ::Row
Fix incorrect last_modified / update comparison in ::Row/update

11 years agoTurn the CLEANTEST smokes into full blown CPAN-based installs with testing
Peter Rabbitson [Sun, 9 Dec 2012 05:25:10 +0000]
Turn the CLEANTEST smokes into full blown CPAN-based installs with testing

Not considering doing cpanreporting because the reporter installation itself
would violate the CLEANTEST idea

11 years agoMore information about the test env we are about to use
Peter Rabbitson [Wed, 5 Dec 2012 10:30:23 +0000]
More information about the test env we are about to use

11 years agoFirebird apt configuration can't be made to cooperate - skip when it fails
Peter Rabbitson [Sun, 9 Dec 2012 05:25:10 +0000]
Firebird apt configuration can't be made to cooperate - skip when it fails

11 years agoReorganize travis preconfig script - better tracing and handling of failures
Peter Rabbitson [Sun, 9 Dec 2012 05:25:04 +0000]
Reorganize travis preconfig script - better tracing and handling of failures

11 years agoMove generated POD to its own dir
Peter Rabbitson [Sun, 9 Dec 2012 13:38:26 +0000]
Move generated POD to its own dir

11 years agoUse legacy File::Path API - avoid a dependency (see next commit)
Peter Rabbitson [Sun, 9 Dec 2012 16:51:35 +0000]
Use legacy File::Path API - avoid a dependency (see next commit)

11 years agoWhile permanentising meta/ 62628242 did not properly noindex it
Peter Rabbitson [Mon, 10 Dec 2012 08:05:32 +0000]
While permanentising meta/ 62628242 did not properly noindex it

11 years agoForgotten no-longer-needed dependency after d6b39e46
Peter Rabbitson [Sun, 9 Dec 2012 12:45:57 +0000]
Forgotten no-longer-needed dependency after d6b39e46

11 years agoAUTHORS mass update; mst doesn't have to take credit for -everything- :)
Brendan Byrd [Thu, 9 Aug 2012 14:45:54 +0000]
AUTHORS mass update; mst doesn't have to take credit for -everything- :)

11 years agoRelax FB reconfig timings even more
Peter Rabbitson [Mon, 3 Dec 2012 10:30:35 +0000]
Relax FB reconfig timings even more

11 years agoTruly clean CLEANTEST
Peter Rabbitson [Mon, 3 Dec 2012 10:29:58 +0000]
Truly clean CLEANTEST

11 years agoDisable travis list notifications until things stabilize
Peter Rabbitson [Mon, 3 Dec 2012 10:23:40 +0000]
Disable travis list notifications until things stabilize

11 years agoAdd comprehensive Firebird smoking to travis
Peter Rabbitson [Sun, 2 Dec 2012 06:53:46 +0000]
Add comprehensive Firebird smoking to travis

11 years agoExpand comments, move core dep install before RDBMS setup (no func. changes)
Peter Rabbitson [Sun, 2 Dec 2012 06:53:46 +0000]
Expand comments, move core dep install before RDBMS setup (no func. changes)

11 years agoDo not spam the mailing lists - only notify once per branchfail
Peter Rabbitson [Sun, 2 Dec 2012 08:13:54 +0000]
Do not spam the mailing lists - only notify once per branchfail

11 years agoAdd MOAR meta
Peter Rabbitson [Fri, 30 Nov 2012 18:34:30 +0000]
Add MOAR meta

11 years agoThrow away suboptimal travis CPANM env-option and tighten plans more
Peter Rabbitson [Fri, 30 Nov 2012 15:45:07 +0000]
Throw away suboptimal travis CPANM env-option and tighten plans more

11 years agoMore extensive travis testing plan
Peter Rabbitson [Thu, 29 Nov 2012 13:57:30 +0000]
More extensive travis testing plan

11 years agoFix the leaktracer rewrite in 218b7c12 which broke under 5.10
Peter Rabbitson [Fri, 30 Nov 2012 14:44:26 +0000]
Fix the leaktracer rewrite in 218b7c12 which broke under 5.10

Reduce the amount of shuffling happening in CLONE - use a fresh hashref
instead

11 years agoSome podlator stacks do not like multi-word =begin
Peter Rabbitson [Thu, 29 Nov 2012 13:50:36 +0000]
Some podlator stacks do not like multi-word =begin

11 years agoUpdate .travis.yml with faster deps and DBICTESTs
Brendan Byrd [Mon, 12 Nov 2012 21:06:28 +0000]
Update .travis.yml with faster deps and DBICTESTs

11 years agoStop stripping table name qualifier on complex $rs->update/delete
Peter Rabbitson [Mon, 19 Nov 2012 07:49:45 +0000]
Stop stripping table name qualifier on complex $rs->update/delete

RT#80015, RT#78844

11 years agoBack out frivolous loading of threads.pm
Peter Rabbitson [Sun, 18 Nov 2012 20:17:09 +0000]
Back out frivolous loading of threads.pm

Not only was this an unsuccesful attempt to mask out a bug introduced
in Moo's inlining of Devel::GlobalDestruction (since fixed), but it
broke a test under older win32 perls.
Revert 8bab2062, bump Moo dep

11 years agoRewrite 461c7168 solving Oracle silent connection failures
Peter Rabbitson [Sun, 18 Nov 2012 22:32:57 +0000]
Rewrite 461c7168 solving Oracle silent connection failures

The patch incorrectly masks the underlying issue - during the refactor
of 584ea6e4 a bunch of exception traps were introduced which were never
there in the first place. _dbh_get_info() should always be throwing an
error if one takes place (the only place before 584ea6e4 was in the
FreeTDS version determination, and that one made no sense anyway).
_server_info() OTOH is indeed an opportunistic routine - leave the
"rethrow if determining driver" escape as-is

11 years agoRename and expand false-value prefetch test
Peter Rabbitson [Sun, 18 Nov 2012 20:08:58 +0000]
Rename and expand false-value prefetch test

11 years agoWhile the TODO was solved in b11221ff the source of confusion was not
Peter Rabbitson [Sun, 18 Nov 2012 19:59:44 +0000]
While the TODO was solved in b11221ff the source of confusion was not

11 years agoList of what needs undoing since 0.08196
Peter Rabbitson [Sat, 25 Aug 2012 22:45:30 +0000]
List of what needs undoing since 0.08196

11 years agoExtended mailmap (name match only)
Peter Rabbitson [Sun, 18 Nov 2012 18:35:37 +0000]
Extended mailmap (name match only)

11 years agoFix test skips just like was done in 49b3a264
Peter Rabbitson [Wed, 14 Nov 2012 08:54:53 +0000]
Fix test skips just like was done in 49b3a264

11 years agoMore robust behavior under heavily threaded environments
Peter Rabbitson [Wed, 14 Nov 2012 08:54:18 +0000]
More robust behavior under heavily threaded environments

11 years agoReorganize metadata, add github addresses
Peter Rabbitson [Wed, 14 Nov 2012 07:16:50 +0000]
Reorganize metadata, add github addresses
Make the meta repository read github, so that metacpan shows cool
buttons for the cool kids. Note - the official repo still does and will
continue to reside on sc

11 years agodoc fix for Resultset find_or_new and update_or_new methods
Michael Jemmeson [Thu, 8 Nov 2012 14:01:27 +0000]
doc fix for Resultset find_or_new and update_or_new methods

11 years agoRelease 0.08204 v0.08204
Torsten Raudssus [Thu, 8 Nov 2012 19:56:08 +0000]
Release 0.08204

11 years agoBump CAG to a bugfixed version
Peter Rabbitson [Thu, 8 Nov 2012 12:00:10 +0000]
Bump CAG to a bugfixed version

11 years agoAsk for newer CAG which asks for bugfixed CXSA
Peter Rabbitson [Mon, 5 Nov 2012 08:31:44 +0000]
Ask for newer CAG which asks for bugfixed CXSA

11 years agoSquash NaN warnings on older perls
Peter Rabbitson [Mon, 5 Nov 2012 08:15:28 +0000]
Squash NaN warnings on older perls

11 years agoSwitch vestigial warn() calls to carp()
Peter Rabbitson [Mon, 5 Nov 2012 08:11:19 +0000]
Switch vestigial warn() calls to carp()

11 years agoBetter diagnostics in the case of missing drivers, slight ADO/ODBC refactor
Peter Rabbitson [Mon, 5 Nov 2012 02:35:45 +0000]
Better diagnostics in the case of missing drivers, slight ADO/ODBC refactor

11 years agoMore 5.8 nested-cref test leaks
Peter Rabbitson [Mon, 5 Nov 2012 05:18:16 +0000]
More 5.8 nested-cref test leaks

11 years agoExtra tests from an old debugging session
Peter Rabbitson [Thu, 5 Jan 2012 02:46:01 +0000]
Extra tests from an old debugging session

11 years agoRemove code which migrated into the core of SQLA
Peter Rabbitson [Wed, 11 Apr 2012 05:20:10 +0000]
Remove code which migrated into the core of SQLA

11 years agoTest that ->new() on a ResultSet object returns a Row
Fitz Elliott [Thu, 12 Jul 2012 21:26:59 +0000]
Test that ->new() on a ResultSet object returns a Row

11 years agoFix API mismatch between new_related() and new_result() (RT#78336)
Peter Rabbitson [Sat, 3 Nov 2012 17:12:06 +0000]
Fix API mismatch between new_related() and new_result() (RT#78336)

Almost 7 years ago a refactor in fea3d045 fed an (undocumented) $attrs
parameter from new_related() to new_result(), while new_result() never
expected (and ignored) said parameter. Since this is an undocumented
feature, which nobody complained about for all this time - document
extensively and kill it with fire.

11 years agoClarify CookBook example (RT#78283)
Peter Rabbitson [Sat, 3 Nov 2012 16:32:13 +0000]
Clarify CookBook example (RT#78283)

11 years agoFix CookBook example until the rsrc refactor (RT#77910)
Peter Rabbitson [Sat, 3 Nov 2012 16:18:54 +0000]
Fix CookBook example until the rsrc refactor (RT#77910)

11 years agoImprove IC documentation (RT#76525)
Peter Rabbitson [Sat, 3 Nov 2012 16:12:37 +0000]
Improve IC documentation (RT#76525)

11 years agoMention the internal join pruner in POD
Alessandro Ranellucci [Sat, 7 Apr 2012 17:37:33 +0000]
Mention the internal join pruner in POD

11 years agoFix unique constraint violations in Ordered.pm blanket movement (RT#79773)
Peter Rabbitson [Sat, 3 Nov 2012 12:44:57 +0000]
Fix unique constraint violations in Ordered.pm blanket movement (RT#79773)

This essentially reverts 5e6fde33e5 which was applied without much thinking.
Added a test to ensure this doesn't re-break again.

11 years agoProperly signify internal cursor methods, trash their accessors as well
Peter Rabbitson [Fri, 14 Sep 2012 05:39:06 +0000]
Properly signify internal cursor methods, trash their accessors as well

(the accessors were not used throughout anyway)

11 years agofix Cursor SYNOPSIS
Rafael Kitover [Sun, 26 Aug 2012 16:21:37 +0000]
fix Cursor SYNOPSIS

11 years agoReorganize constants handling, add escapes for fork-less OSes
Peter Rabbitson [Mon, 17 Sep 2012 13:55:30 +0000]
Reorganize constants handling, add escapes for fork-less OSes

11 years agoLet SQLMaker rs_attr 'for' support string literals
Matt Phillips [Fri, 19 Oct 2012 18:49:46 +0000]
Let SQLMaker rs_attr 'for' support string literals

SQLMaker previously only allowed hardcoded values with the 'for' attr,
overriding in storage specific subclasses. Rather than attempt to provide an
exhaustive list of possible options, the base class can now take \$scalaras
an override that is embedded directly in the returned $sql

11 years agoCompress changelog a bit (excise devrel fluff)
Peter Rabbitson [Sat, 3 Nov 2012 11:08:06 +0000]
Compress changelog a bit (excise devrel fluff)

11 years agoFix invalid pod example syntax
Felix Antonius Wilhelm Ostmann [Sat, 20 Oct 2012 13:54:34 +0000]
Fix invalid pod example syntax

11 years agorelease 0.08203_01
Peter Rabbitson [Sat, 20 Oct 2012 14:03:02 +0000]
release 0.08203_01

11 years agoFix embarassing test-leak introduced in 0.08203
Peter Rabbitson [Sat, 20 Oct 2012 13:50:42 +0000]
Fix embarassing test-leak introduced in 0.08203

11 years agorelease 0.08203 v0.08203
Arthur Axel 'fREW' Schmidt [Thu, 18 Oct 2012 18:24:46 +0000]
release 0.08203

11 years agorelease 0.08202_01
Arthur Axel 'fREW' Schmidt [Mon, 15 Oct 2012 12:49:55 +0000]
release 0.08202_01

11 years agoReally fix the DBD::SQLite ping() issue
Peter Rabbitson [Tue, 9 Oct 2012 11:35:09 +0000]
Really fix the DBD::SQLite ping() issue

Apparently DBD::SQLite is notoriously bad at synchronizing its internal
transaction state with {AutoCommit}
https://metacpan.org/source/ADAMK/DBD-SQLite-1.37/lib/DBD/SQLite.pm#L921
There is a function http://www.sqlite.org/c3ref/get_autocommit.html
but DBD::SQLite does not expose it (nor does it seem to properly use it)

Furthermore the detection is rather broken as described in RT#80087.
Bend over backwards to attempt to preserve as much sanity as possible.
While at it issue a non-trappable warning so that folks fix the offending
codepath (which arguably is still broken)

It is possible to have a proper "connection", and have "ping" return
false anyway (e.g. corrupted file). In such cases DBD::SQLite still
keeps the actual file handle open. We don't really want this to happen,
so force-close the handle via DBI itself (this solves a bunch of Win32
test failures)

11 years agoRemove TODO on fixed recent DBD::SQLite
Peter Rabbitson [Fri, 12 Oct 2012 14:20:11 +0000]
Remove TODO on fixed recent DBD::SQLite

11 years agorelease commit for 0.08202 v0.08202
Matt S Trout [Sat, 6 Oct 2012 17:35:24 +0000]
release commit for 0.08202

11 years agorelease 0.08201 v0.08201
Arthur Axel 'fREW' Schmidt [Fri, 5 Oct 2012 21:18:28 +0000]
release 0.08201

11 years agoFix test using legacy order_by spec
Peter Rabbitson [Thu, 30 Aug 2012 17:09:09 +0000]
Fix test using legacy order_by spec

11 years agoReplace inadequate $dbh->ping SQLite implementation (RT#78420)
Peter Rabbitson [Thu, 30 Aug 2012 17:06:13 +0000]
Replace inadequate $dbh->ping SQLite implementation (RT#78420)

When SQLite attempts to connect to a file that is not a database,
it nevertheless maintains a true $dbh->{Active} and $dbh->ping.
Replace with a schema listing SELECT, and fix test erroneously
assuming it can portably do chmod 000

11 years agoDon't ignore README, it's supposed to be cleaned automatically.
Dagfinn Ilmari Mannsåker [Sat, 1 Sep 2012 16:13:20 +0000]
Don't ignore README, it's supposed to be cleaned automatically.

11 years agoRevert "Fix t/storage/reconnect.t when run as root"
Dagfinn Ilmari Mannsåker [Sat, 1 Sep 2012 13:39:19 +0000]
Revert "Fix t/storage/reconnect.t when run as root"

The test change just papered over the problem, a proper fix is pending
on the for_current/riba/fix_sqlite_ping_RT78420 branch.

This reverts commit 64819b0e69a844bb790701e13931afcc34f3d981.

11 years agoFix t/storage/reconnect.t when run as root
Dagfinn Ilmari Mannsåker [Sat, 1 Sep 2012 01:22:27 +0000]
Fix t/storage/reconnect.t when run as root

As root, the chmod 000 doesn't prevent SQLite form opening the fake db
file, so we need to disconnect to make it reopen the restored real one.

11 years agoFix filename interpolation in DBIC::Optional::Dependecies
Dagfinn Ilmari Mannsåker [Sat, 25 Aug 2012 00:40:09 +0000]
Fix filename interpolation in DBIC::Optional::Dependecies

11 years agoIgnore Emacs droppings and generated README
Dagfinn Ilmari Mannsåker [Fri, 24 Aug 2012 23:55:02 +0000]
Ignore Emacs droppings and generated README

11 years agorelease 0.08200 v0.08200
Arthur Axel 'fREW' Schmidt [Fri, 24 Aug 2012 02:37:13 +0000]
release 0.08200

11 years agoput off deprecation and clarify test output
Arthur Axel 'fREW' Schmidt [Fri, 24 Aug 2012 13:33:30 +0000]
put off deprecation and clarify test output

11 years agorewrite test to use existing schema
Arthur Axel 'fREW' Schmidt [Fri, 24 Aug 2012 02:34:58 +0000]
rewrite test to use existing schema

11 years agorelease 0.08199 v0.08199
Arthur Axel 'fREW' Schmidt [Thu, 23 Aug 2012 01:18:26 +0000]
release 0.08199

11 years agoDev release changes
Jess Robinson [Wed, 1 Aug 2012 18:26:13 +0000]
Dev release changes

11 years agoBack out constructor/prefetch rewrite introduced mainly by 43245ada4a
Peter Rabbitson [Tue, 24 Jul 2012 10:12:31 +0000]
Back out constructor/prefetch rewrite introduced mainly by 43245ada4a

It was shipped against the authors advice, while containing multiple known
bugs. After the expected bugreports went warnocked for over two weeks by the
new DBIC release team, it seems that the only way to partially restore the
release quality DBIC users have come to expect, is to currently throw this
code away until better times.

Should resolve RT#78456 and the issues reported in these threads:
http://lists.scsys.co.uk/pipermail/dbix-class/2012-July/010681.html
http://lists.scsys.co.uk/pipermail/dbix-class/2012-July/010682.html

11 years agofailing test for prefetch bug where prefetched values of 0 might break inflation
Eden Cardim [Wed, 22 Aug 2012 19:22:53 +0000]
failing test for prefetch bug where prefetched values of 0 might break inflation

11 years agoremove ->deploy from castaway's test
Rafael Kitover [Thu, 2 Aug 2012 14:22:18 +0000]
remove ->deploy from castaway's test

11 years agoNew test for recent prefetch/undef bug
Jess Robinson [Wed, 1 Aug 2012 22:16:07 +0000]
New test for recent prefetch/undef bug

11 years ago Fix Class::AccessorGroup to allow instances in get_component_class.
Gareth Kirwan [Tue, 17 Jul 2012 15:49:50 +0000]
 Fix Class::AccessorGroup to allow instances in get_component_class.
 Fixes result_class($obj) exploding instead of just using the object.

11 years agorelease v0.08198 v0.08198
Arthur Axel 'fREW' Schmidt [Wed, 11 Jul 2012 02:55:05 +0000]
release v0.08198

11 years agofix silent Oracle connection failures
Rafael Kitover [Sun, 24 Jun 2012 17:42:46 +0000]
fix silent Oracle connection failures

::Storage::DBI::_server_info was eating connection exceptions by
ignoring exceptions from $dbh->get_info, but this information is
important for _rebless when e.g. determining which class to use based on
the DB server version, so rethrow the exceptions when
$self->{_in_determine_driver} is true.

11 years agobetter type check for mssql+ado binary null strip
Rafael Kitover [Sun, 24 Jun 2012 06:59:11 +0000]
better type check for mssql+ado binary null strip

The data_type in the t/lib result class for the blob for the tests
changed to 'blob', while the binary type null stripper only expected
'binary' or 'image' data types, which is wrong for possibly
cross-deployed schemas.

Change _strip_trailing_binary_nulls in ::ADO::CursorUtils to use the
newly added and more generic ::Storage::DBI::_is_binary_type instead of
just checking for 'binary' or 'image'.

11 years agomark some tests in admin/10script.t on Win32 TODO
Rafael Kitover [Sun, 24 Jun 2012 05:32:03 +0000]
mark some tests in admin/10script.t on Win32 TODO

The test_dbicadmin() tests are failing on Win32 due to some sort of
quoting issue with the temp directory. I'm not sure how the temp
directory is being used here, so it will have to wait for someone else,
in the meanwhile I marked the tests TODO.

Also changed the " backwhacking to use Win32::ShellQuote instead and
added it to optdeps, unfortunately that didn't fix the problem, since
the problem seems to be some sort of DBICTest::RunMode interaction with
dbicadmin.

11 years agopreload threads.pm in storage/txn.t for fork error
Rafael Kitover [Mon, 18 Jun 2012 15:49:37 +0000]
preload threads.pm in storage/txn.t for fork error

SineSwiper reported this error in t/storage/txn.t on Strawberry Perl
5.12 32bit:

You must load the 'threads' module before Moo::_Utils at t/storage/txn.t
line 130.

Preload threads in a BEGIN block at the beginning of the .t file for
Win32. This fixes the error.

11 years agoskip 51threadnodb.t on Win32 on < 5.14
Rafael Kitover [Mon, 18 Jun 2012 15:11:36 +0000]
skip 51threadnodb.t on Win32 on < 5.14

SineSwiper reported a crash with a dialog from "make test" in
t/51threadnodb.t on Strawberry Perl 5.12 32bit.

The test passes on my ActivePerl 64bit 5.14.2 and there is a passing
test report for 5.14 here:
http://www.cpantesters.org/cpan/report/239d2ae4-87c3-1015-ad08-a09405085451

Disable test on Win32 for perls below 5.14 unless the environment
variable TEST_AUTHOR is set to be safe.