From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: Thu, 26 Dec 2013 15:30:54 +0000 (+0100)
Subject: Remove obsolete Oracle _insert_returning method
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits%2FDBIx-Class.git;a=commitdiff_plain;h=f30a664266b25b562b4e5a45c1c5b9b674624405

Remove obsolete Oracle _insert_returning method
---

diff --git a/lib/DBIx/Class/SQLMaker/Oracle.pm b/lib/DBIx/Class/SQLMaker/Oracle.pm
index abbba71..715083a 100644
--- a/lib/DBIx/Class/SQLMaker/Oracle.pm
+++ b/lib/DBIx/Class/SQLMaker/Oracle.pm
@@ -204,57 +204,4 @@ sub _unqualify_colname {
   return $self->_shorten_identifier($self->next::method($fqcn));
 }
 
-#
-# Oracle has a different INSERT...RETURNING syntax
-#
-
-sub _insert_returning {
-  my ($self, $options) = @_;
-
-  my $f = $options->{returning};
-
-  my ($f_list, @f_names) = do {
-    if (! ref $f) {
-      (
-        $self->_quote($f),
-        $f,
-      )
-    }
-    elsif (ref $f eq 'ARRAY') {
-      (
-        (join ', ', map { $self->_quote($_) } @$f),
-        @$f,
-      )
-    }
-    elsif (ref $f eq 'SCALAR') {
-      (
-        $$f,
-        $$f,
-      )
-    }
-    else {
-      $self->throw_exception("Unsupported INSERT RETURNING option $f");
-    }
-  };
-
-  my $rc_ref = $options->{returning_container}
-    or $self->throw_exception('No returning container supplied for IR values');
-
-  @$rc_ref = (undef) x @f_names;
-
-  return (
-    ( join (' ',
-      $self->_sqlcase(' returning'),
-      $f_list,
-      $self->_sqlcase('into'),
-      join (', ', ('?') x @f_names ),
-    )),
-    map {
-      $self->{bindtype} eq 'columns'
-        ? [ $f_names[$_] => \$rc_ref->[$_] ]
-        : \$rc_ref->[$_]
-    } (0 .. $#f_names),
-  );
-}
-
 1;