From: Peter Rabbitson Date: Thu, 5 Mar 2015 19:14:12 +0000 (+0100) Subject: Fix t/54taint.t failures on perl-in-hell-in-space X-Git-Tag: v0.082820~18 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits%2FDBIx-Class.git;a=commitdiff_plain;h=e1868e36cb04ee1d6b02b48ae199abc4526e891a Fix t/54taint.t failures on perl-in-hell-in-space Given its a core bug, and the test is not critical, just skip the whole thing (cherry pick of a5741f5c) --- diff --git a/Changes b/Changes index 36dfaeb..0cda709 100644 --- a/Changes +++ b/Changes @@ -3,6 +3,8 @@ Revision history for DBIx::Class * Misc - Depend on newer Moo, to benefit from a safer runtime (RT#93004) - Fix intermittent failures in the LeakTracer on 5.18+ + - Fix failures of t/54taint.t on Windows with spaces in the $^X + executable path (RT#101615) 0.082810 2014-10-25 13:58 (UTC) * Fixes diff --git a/t/54taint.t b/t/54taint.t index 7f0db9a..6b866e6 100644 --- a/t/54taint.t +++ b/t/54taint.t @@ -6,6 +6,11 @@ use Config; # doesn't work. We don't want to have the user deal with that. BEGIN { unless ($INC{'t/lib/DBICTest/WithTaint.pm'}) { + if ( $^O eq 'MSWin32' and $^X =~ /\x20/ ) { + print "1..0 # SKIP Running this test on Windows with spaces within the perl executable path (\$^X) is not possible due to https://rt.perl.org/Ticket/Display.html?id=123907\n"; + exit 0; + } + # it is possible the test itself is initially invoked in taint mode # and with relative paths *and* with a relative $^X and some other # craziness... in short: just be proactive