From: Peter Rabbitson <ribasushi@cpan.org>
Date: Sun, 11 Jul 2010 01:18:37 +0000 (+0200)
Subject: Fix bulk-insert trace
X-Git-Tag: v0.08124~113
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits%2FDBIx-Class.git;a=commitdiff_plain;h=6c3e6bf62e7b21a233f9dea22b2228f1c4e2381a

Fix bulk-insert trace
---

diff --git a/Changes b/Changes
index 31f13e2..575416e 100644
--- a/Changes
+++ b/Changes
@@ -4,16 +4,18 @@ Revision history for DBIx::Class
         - Fixed rels ending with me breaking subqueried limit realiasing
         - Oracle sequence detection now *really* works across schemas
           (fixed some ommissions from 0.08123)
-        - add_unique_constraint() now throws if called with multiple constraint
-          definitions
+        - add_unique_constraint() now throws if called with multiple
+          constraint definitions
         - Implemented add_unique_constraints() which delegates to
           add_unique_constraint() as appropriate
         - dbicadmin now uses a /usr/bin/env shebang to work better with
           perlbrew and other local perl builds
+        - bulk-inserts via $dbh->bind_array (void $rs->populate) now
+          display properly in DBIC_TRACE
 
     * Misc
-        - Makefile.PL no longer imports GetOptions() to interoperate better
-          with Catalyst installers
+        - Makefile.PL no longer imports GetOptions() to interoperate
+          better with Catalyst installers
         - Bumped minimum Module::Install for developers
 
 0.08123 2010-06-12 14:46 (UTC)
diff --git a/lib/DBIx/Class/Storage/DBI.pm b/lib/DBIx/Class/Storage/DBI.pm
index 5156731..8aacfa1 100644
--- a/lib/DBIx/Class/Storage/DBI.pm
+++ b/lib/DBIx/Class/Storage/DBI.pm
@@ -1631,7 +1631,7 @@ sub insert_bulk {
   # scope guard
   my $guard = $self->txn_scope_guard;
 
-  $self->_query_start( $sql, ['__BULK__'] );
+  $self->_query_start( $sql, [ dummy => '__BULK_INSERT__' ] );
   my $sth = $self->sth($sql);
   my $rv = do {
     if ($empty_bind) {
@@ -1644,7 +1644,7 @@ sub insert_bulk {
     }
   };
 
-  $self->_query_end( $sql, ['__BULK__'] );
+  $self->_query_end( $sql, [ dummy => '__BULK_INSERT__' ] );
 
   $guard->commit;