Mark forgotten ::Row::id() method as indirect_sugar
authorPeter Rabbitson <ribasushi@cpan.org>
Thu, 29 Sep 2016 10:59:27 +0000 (12:59 +0200)
committerPeter Rabbitson <ribasushi@cpan.org>
Fri, 30 Sep 2016 15:45:56 +0000 (17:45 +0200)
commit97940e368df996e1fe6111fb14f560594dc4c0b2
tree77518b5e3b4780eb62750addf59aa52241c108d3
parentc5340bfac7aff784999be6ab4fa803fd9440043f
Mark forgotten ::Row::id() method as indirect_sugar

Discouraged legacy sugar, which does not even work properly with multicolumn
keys in scalar context. Mark properly as INDIRECT to ensure DBIC does not rely
on it anywhere

Also adjust the SanityChecker to not complain about shadowing of sugar methods
with generated ones (i.e. column accessors) - while unfortunate, this kind of
thing happens quite often (especially with such a generic name as 'id') and
warning about it would make no sense (left alone that methods which are
..._generated_from_resultsource_metadata generally do not invoke next::method
anyway)
lib/DBIx/Class/PK.pm
lib/DBIx/Class/Schema/SanityChecker.pm
lib/DBIx/Class/_Util.pm