X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits%2FDBIx-Class.git;a=blobdiff_plain;f=t%2F99dbic_sqlt_parser.t;h=2ab43a33e45720e3de4cc65a6f8324d204939545;hp=628f3cfdf6f7af5fc785bd8017807330d59a3694;hb=4c90556806f286093d0806e858abdba329e6dfd3;hpb=c49ff5072c30f7667c267ae232b7d4ec57fa8933 diff --git a/t/99dbic_sqlt_parser.t b/t/99dbic_sqlt_parser.t index 628f3cf..2ab43a3 100644 --- a/t/99dbic_sqlt_parser.t +++ b/t/99dbic_sqlt_parser.t @@ -1,31 +1,95 @@ +BEGIN { do "./t/lib/ANFANG.pm" or die ( $@ || $! ) } +use DBIx::Class::Optional::Dependencies -skip_all_without => 'deploy'; + use strict; use warnings; +BEGIN { $ENV{DBICTEST_VIA_REPLICATED} = 0 } + use Test::More; +use Test::Warn; use Test::Exception; -use lib qw(t/lib); -use DBICTest; -use DBICTest::Schema; use Scalar::Util (); -BEGIN { - require DBIx::Class::Storage::DBI; - plan skip_all => - 'Test needs SQL::Translator ' . DBIx::Class::Storage::DBI->_sqlt_minimum_version - if not DBIx::Class::Storage::DBI->_sqlt_version_ok; -} +use DBICTest; +use DBIx::Class::_Util 'sigwarn_silencer'; # Test for SQLT-related leaks { my $s = DBICTest::Schema->clone; - create_schema ({ schema => $s }); + + my @schemas = ( + create_schema ({ schema => $s }), + create_schema ({ args => { parser_args => { dbic_schema => $s } } }), + ); + + for my $parser_args_key (qw( + DBIx::Class::Schema + DBIx::Schema + package + )) { + warnings_exist { + push @schemas, create_schema({ + args => { parser_args => { $parser_args_key => $s } } + }); + } qr/\Qparser_args => {\E.+?is deprecated.+\Q@{[__FILE__]}/, + "deprecated crazy parser_arg '$parser_args_key' warned"; + } + Scalar::Util::weaken ($s); ok (!$s, 'Schema not leaked'); + + isa_ok ($_, 'SQL::Translator::Schema', "SQLT schema object $_ produced") + for @schemas; +} + +# make sure classname-style works +lives_ok { isa_ok (create_schema ({ schema => 'DBICTest::Schema' }), 'SQL::Translator::Schema', 'SQLT schema object produced') }; + +# make sure a connected instance passed via $args does not get the $dbh improperly serialized +SKIP: { + + DBIx::Class::Optional::Dependencies->skip_without( 'YAML>=0' ); + + lives_ok { + + my $s = DBICTest->init_schema(no_populate => 1); + ok ($s->storage->connected, '$schema instance connected'); + + # roundtrip through YAML + my $yaml_rt_schema = SQL::Translator->new( + parser => 'SQL::Translator::Parser::YAML' + )->translate( + data => SQL::Translator->new( + parser_args => { dbic_schema => $s }, + parser => 'SQL::Translator::Parser::DBIx::Class', + producer => 'SQL::Translator::Producer::YAML', + )->translate + ); + + isa_ok ( $yaml_rt_schema, 'SQL::Translator::Schema', 'SQLT schema object produced after YAML roundtrip'); + + ok ($s->storage->connected, '$schema instance still connected'); + } + + eval <<'EOE' or die $@; + END { + # we are in END - everything remains global + # + $^W = 1; # important, otherwise DBI won't trip the next fail() + $SIG{__WARN__} = sub { + fail "Unexpected global destruction warning" + if $_[0] =~ /is not a DBI/; + warn @_; + }; + } +EOE + } +my $schema = DBICTest->init_schema( no_deploy => 1 ); -my $schema = DBICTest->init_schema(); # Dummy was yanked out by the sqlt hook test # CustomSql tests the horrific/deprecated ->name(\$sql) hack # YearXXXXCDs are views @@ -129,16 +193,99 @@ lives_ok (sub { }); +{ + package DBICTest::PartialSchema; + + use base qw/DBICTest::BaseSchema/; + + __PACKAGE__->load_classes( + { 'DBICTest::Schema' => [qw/ + CD + Track + Tag + Producer + CD_to_Producer + /]} + ); +} + +{ + my $partial_schema = DBICTest::PartialSchema->connect(DBICTest->_database); + + lives_ok (sub { + my $sqlt_schema = do { + + local $SIG{__WARN__} = sigwarn_silencer( + qr/Ignoring relationship .+ related resultsource .+ is not registered with this schema/ + ); + + create_schema({ schema => $partial_schema }); + }; + + my @tables = $sqlt_schema->get_tables; + + is_deeply ( + [sort map { $_->name } @tables], + [qw/cd cd_to_producer producer tags track/], + 'partial dbic schema parsing ok', + ); + + # the primary key is currently unnamed in sqlt - adding below + my %constraints_for_table = ( + producer => [qw/prod_name /], + tags => [qw/tagid_cd tagid_cd_tag tags_fk_cd tags_tagid_tag tags_tagid_tag_cd /], + track => [qw/track_cd_position track_cd_title track_fk_cd /], + cd => [qw/cd_artist_title cd_fk_single_track /], + cd_to_producer => [qw/cd_to_producer_fk_cd cd_to_producer_fk_producer /], + ); + + for my $table (@tables) { + my $tablename = $table->name; + my @constraints = $table->get_constraints; + is_deeply ( + [ sort map { $_->name } @constraints ], + + # the primary key (present on all loaded tables) is currently named '' in sqlt + # subject to future changes + [ '', @{$constraints_for_table{$tablename}} ], + + "constraints of table '$tablename' ok", + ); + } + }, 'partial schema tests successful'); +} + +{ + my $cd_rsrc = $schema->source('CD'); + $cd_rsrc->name(\'main.cd'); + + my $sqlt_schema = create_schema( + { schema => $schema }, + args => { ignore_constraint_names => 0, ignore_index_names => 0 } + ); + + foreach my $source_name (qw(CD)) { + my $table = get_table($sqlt_schema, $schema, $source_name); + ok( + !(grep {$_->name =~ m/main\./} $table->get_indices), + 'indices have periods stripped out' + ); + ok( + !(grep {$_->name =~ m/main\./} $table->get_constraints), + 'constraints have periods stripped out' + ); + } +} + done_testing; sub create_schema { my $args = shift; - my $schema = $args->{schema}; my $additional_sqltargs = $args->{args} || {}; my $sqltargs = { - add_drop_table => 1, + add_drop_table => 1, ignore_constraint_names => 1, ignore_index_names => 1, %{$additional_sqltargs} @@ -147,7 +294,9 @@ sub create_schema { my $sqlt = SQL::Translator->new( $sqltargs ); $sqlt->parser('SQL::Translator::Parser::DBIx::Class'); - return $sqlt->translate({ data => $schema }) || die $sqlt->error; + return $sqlt->translate( + $args->{schema} ? ( data => $args->{schema} ) : () + ) || die $sqlt->error; } sub get_table {