From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: Wed, 21 Mar 2018 12:15:55 +0000 (+0000)
Subject: Simplify skip of ODBC-only Firebird tests
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits%2FDBIx-Class-Schema-Loader.git;a=commitdiff_plain;h=c76ebcc7feb441874ed32d2674cc67e7b12e7853

Simplify skip of ODBC-only Firebird tests
---

diff --git a/t/10_09firebird_common.t b/t/10_09firebird_common.t
index 358c60a..31b65c6 100644
--- a/t/10_09firebird_common.t
+++ b/t/10_09firebird_common.t
@@ -195,7 +195,10 @@ my $tester = dbixcsl_common_tests->new(
                 'view definition';
 
             # test the fixed up ->_dbh_type_info_type_name for the ODBC driver
-            if ($schema->storage->_dbi_connect_info->[0] =~ /:ODBC:/i) {
+            SKIP: {
+                skip '_dbh_type_info_type_name test is only for DBD::ODBC', 3
+                    unless $schema->storage->_dbi_connect_info->[0] =~ /:ODBC:/i;
+
                 my %truncated_types = (
                       4 => 'INTEGER',
                      -9 => 'VARCHAR(x) CHARACTER SET UNICODE_FSS',
@@ -208,10 +211,6 @@ my $tester = dbixcsl_common_tests->new(
                         "ODBC ->_dbh_type_info_type_name correct for '$truncated_types{$type_num}'";
                 }
             }
-            else {
-                my $tb = Test::More->builder;
-                $tb->skip('not testing _dbh_type_info_type_name on DBD::InterBase') for 1..3;
-            }
         },
     },
 );