X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits%2FDBIx-Class-Schema-Loader.git;a=blobdiff_plain;f=t%2Flib%2Fdbixcsl_common_tests.pm;h=c8bc757ff0002940b54371d6015604922794f390;hp=dd9770553781dec6774544105d68cdc51caa8ba0;hb=6947b5d664d1e4136dfe8d410f821e0a4bdaba31;hpb=df956aad09bce14245ebcbd13063ca2119b6c042 diff --git a/t/lib/dbixcsl_common_tests.pm b/t/lib/dbixcsl_common_tests.pm index dd97705..c8bc757 100644 --- a/t/lib/dbixcsl_common_tests.pm +++ b/t/lib/dbixcsl_common_tests.pm @@ -4,6 +4,7 @@ use strict; use warnings; use Test::More; +use Test::Exception; use DBIx::Class::Schema::Loader; use Class::Unload; use File::Path; @@ -11,9 +12,14 @@ use DBI; use Digest::MD5; use File::Find 'find'; use Class::Unload (); -use Data::Dumper::Concise; +use DBIx::Class::Schema::Loader::Utils 'dumper_squashed'; +use List::MoreUtils 'apply'; +use DBIx::Class::Schema::Loader::Optional::Dependencies (); +use namespace::clean; -my $DUMP_DIR = './t/_common_dump'; +use dbixcsl_test_dir qw/$tdir/; + +my $DUMP_DIR = "$tdir/common_dump"; rmtree $DUMP_DIR; sub new { @@ -40,11 +46,11 @@ sub new { # Optional extra tables and tests $self->{extra} ||= {}; - $self->{date_datatype} ||= 'DATE'; + $self->{basic_date_datatype} ||= 'DATE'; # Not all DBS do SQL-standard CURRENT_TIMESTAMP - $self->{default_function} ||= "CURRENT_TIMESTAMP"; - $self->{default_function_def} ||= "TIMESTAMP DEFAULT $self->{default_function}"; + $self->{default_function} ||= "current_timestamp"; + $self->{default_function_def} ||= "timestamp default $self->{default_function}"; $self = bless $self, $class; @@ -78,8 +84,15 @@ sub run_tests { push @connect_info, [ @{$info}{qw/dsn user password connect_info_opts/ } ]; } } + + if ($ENV{SCHEMA_LOADER_TESTS_EXTRA_ONLY}) { + $self->run_only_extra_tests(\@connect_info); + return; + } - plan tests => @connect_info * (174 + ($self->{extra}{count} || 0) + ($self->{data_type_tests}{test_count} || 0)); + my $extra_count = $self->{extra}{count} || 0; + + plan tests => @connect_info * (183 + $extra_count + ($self->{data_type_tests}{test_count} || 0)); foreach my $info_idx (0..$#connect_info) { my $info = $connect_info[$info_idx]; @@ -88,7 +101,7 @@ sub run_tests { $self->create(); - my $schema_class = $self->setup_schema(@$info); + my $schema_class = $self->setup_schema($info); $self->test_schema($schema_class); rmtree $DUMP_DIR @@ -96,22 +109,81 @@ sub run_tests { } } +sub run_only_extra_tests { + my ($self, $connect_info) = @_; + + plan tests => @$connect_info * (4 + ($self->{extra}{count} || 0) + ($self->{data_type_tests}{test_count} || 0)); + + rmtree $DUMP_DIR; + + foreach my $info_idx (0..$#$connect_info) { + my $info = $connect_info->[$info_idx]; + + @{$self}{qw/dsn user password connect_info_opts/} = @$info; + + $self->drop_extra_tables_only; + + my $dbh = $self->dbconnect(1); + $dbh->do($_) for @{ $self->{extra}{create} || [] }; + $dbh->do($_) for @{ $self->{data_type_tests}{ddl} || []}; + $self->{_created} = 1; + + my $file_count = grep /CREATE (?:TABLE|VIEW)/i, @{ $self->{extra}{create} || [] }; + $file_count++; # schema + $file_count++ for @{ $self->{data_type_tests}{table_names} || [] }; + + my $schema_class = $self->setup_schema($info, $file_count); + my ($monikers, $classes) = $self->monikers_and_classes($schema_class); + my $conn = $schema_class->clone; + + $self->test_data_types($conn); + $self->{extra}{run}->($conn, $monikers, $classes) if $self->{extra}{run}; + + if (not ($ENV{SCHEMA_LOADER_TESTS_NOCLEANUP} && $info_idx == $#$connect_info)) { + $self->drop_extra_tables_only; + rmtree $DUMP_DIR; + } + } +} + +sub drop_extra_tables_only { + my $self = shift; + + my $dbh = $self->dbconnect(0); + + $dbh->do($_) for @{ $self->{extra}{pre_drop_ddl} || [] }; + $dbh->do("DROP TABLE $_") for @{ $self->{extra}{drop} || [] }; + + foreach my $data_type_table (@{ $self->{data_type_tests}{table_names} || [] }) { + $dbh->do("DROP TABLE $data_type_table"); + } +} + # defined in sub create my (@statements, @statements_reltests, @statements_advanced, @statements_advanced_sqlite, @statements_inline_rels, @statements_implicit_rels); sub setup_schema { - my $self = shift; - my @connect_info = @_; + my ($self, $connect_info, $expected_count) = @_; my $schema_class = 'DBIXCSL_Test::Schema'; my $debug = ($self->{verbose} > 1) ? 1 : 0; + if ( + $ENV{SCHEMA_LOADER_TESTS_USE_MOOSE} + && + ! DBIx::Class::Schema::Loader::Optional::Dependencies->req_ok_for('use_moose') + ) { + die sprintf ("Missing dependencies for SCHEMA_LOADER_TESTS_USE_MOOSE: %s\n", + DBIx::Class::Schema::Loader::Optional::Dependencies->req_missing_for('use_moose') + ); + } + my %loader_opts = ( constraint => - qr/^(?:\S+\.)?(?:(?:$self->{vendor}|extra)_)?loader_test[0-9]+(?!.*_)/i, + qr/^(?:\S+\.)?(?:(?:$self->{vendor}|extra)_?)?loader_?test[0-9]+(?!.*_)/i, relationships => 1, additional_classes => 'TestAdditional', additional_base_classes => 'TestAdditionalBase', @@ -127,6 +199,7 @@ sub setup_schema { dump_directory => $DUMP_DIR, datetime_timezone => 'Europe/Berlin', datetime_locale => 'de_DE', + use_moose => $ENV{SCHEMA_LOADER_TESTS_USE_MOOSE}, %{ $self->{loader_options} || {} }, ); @@ -135,33 +208,39 @@ sub setup_schema { Class::Unload->unload($schema_class); my $file_count; - my $expected_count = 36 + ($self->{data_type_tests}{test_count} ? 1 : 0); { my @loader_warnings; - local $SIG{__WARN__} = sub { push(@loader_warnings, $_[0]); }; + local $SIG{__WARN__} = sub { push(@loader_warnings, @_); }; eval qq{ package $schema_class; use base qw/DBIx::Class::Schema::Loader/; __PACKAGE__->loader_options(\%loader_opts); - __PACKAGE__->connection(\@connect_info); + __PACKAGE__->connection(\@\$connect_info); }; ok(!$@, "Loader initialization") or diag $@; find sub { return if -d; $file_count++ }, $DUMP_DIR; - - $expected_count += grep /CREATE (?:TABLE|VIEW)/i, - @{ $self->{extra}{create} || [] }; - - $expected_count -= grep /CREATE TABLE/, @statements_inline_rels - if $self->{skip_rels} || $self->{no_inline_rels}; - - $expected_count -= grep /CREATE TABLE/, @statements_implicit_rels - if $self->{skip_rels} || $self->{no_implicit_rels}; - - $expected_count -= grep /CREATE TABLE/, ($self->{vendor} =~ /sqlite/ ? @statements_advanced_sqlite : @statements_advanced), @statements_reltests - if $self->{skip_rels}; + + my $standard_sources = not defined $expected_count; + + if ($standard_sources) { + $expected_count = 36; + $expected_count++ for @{ $self->{data_type_tests}{table_names} || [] }; + + $expected_count += grep /CREATE (?:TABLE|VIEW)/i, + @{ $self->{extra}{create} || [] }; + + $expected_count -= grep /CREATE TABLE/, @statements_inline_rels + if $self->{skip_rels} || $self->{no_inline_rels}; + + $expected_count -= grep /CREATE TABLE/, @statements_implicit_rels + if $self->{skip_rels} || $self->{no_implicit_rels}; + + $expected_count -= grep /CREATE TABLE/, ($self->{vendor} =~ /sqlite/ ? @statements_advanced_sqlite : @statements_advanced), @statements_reltests + if $self->{skip_rels}; + } is $file_count, $expected_count, 'correct number of files generated'; @@ -174,19 +253,30 @@ sub setup_schema { $warn_count++ for grep /\b(?!loader_test9)\w+ has no primary key/i, @loader_warnings; - if($self->{skip_rels}) { - SKIP: { - is(scalar(@loader_warnings), $warn_count, "No loader warnings") + $warn_count++ for grep { my $w = $_; grep $w =~ $_, @{ $self->{warnings} || [] } } @loader_warnings; + + if ($standard_sources) { + if($self->{skip_rels}) { + SKIP: { + is(scalar(@loader_warnings), $warn_count, "No loader warnings") + or diag @loader_warnings; + skip "No missing PK warnings without rels", 1; + } + } + else { + $warn_count++; + is(scalar(@loader_warnings), $warn_count, "Expected loader warning") or diag @loader_warnings; - skip "No missing PK warnings without rels", 1; + is(grep(/loader_test9 has no primary key/i, @loader_warnings), 1, + "Missing PK warning"); } } else { - $warn_count++; - is(scalar(@loader_warnings), $warn_count, "Expected loader warning") - or diag @loader_warnings; - is(grep(/loader_test9 has no primary key/i, @loader_warnings), 1, - "Missing PK warning"); + SKIP: { + is scalar(@loader_warnings), $warn_count, 'Correct number of warnings' + or diag @loader_warnings; + skip "not testing standard sources", 1; + } } } @@ -203,20 +293,7 @@ sub test_schema { ($self->{before_tests_run} || sub {})->($conn); - my $monikers = {}; - my $classes = {}; - foreach my $source_name ($schema_class->sources) { - my $table_name = $schema_class->source($source_name)->from; - - $table_name = $$table_name if ref $table_name; - - $monikers->{$table_name} = $source_name; - $classes->{$table_name} = $schema_class . q{::} . $source_name; - - # some DBs (Firebird) uppercase everything - $monikers->{lc $table_name} = $source_name; - $classes->{lc $table_name} = $schema_class . q{::} . $source_name; - } + my ($monikers, $classes) = $self->monikers_and_classes($schema_class); my $moniker1 = $monikers->{loader_test1s}; my $class1 = $classes->{loader_test1s}; @@ -228,8 +305,8 @@ sub test_schema { my $rsobj2 = $conn->resultset($moniker2); check_no_duplicate_unique_constraints($class2); - my $moniker23 = $monikers->{LOADER_TEST23} || $monikers->{loader_test23}; - my $class23 = $classes->{LOADER_TEST23} || $classes->{loader_test23}; + my $moniker23 = $monikers->{LOADER_test23} || $monikers->{loader_test23}; + my $class23 = $classes->{LOADER_test23} || $classes->{loader_test23}; my $rsobj23 = $conn->resultset($moniker1); my $moniker24 = $monikers->{LoAdEr_test24} || $monikers->{loader_test24}; @@ -247,7 +324,19 @@ sub test_schema { isa_ok( $rsobj35, "DBIx::Class::ResultSet" ); my @columns_lt2 = $class2->columns; - is_deeply( \@columns_lt2, [ qw/id dat dat2/ ], "Column Ordering" ); + is_deeply( \@columns_lt2, [ qw/id dat dat2 set_primary_key can dbix_class_testcomponent meta/ ], "Column Ordering" ); + + is $class2->column_info('can')->{accessor}, undef, + 'accessor for column name that conflicts with a UNIVERSAL method removed'; + + is $class2->column_info('set_primary_key')->{accessor}, undef, + 'accessor for column name that conflicts with a result base class method removed'; + + is $class2->column_info('dbix_class_testcomponent')->{accessor}, undef, + 'accessor for column name that conflicts with a component class method removed'; + + is $class2->column_info('meta')->{accessor}, undef, + 'accessor for column name that conflicts with Moose removed'; my %uniq1 = $class1->unique_constraints; my $uniq1_test = 0; @@ -359,10 +448,20 @@ sub test_schema { ); is( - $class35->column_info('a_double')->{default_value}, 10.555, + $class35->column_info('a_negative_int')->{default_value}, -42, + 'constant negative integer default', + ); + + cmp_ok( + $class35->column_info('a_double')->{default_value}, '==', 10.555, 'constant numeric default', ); + cmp_ok( + $class35->column_info('a_negative_double')->{default_value}, '==', -10.555, + 'constant negative numeric default', + ); + my $function_default = $class35->column_info('a_function')->{default_value}; isa_ok( $function_default, 'SCALAR', 'default_value for function default' ); @@ -559,12 +658,14 @@ sub test_schema { 'might_have does not have is_deferrable'); # find on multi-col pk - my $obj5 = - eval { $rsobj5->find({id1 => 1, iD2 => 1}) } || - eval { $rsobj5->find({id1 => 1, id2 => 1}) }; - die $@ if $@; - - is( $obj5->id2, 1, "Find on multi-col PK" ); + if ($conn->_loader->preserve_case) { + my $obj5 = $rsobj5->find({id1 => 1, iD2 => 1}); + is $obj5->i_d2, 1, 'Find on multi-col PK'; + } + else { + my $obj5 = $rsobj5->find({id1 => 1, id2 => 1}); + is $obj5->id2, 1, 'Find on multi-col PK'; + } # mulit-col fk def my $obj6 = $rsobj6->find(1); @@ -791,7 +892,7 @@ sub test_schema { } # rescan and norewrite test - SKIP: { + { my @statements_rescan = ( qq{ CREATE TABLE loader_test30 ( @@ -809,7 +910,7 @@ sub test_schema { my $find_cb = sub { return if -d; - return if $_ eq 'LoaderTest30.pm'; + return if /^(?:LoaderTest30|LoaderTest1|LoaderTest2X)\.pm\z/; open my $fh, '<', $_ or die "Could not open $_ for reading: $!"; binmode $fh; @@ -818,35 +919,31 @@ sub test_schema { find $find_cb, $DUMP_DIR; - my $before_digest = $digest->digest; - - my $dbh = $self->dbconnect(1); - - { - # Silence annoying but harmless postgres "NOTICE: CREATE TABLE..." - local $SIG{__WARN__} = sub { - my $msg = shift; - print STDERR $msg unless $msg =~ m{^NOTICE:\s+CREATE TABLE}; - }; +# system "rm -f /tmp/before_rescan/* /tmp/after_rescan/*"; +# system "cp $tdir/common_dump/DBIXCSL_Test/Schema/*.pm /tmp/before_rescan"; - $dbh->do($_) for @statements_rescan; - } + my $before_digest = $digest->b64digest; + $conn->storage->disconnect; # needed for Firebird and Informix + my $dbh = $self->dbconnect(1); + $dbh->do($_) for @statements_rescan; $dbh->disconnect; - $conn->storage->disconnect; # needed for Firebird sleep 1; my @new = do { - # kill the 'Dumping manual schema' warnings - local $SIG{__WARN__} = sub {}; + local $SIG{__WARN__} = sub { warn @_ + unless $_[0] =~ /(?i:loader_test)\d+ has no primary key|^Dumping manual schema|^Schema dump completed/ + }; $conn->rescan; }; is_deeply(\@new, [ qw/LoaderTest30/ ], "Rescan"); +# system "cp t/_common_dump/DBIXCSL_Test/Schema/*.pm /tmp/after_rescan"; + $digest = Digest::MD5->new; find $find_cb, $DUMP_DIR; - my $after_digest = $digest->digest; + my $after_digest = $digest->b64digest; is $before_digest, $after_digest, 'dumped files are not rewritten when there is no modification'; @@ -854,51 +951,135 @@ sub test_schema { my $rsobj30 = $conn->resultset('LoaderTest30'); isa_ok($rsobj30, 'DBIx::Class::ResultSet'); - skip 'no rels', 2 if $self->{skip_rels}; + SKIP: { + skip 'no rels', 2 if $self->{skip_rels}; + + my $obj30 = $rsobj30->find(123); + isa_ok( $obj30->loader_test2, $class2); + + ok($rsobj30->result_source->column_info('loader_test2')->{is_foreign_key}, + 'Foreign key detected'); + } - my $obj30 = $rsobj30->find(123); - isa_ok( $obj30->loader_test2, $class2); + $conn->storage->disconnect; # for Firebird + $conn->storage->dbh->do("DROP TABLE loader_test30"); - ok($rsobj30->result_source->column_info('loader_test2')->{is_foreign_key}, - 'Foreign key detected'); + @new = do { + local $SIG{__WARN__} = sub { warn @_ + unless $_[0] =~ /(?i:loader_test)\d+ has no primary key|^Dumping manual schema|^Schema dump completed/ + }; + $conn->rescan; + }; + is_deeply(\@new, [], 'no new tables on rescan'); + + throws_ok { $conn->resultset('LoaderTest30') } + qr/Can't find source/, + 'source unregistered for dropped table after rescan'; } - # test data types + $self->test_data_types($conn); + + # run extra tests + $self->{extra}{run}->($conn, $monikers, $classes) if $self->{extra}{run}; + + $self->test_preserve_case($conn); + + $self->drop_tables unless $ENV{SCHEMA_LOADER_TESTS_NOCLEANUP}; + + $conn->storage->disconnect; +} + +sub test_data_types { + my ($self, $conn) = @_; + if ($self->{data_type_tests}{test_count}) { my $data_type_tests = $self->{data_type_tests}; - my $columns = $data_type_tests->{columns}; - my $rsrc = $conn->resultset($data_type_tests->{table_moniker})->result_source; + foreach my $moniker (@{ $data_type_tests->{table_monikers} }) { + my $columns = $data_type_tests->{columns}{$moniker}; - while (my ($col_name, $expected_info) = each %$columns) { - my %info = %{ $rsrc->column_info($col_name) }; - delete @info{qw/is_nullable timezone locale sequence/}; + my $rsrc = $conn->resultset($moniker)->result_source; - my $text_col_def = do { - my $dd = Dumper; - $dd->Indent(0); - $dd->Values([\%info]); - $dd->Dump; - }; + while (my ($col_name, $expected_info) = each %$columns) { + my %info = %{ $rsrc->column_info($col_name) }; + delete @info{qw/is_nullable timezone locale sequence/}; - my $text_expected_info = do { - my $dd = Dumper; - $dd->Indent(0); - $dd->Values([$expected_info]); - $dd->Dump; - }; + my $text_col_def = dumper_squashed \%info; - is_deeply \%info, $expected_info, - "test column $col_name has definition: $text_col_def expecting: $text_expected_info"; + my $text_expected_info = dumper_squashed $expected_info; + + is_deeply \%info, $expected_info, + "test column $col_name has definition: $text_col_def expecting: $text_expected_info"; + } } } +} - # run extra tests - $self->{extra}{run}->($conn, $monikers, $classes) if $self->{extra}{run}; +sub test_preserve_case { + my ($self, $conn) = @_; + + my ($oqt, $cqt) = $self->get_oqt_cqt(always => 1); # open quote, close quote + + my $dbh = $self->dbconnect; + + $dbh->do($_) for ( +qq| + CREATE TABLE ${oqt}LoaderTest40${cqt} ( + ${oqt}Id${cqt} INTEGER NOT NULL PRIMARY KEY, + ${oqt}Foo3Bar${cqt} VARCHAR(100) NOT NULL + ) $self->{innodb} +|, +qq| + CREATE TABLE ${oqt}LoaderTest41${cqt} ( + ${oqt}Id${cqt} INTEGER NOT NULL PRIMARY KEY, + ${oqt}LoaderTest40Id${cqt} INTEGER, + FOREIGN KEY (${oqt}LoaderTest40Id${cqt}) REFERENCES ${oqt}LoaderTest40${cqt} (${oqt}Id${cqt}) + ) $self->{innodb} +|, +qq| INSERT INTO ${oqt}LoaderTest40${cqt} VALUES (1, 'foo') |, +qq| INSERT INTO ${oqt}LoaderTest41${cqt} VALUES (1, 1) |, + ); + $conn->storage->disconnect; - $self->drop_tables unless $ENV{SCHEMA_LOADER_TESTS_NOCLEANUP}; + local $conn->_loader->{preserve_case} = 1; + $conn->_loader->_setup; - $conn->storage->disconnect; + + { + local $SIG{__WARN__} = sub { warn @_ + unless $_[0] =~ /(?i:loader_test)\d+ has no primary key|^Dumping manual schema|^Schema dump completed/ + }; + $conn->rescan; + }; + + if (not $self->{skip_rels}) { + is $conn->resultset('LoaderTest41')->find(1)->loader_test40->foo3_bar, 'foo', + 'rel and accessor for mixed-case column name in mixed case table'; + } + else { + is $conn->resultset('LoaderTest40')->find(1)->foo3_bar, 'foo', + 'accessor for mixed-case column name in mixed case table'; + } +} + +sub monikers_and_classes { + my ($self, $schema_class) = @_; + my ($monikers, $classes); + + foreach my $source_name ($schema_class->sources) { + my $table_name = $schema_class->source($source_name)->from; + + $table_name = $$table_name if ref $table_name; + + $monikers->{$table_name} = $source_name; + $classes->{$table_name} = $schema_class . q{::} . $source_name; + + # some DBs (Firebird) uppercase everything + $monikers->{lc $table_name} = $source_name; + $classes->{lc $table_name} = $schema_class . q{::} . $source_name; + } + + return ($monikers, $classes); } sub check_no_duplicate_unique_constraints { @@ -941,11 +1122,33 @@ sub dbconnect { return $dbh; } +sub get_oqt_cqt { + my $self = shift; + my %opts = @_; + + if ((not $opts{always}) && $self->{preserve_case_mode_is_exclusive}) { + return ('', ''); + } + + # XXX should get quote_char from the storage of an initialized loader. + my ($oqt, $cqt); # open quote, close quote + if (ref $self->{quote_char}) { + ($oqt, $cqt) = @{ $self->{quote_char} }; + } + else { + $oqt = $cqt = $self->{quote_char} || ''; + } + + return ($oqt, $cqt); +} + sub create { my $self = shift; $self->{_created} = 1; + $self->drop_tables; + my $make_auto_inc = $self->{auto_inc_cb} || sub {}; @statements = ( qq{ @@ -960,11 +1163,16 @@ sub create { q{ INSERT INTO loader_test1s (dat) VALUES('bar') }, q{ INSERT INTO loader_test1s (dat) VALUES('baz') }, + # also test method collision qq{ CREATE TABLE loader_test2 ( id $self->{auto_inc_pk}, dat VARCHAR(32) NOT NULL, dat2 VARCHAR(32) NOT NULL, + set_primary_key INTEGER $self->{null}, + can INTEGER $self->{null}, + dbix_class_testcomponent INTEGER $self->{null}, + meta INTEGER $self->{null}, UNIQUE (dat2, dat) ) $self->{innodb} }, @@ -976,7 +1184,7 @@ sub create { q{ INSERT INTO loader_test2 (dat, dat2) VALUES('ddd', 'www') }, qq{ - CREATE TABLE LOADER_TEST23 ( + CREATE TABLE LOADER_test23 ( ID INTEGER NOT NULL PRIMARY KEY, DAT VARCHAR(32) NOT NULL UNIQUE ) $self->{innodb} @@ -994,7 +1202,9 @@ sub create { id INTEGER NOT NULL PRIMARY KEY, a_varchar VARCHAR(100) DEFAULT 'foo', an_int INTEGER DEFAULT 42, + a_negative_int INTEGER DEFAULT -42, a_double DOUBLE PRECISION DEFAULT 10.555, + a_negative_double DOUBLE PRECISION DEFAULT -10.555, a_function $self->{default_function_def} ) $self->{innodb} }, @@ -1002,13 +1212,16 @@ sub create { qq{ CREATE TABLE loader_test36 ( id INTEGER NOT NULL PRIMARY KEY, - a_date $self->{date_datatype}, + a_date $self->{basic_date_datatype}, b_char_as_data VARCHAR(100), c_char_as_data VARCHAR(100) ) $self->{innodb} }, ); + # some DBs require mixed case identifiers to be quoted + my ($oqt, $cqt) = $self->get_oqt_cqt; + @statements_reltests = ( qq{ CREATE TABLE loader_test3 ( @@ -1036,33 +1249,33 @@ sub create { q{ INSERT INTO loader_test4 (id,fkid,dat) VALUES(125,3,'ccc') }, q{ INSERT INTO loader_test4 (id,fkid,dat) VALUES(126,4,'ddd') }, - qq{ + qq| CREATE TABLE loader_test5 ( id1 INTEGER NOT NULL, - iD2 INTEGER NOT NULL, + ${oqt}iD2${cqt} INTEGER NOT NULL, dat VARCHAR(8), from_id INTEGER $self->{null}, to_id INTEGER $self->{null}, - PRIMARY KEY (id1,iD2), + PRIMARY KEY (id1,${oqt}iD2${cqt}), FOREIGN KEY (from_id) REFERENCES loader_test4 (id), FOREIGN KEY (to_id) REFERENCES loader_test4 (id) ) $self->{innodb} - }, + |, - q{ INSERT INTO loader_test5 (id1,iD2,dat) VALUES (1,1,'aaa') }, + qq| INSERT INTO loader_test5 (id1,${oqt}iD2${cqt},dat) VALUES (1,1,'aaa') |, - qq{ + qq| CREATE TABLE loader_test6 ( id INTEGER NOT NULL PRIMARY KEY, - Id2 INTEGER, + ${oqt}Id2${cqt} INTEGER, loader_test2_id INTEGER, dat VARCHAR(8), FOREIGN KEY (loader_test2_id) REFERENCES loader_test2 (id), - FOREIGN KEY(id,Id2) REFERENCES loader_test5 (id1,iD2) + FOREIGN KEY(id,${oqt}Id2${cqt}) REFERENCES loader_test5 (id1,${oqt}iD2${cqt}) ) $self->{innodb} - }, + |, - (q{ INSERT INTO loader_test6 (id, Id2,loader_test2_id,dat) } . + (qq| INSERT INTO loader_test6 (id, ${oqt}Id2${cqt},loader_test2_id,dat) | . q{ VALUES (1, 1,1,'aaa') }), qq{ @@ -1292,9 +1505,16 @@ sub create { }, $make_auto_inc->(qw/loader_test11 id11/), - (q{ ALTER TABLE loader_test10 ADD CONSTRAINT } . - q{ loader_test11_fk FOREIGN KEY (loader_test11) } . - q{ REFERENCES loader_test11 (id11) }), + (lc($self->{vendor}) ne 'informix' ? + (q{ ALTER TABLE loader_test10 ADD CONSTRAINT loader_test11_fk } . + q{ FOREIGN KEY (loader_test11) } . + q{ REFERENCES loader_test11 (id11) }) + : + (q{ ALTER TABLE loader_test10 ADD CONSTRAINT } . + q{ FOREIGN KEY (loader_test11) } . + q{ REFERENCES loader_test11 (id11) } . + q{ CONSTRAINT loader_test11_fk }) + ), ); @statements_advanced_sqlite = ( @@ -1369,15 +1589,11 @@ sub create { my $dbh = $self->dbconnect(1); - # Silence annoying but harmless postgres "NOTICE: CREATE TABLE..." - local $SIG{__WARN__} = sub { - my $msg = shift; - print STDERR $msg unless $msg =~ m{^NOTICE:\s+CREATE TABLE}; - }; + $dbh->do($_) for @{ $self->{pre_create} || [] }; - $dbh->do($_) for (@statements); + $dbh->do($_) foreach (@statements); - $dbh->do($self->{data_type_tests}{ddl}) if $self->{data_type_tests}{ddl}; + $dbh->do($_) foreach (@{ $self->{data_type_tests}{ddl} || [] }); unless($self->{skip_rels}) { # hack for now, since DB2 doesn't like inline comments, and we need @@ -1406,9 +1622,10 @@ sub drop_tables { my $self = shift; my @tables = qw/ + loader_test1 loader_test1s loader_test2 - LOADER_TEST23 + LOADER_test23 LoAdEr_test24 loader_test35 loader_test36 @@ -1467,20 +1684,27 @@ sub drop_tables { my @tables_rescan = qw/ loader_test30 /; + my @tables_preserve_case_tests = qw/ LoaderTest41 LoaderTest40 /; + my $drop_fk_mysql = q{ALTER TABLE loader_test10 DROP FOREIGN KEY loader_test11_fk}; my $drop_fk = q{ALTER TABLE loader_test10 DROP CONSTRAINT loader_test11_fk}; - my $dbh = $self->dbconnect(0); + # For some reason some tests do this twice (I guess dependency issues?) + # do it twice for all drops + for (1,2) { + my $dbh = $self->dbconnect(0); - $dbh->do($_) for @{ $self->{extra}{pre_drop_ddl} || [] }; - $dbh->do("DROP TABLE $_") for @{ $self->{extra}{drop} || [] }; + $dbh->do($_) for @{ $self->{extra}{pre_drop_ddl} || [] }; - my $drop_auto_inc = $self->{auto_inc_drop_cb} || sub {}; + $dbh->do("DROP TABLE $_") for @{ $self->{extra}{drop} || [] }; - unless($self->{skip_rels}) { + my $drop_auto_inc = $self->{auto_inc_drop_cb} || sub {}; + + unless($self->{skip_rels}) { + $dbh->do("DROP TABLE $_") for (@tables_reltests); $dbh->do("DROP TABLE $_") for (@tables_reltests); if($self->{vendor} =~ /mysql/i) { $dbh->do($drop_fk_mysql); @@ -1497,20 +1721,20 @@ sub drop_tables { unless($self->{no_implicit_rels}) { $dbh->do("DROP TABLE $_") for (@tables_implicit_rels); } - } - $dbh->do($_) for map { $drop_auto_inc->(@$_) } @tables_auto_inc; - $dbh->do("DROP TABLE $_") for (@tables, @tables_rescan); + } + $dbh->do($_) for map { $drop_auto_inc->(@$_) } @tables_auto_inc; + $dbh->do("DROP TABLE $_") for (@tables, @tables_rescan); - if (my $data_type_table = $self->{data_type_tests}{table_name}) { + foreach my $data_type_table (@{ $self->{data_type_tests}{table_names} || [] }) { $dbh->do("DROP TABLE $data_type_table"); - } + } - $dbh->disconnect; + my ($oqt, $cqt) = $self->get_oqt_cqt(always => 1); -# fixup for Firebird - $dbh = $self->dbconnect(0); - $dbh->do('DROP TABLE loader_test2'); - $dbh->disconnect; + $dbh->do("DROP TABLE ${oqt}${_}${cqt}") for @tables_preserve_case_tests; + + $dbh->disconnect; + } } sub _custom_column_info { @@ -1536,43 +1760,95 @@ sub _custom_column_info { return; } +my %DATA_TYPE_MULTI_TABLE_OVERRIDES = ( + oracle => qr/\blong\b/i, + mssql => qr/\b(?:timestamp|rowversion)\b/i, + informix => qr/\b(?:bigserial|serial8)\b/i, +); + sub setup_data_type_tests { my $self = shift; return unless my $types = $self->{data_types}; my $tests = $self->{data_type_tests} = {}; - my $cols = $tests->{columns} = {}; - $tests->{table_name} = 'loader_test9999'; - $tests->{table_moniker} = 'LoaderTest9999'; + # split types into tables based on overrides + my (@types, @split_off_types, @first_table_types); + { + my $split_off_re = $DATA_TYPE_MULTI_TABLE_OVERRIDES{lc($self->{vendor})} || qr/(?!)/; + + @types = keys %$types; + @split_off_types = grep /$split_off_re/, @types; + @first_table_types = grep !/$split_off_re/, @types; + } - my $ddl = "CREATE TABLE loader_test9999 (\n id INTEGER NOT NULL PRIMARY KEY,\n"; + @types = +{ map +($_, $types->{$_}), @first_table_types }, + map +{ $_, $types->{$_} }, @split_off_types; my $test_count = 0; + my $table_num = 10000; - my %seen_col_names; + foreach my $types (@types) { + my $table_name = "loader_test$table_num"; + push @{ $tests->{table_names} }, $table_name; - while (my ($col_def, $expected_info) = each %$types) { - my $have_size = $col_def =~ /\(/ ? 1 : 0; + my $table_moniker = "LoaderTest$table_num"; + push @{ $tests->{table_monikers} }, $table_moniker; - (my $type_alias = $col_def) =~ s/\([^()]+\)//g; - $type_alias =~ s/\s/_/g; + $table_num++; - my $col_name = $type_alias . ($have_size ? '_with_size' : ''); + my $cols = $tests->{columns}{$table_moniker} = {}; - $col_name .= $seen_col_names{$col_name} if $seen_col_names{$col_name}++; + my $ddl = "CREATE TABLE $table_name (\n id INTEGER NOT NULL PRIMARY KEY,\n"; - $ddl .= " $col_name $col_def,\n"; + my %seen_col_names; - $cols->{$col_name} = $expected_info; + while (my ($col_def, $expected_info) = each %$types) { + (my $type_alias = $col_def) =~ s/\( ([^)]+) \)//xg; - $test_count++; - } + my $size = $1; + $size = '' unless defined $size; + $size =~ s/\s+//g; + my @size = split /,/, $size; + + # some DBs don't like very long column names + if ($self->{vendor} =~ /^(?:firebird|sqlanywhere|oracle|db2)\z/i) { + my ($col_def, $default) = $type_alias =~ /^(.*)(default.*)?\z/i; + + $type_alias = substr $col_def, 0, 15; + + $type_alias .= '_with_dflt' if $default; + } + + $type_alias =~ s/\s/_/g; + $type_alias =~ s/\W//g; - $ddl =~ s/,\n\z/\n)/; + my $col_name = 'col_' . $type_alias; + + if (@size) { + my $size_name = join '_', apply { s/\W//g } @size; + + $col_name .= "_sz_$size_name"; + } + + # XXX would be better to check _loader->preserve_case + $col_name = lc $col_name; + + $col_name .= '_' . $seen_col_names{$col_name} if $seen_col_names{$col_name}++; + + $ddl .= " $col_name $col_def,\n"; + + $cols->{$col_name} = $expected_info; + + $test_count++; + } + + $ddl =~ s/,\n\z/\n)/; + + push @{ $tests->{ddl} }, $ddl; + } - $tests->{ddl} = $ddl; $tests->{test_count} = $test_count; return $test_count; @@ -1581,8 +1857,8 @@ sub setup_data_type_tests { sub DESTROY { my $self = shift; unless ($ENV{SCHEMA_LOADER_TESTS_NOCLEANUP}) { - $self->drop_tables if $self->{_created}; - rmtree $DUMP_DIR + $self->drop_tables if $self->{_created}; + rmtree $DUMP_DIR } }