X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits%2FDBIx-Class-Schema-Loader.git;a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FSchema%2FLoader%2FDBI%2FPg.pm;h=317a07dd8514630ff64f2c05eb857130841d9dff;hp=8fe2f6bf076fa1ed118ce1e935e1ab38f6f29582;hb=afa71a988919e114101e41f0241b08ffc2f436f5;hpb=9633664658e5795fbf70d7e89456910a8481526f diff --git a/lib/DBIx/Class/Schema/Loader/DBI/Pg.pm b/lib/DBIx/Class/Schema/Loader/DBI/Pg.pm index 8fe2f6b..317a07d 100644 --- a/lib/DBIx/Class/Schema/Loader/DBI/Pg.pm +++ b/lib/DBIx/Class/Schema/Loader/DBI/Pg.pm @@ -2,13 +2,10 @@ package DBIx::Class::Schema::Loader::DBI::Pg; use strict; use warnings; -use base qw/ - DBIx::Class::Schema::Loader::DBI::Component::QuotedDefault - DBIx::Class::Schema::Loader::DBI -/; +use base 'DBIx::Class::Schema::Loader::DBI::Component::QuotedDefault'; use mro 'c3'; -our $VERSION = '0.07010'; +our $VERSION = '0.07048_01'; =head1 NAME @@ -43,6 +40,67 @@ sub _system_schemas { return ($self->next::method(@_), 'pg_catalog'); } +my %pg_rules = ( + a => 'NO ACTION', + r => 'RESTRICT', + c => 'CASCADE', + n => 'SET NULL', + d => 'SET DEFAULT', +); + +sub _table_fk_info { + my ($self, $table) = @_; + + my $sth = $self->dbh->prepare_cached(<<"EOF"); + select constr.conname, to_ns.nspname, to_class.relname, from_col.attname, to_col.attname, + constr.confdeltype, constr.confupdtype, constr.condeferrable + from pg_catalog.pg_constraint constr + join pg_catalog.pg_namespace from_ns on constr.connamespace = from_ns.oid + join pg_catalog.pg_class from_class on constr.conrelid = from_class.oid and from_class.relnamespace = from_ns.oid + join pg_catalog.pg_class to_class on constr.confrelid = to_class.oid + join pg_catalog.pg_namespace to_ns on to_class.relnamespace = to_ns.oid + -- can't do unnest() until 8.4, so join against a series table instead + join pg_catalog.generate_series(1, pg_catalog.current_setting('max_index_keys')::integer) colnum(i) + on colnum.i <= pg_catalog.array_upper(constr.conkey,1) + join pg_catalog.pg_attribute to_col + on to_col.attrelid = constr.confrelid + and to_col.attnum = constr.confkey[colnum.i] + join pg_catalog.pg_attribute from_col + on from_col.attrelid = constr.conrelid + and from_col.attnum = constr.conkey[colnum.i] + where from_ns.nspname = ? + and from_class.relname = ? + and from_class.relkind = 'r' + and constr.contype = 'f' + order by constr.conname, colnum.i +EOF + + $sth->execute($table->schema, $table->name); + + my %rels; + + while (my ($fk, $remote_schema, $remote_table, $col, $remote_col, + $delete_rule, $update_rule, $is_deferrable) = $sth->fetchrow_array) { + push @{ $rels{$fk}{local_columns} }, $self->_lc($col); + push @{ $rels{$fk}{remote_columns} }, $self->_lc($remote_col); + + $rels{$fk}{remote_table} = DBIx::Class::Schema::Loader::Table->new( + loader => $self, + name => $remote_table, + schema => $remote_schema, + ) unless exists $rels{$fk}{remote_table}; + + $rels{$fk}{attrs} ||= { + on_delete => $pg_rules{$delete_rule}, + on_update => $pg_rules{$update_rule}, + is_deferrable => $is_deferrable, + }; + } + + return [ map { $rels{$_} } sort keys %rels ]; +} + + sub _table_uniq_info { my ($self, $table) = @_; @@ -67,18 +125,18 @@ sub _table_uniq_info { pg_catalog.pg_index x JOIN pg_catalog.pg_class c ON c.oid = x.indrelid JOIN pg_catalog.pg_class i ON i.oid = x.indexrelid - JOIN pg_catalog.pg_constraint con ON con.conname = i.relname - LEFT JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace + JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace WHERE x.indisunique = 't' AND + x.indpred IS NULL AND c.relkind = 'r' AND i.relkind = 'i' AND - con.contype = 'u' AND n.nspname = ? AND - c.relname = ?} + c.relname = ? + ORDER BY i.relname} ); - $uniq_sth->execute($table->schema, $table); + $uniq_sth->execute($table->schema, $table->name); while(my $row = $uniq_sth->fetchrow_arrayref) { my ($tableid, $indexname, $col_nums) = @$row; $col_nums =~ s/^\s+//; @@ -88,13 +146,11 @@ sub _table_uniq_info { foreach (@col_nums) { $attr_sth->execute($tableid, $_); my $name_aref = $attr_sth->fetchrow_arrayref; - push(@col_names, $name_aref->[0]) if $name_aref; + push(@col_names, $self->_lc($name_aref->[0])) if $name_aref; } - if(!@col_names) { - warn "Failed to parse UNIQUE constraint $indexname on $table"; - } - else { + # skip indexes with missing column names (e.g. expression indexes) + if(@col_names == @col_nums) { push(@uniqs, [ $indexname => \@col_names ]); } } @@ -111,9 +167,9 @@ sub _table_comment { return $table_comment if $table_comment; ($table_comment) = $self->dbh->selectrow_array(<<'EOF', {}, $table->name, $table->schema); -SELECT obj_description(oid) -FROM pg_class -WHERE relname=? AND relnamespace=(SELECT oid FROM pg_namespace WHERE nspname=?) +SELECT pg_catalog.obj_description(oid) +FROM pg_catalog.pg_class +WHERE relname=? AND relnamespace=(SELECT oid FROM pg_catalog.pg_namespace WHERE nspname=?) EOF return $table_comment @@ -128,13 +184,11 @@ sub _column_comment { return $column_comment if $column_comment; - my ($table_oid) = $self->dbh->selectrow_array(<<'EOF', {}, $table->name, $table->schema); -SELECT oid -FROM pg_class -WHERE relname=? AND relnamespace=(SELECT oid FROM pg_namespace WHERE nspname=?) + return $self->dbh->selectrow_array(<<'EOF', {}, $column_number, $table->name, $table->schema); +SELECT pg_catalog.col_description(oid, ?) +FROM pg_catalog.pg_class +WHERE relname=? AND relnamespace=(SELECT oid FROM pg_catalog.pg_namespace WHERE nspname=?) EOF - - return $self->dbh->selectrow_array('SELECT col_description(?,?)', {}, $table_oid, $column_number); } # Make sure data_type's that don't need it don't have a 'size' column_info, and @@ -143,7 +197,7 @@ sub _columns_info_for { my $self = shift; my ($table) = @_; - my $result = $self->next::method(@_); + my ($result, $raw) = $self->next::method(@_); while (my ($col, $info) = each %$result) { my $data_type = $info->{data_type}; @@ -164,14 +218,14 @@ sub _columns_info_for { } my ($precision) = $self->schema->storage->dbh - ->selectrow_array(<selectrow_array(<name, $col); SELECT datetime_precision FROM information_schema.columns WHERE table_name = ? and column_name = ? EOF if ($data_type =~ /^time\b/i) { - if ((not $precision) || $precision !~ /^\d/) { + if ((not defined $precision) || $precision !~ /^\d/) { delete $info->{size}; } else { @@ -189,7 +243,7 @@ EOF } } } - elsif ((not $precision) || $precision !~ /^\d/ || $precision == 6) { + elsif ((not defined $precision) || $precision !~ /^\d/ || $precision == 6) { delete $info->{size}; } else { @@ -199,7 +253,7 @@ EOF elsif ($data_type =~ /^(?:bit(?: varying)?|varbit)\z/i) { $info->{data_type} = 'varbit' if $data_type =~ /var/i; - my ($precision) = $self->dbh->selectrow_array(<dbh->selectrow_array(<name, $col); SELECT character_maximum_length FROM information_schema.columns WHERE table_name = ? and column_name = ? @@ -227,53 +281,70 @@ EOF elsif (lc($data_type) eq 'character') { $info->{data_type} = 'char'; } - else { + # DBD::Pg < 3.5.2 can get the order wrong on Pg >= 9.1.0 + elsif ( + ($DBD::Pg::VERSION >= 3.005002 or $self->dbh->{pg_server_version} < 90100) + and + my $values = $raw->{$col}->{pg_enum_values} + ) { + $info->{extra}{list} = $values; + + # Store its original name in extra for SQLT to pick up. + $info->{extra}{custom_type_name} = $info->{data_type}; + + $info->{data_type} = 'enum'; + + delete $info->{size}; + } + else { my ($typetype) = $self->schema->storage->dbh ->selectrow_array(<dbh - ->selectall_arrayref(<{data_type}); + # The following will extract a list of allowed values for the enum. + my $order_column = $self->dbh->{pg_server_version} >= 90100 ? 'enumsortorder' : 'oid'; + $info->{extra}{list} = $self->dbh + ->selectcol_arrayref(<{extra}{list} = [ map { $_->[0] } @$typevalues ]; - # Store its original name in extra for SQLT to pick up. - $info->{extra}{custom_type_name} = $info->{data_type}; + $info->{extra}{custom_type_name} = $data_type; $info->{data_type} = 'enum'; - + delete $info->{size}; } } -# process SERIAL columns - if (ref($info->{default_value}) eq 'SCALAR' - && ${ $info->{default_value} } =~ /\bnextval\('([^:]+)'/i) { - $info->{is_auto_increment} = 1; - $info->{sequence} = $1; - delete $info->{default_value}; - } - -# alias now() to current_timestamp for deploying to other DBs - if ((eval { lc ${ $info->{default_value} } }||'') eq 'now()') { - # do not use a ref to a constant, that breaks Data::Dump output - ${$info->{default_value}} = 'current_timestamp'; + if (ref($info->{default_value}) eq 'SCALAR') { + # process SERIAL columns + if (${ $info->{default_value} } =~ /\bnextval\('([^:]+)'/i) { + $info->{is_auto_increment} = 1; + $info->{sequence} = $1; + delete $info->{default_value}; + } + # alias now() to current_timestamp for deploying to other DBs + elsif (lc ${ $info->{default_value} } eq 'now()') { + # do not use a ref to a constant, that breaks Data::Dump output + ${$info->{default_value}} = 'current_timestamp'; - my $now = 'now()'; - $info->{original}{default_value} = \$now; + my $now = 'now()'; + $info->{original}{default_value} = \$now; + } + elsif (${ $info->{default_value} } =~ /\bCURRENT_TIMESTAMP\b/) { + # PostgreSQL v10 upcases current_timestamp in default values + ${ $info->{default_value} } =~ s/\b(CURRENT_TIMESTAMP)\b/lc $1/ge; + } } -# detect 0/1 for booleans and rewrite + # detect 0/1 for booleans and rewrite if ($data_type =~ /^bool/i && exists $info->{default_value}) { if ($info->{default_value} eq '0') { my $false = 'false'; @@ -289,14 +360,30 @@ EOF return $result; } +sub _view_definition { + my ($self, $view) = @_; + + my $def = $self->schema->storage->dbh->selectrow_array(<<'EOF', {}, $view->schema, $view->name); +SELECT pg_catalog.pg_get_viewdef(oid) +FROM pg_catalog.pg_class +WHERE relnamespace = (SELECT OID FROM pg_catalog.pg_namespace WHERE nspname = ?) +AND relname = ? +EOF + # The definition is returned as a complete statement including the + # trailing semicolon, but that's not allowed in CREATE VIEW, so + # strip it out + $def =~ s/\s*;\s*\z//; + return $def; +} + =head1 SEE ALSO L, L, L -=head1 AUTHOR +=head1 AUTHORS -See L and L. +See L. =head1 LICENSE