From: Masahiro Chiba Date: Sun, 13 Dec 2009 03:44:04 +0000 (+0900) Subject: s/check/validate/ X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FWeb-Session.git;a=commitdiff_plain;h=6a695f07fa3deb2b54d866dd41f141ad27fa4c65 s/check/validate/ --- diff --git a/lib/Plack/Session/State.pm b/lib/Plack/Session/State.pm index d8fe1db..8e196f0 100644 --- a/lib/Plack/Session/State.pm +++ b/lib/Plack/Session/State.pm @@ -7,7 +7,7 @@ use Digest::SHA1 (); use Plack::Util::Accessor qw[ session_key sid_generator - sid_checker + sid_validator ]; sub new { @@ -18,7 +18,7 @@ sub new { $params{'sid_generator'} ||= sub { Digest::SHA1::sha1_hex(rand() . $$ . {} . time) }; - $params{'sid_checker'} ||= qr/\A[0-9a-f]{40}\Z/; + $params{'sid_validator'} ||= qr/\A[0-9a-f]{40}\Z/; bless { %params } => $class; } @@ -39,19 +39,19 @@ sub check_expired { return $id; } -sub check_request_session_id { +sub validate_request_session_id { my ($self, $request) = @_; my $reqest_session_id = $self->get_request_session_id($request); - my $sid_checker = $self->sid_checker; + my $sid_validator = $self->sid_validator; - defined $reqest_session_id && $reqest_session_id =~ m{$sid_checker}; + defined $reqest_session_id && $reqest_session_id =~ m{$sid_validator}; } sub get_session_id { my ($self, $request) = @_; ( - $self->check_request_session_id($request) + $self->validate_request_session_id($request) && $self->extract( $request ) ) @@ -139,9 +139,9 @@ This is a CODE ref used to generate unique session ids, by default it will generate a SHA1 using fairly sufficient entropy. If you are concerned or interested, just read the source. -=item B +=item B -This is a regex used to check requested session id, +This is a regex used to validate requested session id, =back @@ -156,6 +156,8 @@ if the is expired or does not exist, it will then generate a new session. The C<$request> is expected to be a L instance or an object with an equivalent interface. +=item B + =item B This will attempt to extract the session from a C<$request> by looking