Commit | Line | Data |
a83ae797 |
1 | package Test::EOL; |
94bc2901 |
2 | # ABSTRACT: Check the correct line endings in your project |
a83ae797 |
3 | |
4 | use strict; |
5 | use warnings; |
6 | |
7 | use Test::Builder; |
8 | use File::Spec; |
a83ae797 |
9 | use File::Find; |
856d7baf |
10 | use Cwd qw/ cwd /; |
a83ae797 |
11 | |
94bc2901 |
12 | use vars qw( $PERL $UNTAINT_PATTERN $PERL_PATTERN); |
a83ae797 |
13 | |
14 | $PERL = $^X || 'perl'; |
15 | $UNTAINT_PATTERN = qr|^([-+@\w./:\\]+)$|; |
16 | $PERL_PATTERN = qr/^#!.*perl/; |
17 | |
18 | my %file_find_arg = ($] <= 5.006) ? () : ( |
19 | untaint => 1, |
20 | untaint_pattern => $UNTAINT_PATTERN, |
21 | untaint_skip => 1, |
22 | ); |
23 | |
24 | my $Test = Test::Builder->new; |
a83ae797 |
25 | |
5a0bc53a |
26 | my $no_plan; |
27 | |
a83ae797 |
28 | sub import { |
29 | my $self = shift; |
30 | my $caller = caller; |
31 | { |
32 | no strict 'refs'; |
33 | *{$caller.'::eol_unix_ok'} = \&eol_unix_ok; |
34 | *{$caller.'::all_perl_files_ok'} = \&all_perl_files_ok; |
35 | } |
36 | $Test->exported_to($caller); |
5a0bc53a |
37 | |
38 | if ($_[0] && $_[0] eq 'no_plan') { |
39 | shift; |
40 | $no_plan = 1; |
41 | } |
a83ae797 |
42 | $Test->plan(@_); |
43 | } |
44 | |
45 | sub _all_perl_files { |
46 | my @all_files = _all_files(@_); |
47 | return grep { _is_perl_module($_) || _is_perl_script($_) } @all_files; |
48 | } |
49 | |
50 | sub _all_files { |
856d7baf |
51 | my @base_dirs = @_ ? @_ : cwd(); |
52 | my $options = pop(@base_dirs) if ref $base_dirs[-1] eq 'HASH'; |
a83ae797 |
53 | my @found; |
54 | my $want_sub = sub { |
e52debaf |
55 | return if ($File::Find::dir =~ m![\\/]?CVS[\\/]|[\\/]?\.svn[\\/]!); # Filter out cvs or subversion dirs/ |
a83ae797 |
56 | return if ($File::Find::dir =~ m![\\/]?blib[\\/]libdoc$!); # Filter out pod doc in dist |
57 | return if ($File::Find::dir =~ m![\\/]?blib[\\/]man\d$!); # Filter out pod doc in dist |
27c70d46 |
58 | return if ($File::Find::dir =~ m![\\/]?inc!); # Filter out Module::Install stuff |
a83ae797 |
59 | return if ($File::Find::name =~ m!Build$!i); # Filter out autogenerated Build script |
60 | return unless (-f $File::Find::name && -r _); |
61 | push @found, File::Spec->no_upwards( $File::Find::name ); |
62 | }; |
63 | my $find_arg = { |
64 | %file_find_arg, |
65 | wanted => $want_sub, |
66 | no_chdir => 1, |
67 | }; |
68 | find( $find_arg, @base_dirs); |
69 | return @found; |
70 | } |
71 | |
f17f4176 |
72 | # Formats various human invisible symbols |
73 | # to similar visible ones. |
fe02d07d |
74 | # Perhaps ^M or something like that |
f17f4176 |
75 | # would be more appropriate? |
76 | |
fe02d07d |
77 | sub _show_whitespace { |
f17f4176 |
78 | my $string = shift; |
79 | $string =~ s/\r/[\\r]/g; |
80 | $string =~ s/\t/[\\t]/g; |
81 | $string =~ s/ /[\\s]/g; |
82 | return $string; |
83 | } |
84 | |
85 | # Format a line record for diagnostics. |
86 | |
fe02d07d |
87 | sub _debug_line { |
f17f4176 |
88 | my ( $options, $line ) = @_; |
89 | $line->[2] =~ s/\n\z//g; |
d3afcf90 |
90 | return "line $line->[1]: $line->[0]" . ( |
fe02d07d |
91 | $options->{show_lines} ? qq{: } . _show_whitespace( $line->[2] ) : q{} |
f17f4176 |
92 | ); |
93 | } |
94 | |
a83ae797 |
95 | sub eol_unix_ok { |
96 | my $file = shift; |
91613276 |
97 | my $test_txt; |
98 | $test_txt = shift if !ref $_[0]; |
939ef613 |
99 | $test_txt ||= "No incorrect line endings in '$file'"; |
91613276 |
100 | my $options = shift if ref $_[0] eq 'HASH'; |
101 | $options ||= { |
102 | trailing_whitespace => 0, |
f17f4176 |
103 | all_reasons => 0, |
91613276 |
104 | }; |
a83ae797 |
105 | $file = _module_to_path($file); |
fe02d07d |
106 | |
a83ae797 |
107 | open my $fh, $file or do { $Test->ok(0, $test_txt); $Test->diag("Could not open $file: $!"); return; }; |
f17f4176 |
108 | # Windows-- , default is :crlf, which hides \r\n -_- |
a2bfe7c3 |
109 | binmode( $fh, ':raw' ); |
a83ae797 |
110 | my $line = 0; |
f17f4176 |
111 | my @fails; |
a83ae797 |
112 | while (<$fh>) { |
113 | $line++; |
f17f4176 |
114 | if ( !$options->{trailing_whitespace} && /(\r+)$/ ) { |
115 | my $match = $1; |
116 | push @fails, [ _show_whitespace( $match ) , $line , $_ ]; |
a83ae797 |
117 | } |
f17f4176 |
118 | if ( $options->{trailing_whitespace} && /([ \t]*\r+|[ \t]+)$/ ) { |
119 | my $match = $1; |
120 | push @fails, [ _show_whitespace($match), $line , $_ ]; |
121 | } |
122 | # Minor short-circuit for people who don't need the whole file scanned |
123 | # once there's an err. |
124 | last if( @fails > 0 && !$options->{all_reasons} ); |
125 | } |
fe02d07d |
126 | if( @fails ){ |
f17f4176 |
127 | $Test->ok( 0, $test_txt . " on " . _debug_line({ show_lines => 0 } , $fails[0] ) ); |
128 | if ( $options->{all_reasons} || 1 ){ |
129 | $Test->diag( " Problem Lines: "); |
fe02d07d |
130 | for ( @fails ){ |
f17f4176 |
131 | $Test->diag(_debug_line({ show_lines => 1 } , $_ ) ); |
132 | } |
133 | } |
134 | return 0; |
a83ae797 |
135 | } |
136 | $Test->ok(1, $test_txt); |
137 | return 1; |
138 | } |
a83ae797 |
139 | sub all_perl_files_ok { |
91613276 |
140 | my $options = shift if ref $_[0] eq 'HASH'; |
a83ae797 |
141 | my @files = _all_perl_files( @_ ); |
142 | _make_plan(); |
143 | foreach my $file ( @files ) { |
91613276 |
144 | eol_unix_ok($file, $options); |
a83ae797 |
145 | } |
146 | } |
147 | |
148 | sub _is_perl_module { |
149 | $_[0] =~ /\.pm$/i || $_[0] =~ /::/; |
150 | } |
151 | |
152 | sub _is_perl_script { |
153 | my $file = shift; |
154 | return 1 if $file =~ /\.pl$/i; |
155 | return 1 if $file =~ /\.t$/; |
7ebe98c1 |
156 | open (my $fh, $file) or return; |
a83ae797 |
157 | my $first = <$fh>; |
158 | return 1 if defined $first && ($first =~ $PERL_PATTERN); |
159 | return; |
160 | } |
161 | |
162 | sub _module_to_path { |
163 | my $file = shift; |
164 | return $file unless ($file =~ /::/); |
165 | my @parts = split /::/, $file; |
166 | my $module = File::Spec->catfile(@parts) . '.pm'; |
167 | foreach my $dir (@INC) { |
168 | my $candidate = File::Spec->catfile($dir, $module); |
169 | next unless (-e $candidate && -f _ && -r _); |
170 | return $candidate; |
171 | } |
172 | return $file; |
173 | } |
174 | |
175 | sub _make_plan { |
5a0bc53a |
176 | return if $no_plan; |
a83ae797 |
177 | unless ($Test->has_plan) { |
178 | $Test->plan( 'no_plan' ); |
179 | } |
180 | $Test->expected_tests; |
181 | } |
182 | |
183 | sub _untaint { |
184 | my @untainted = map { ($_ =~ $UNTAINT_PATTERN) } @_; |
185 | return wantarray ? @untainted : $untainted[0]; |
186 | } |
187 | |
188 | 1; |
a83ae797 |
189 | |
190 | =head1 SYNOPSIS |
191 | |
936fb8fb |
192 | C<Test::EOL> lets you check for the presence of trailing whitespace and/or |
193 | windows line endings in your perl code. It reports its results in standard |
194 | C<Test::Simple> fashion: |
a83ae797 |
195 | |
196 | use Test::EOL tests => 1; |
29330dd1 |
197 | eol_unix_ok( 'lib/Module.pm', 'Module is ^M free'); |
a83ae797 |
198 | |
91613276 |
199 | and to add checks for trailing whitespace: |
200 | |
201 | use Test::EOL tests => 1; |
202 | eol_unix_ok( 'lib/Module.pm', 'Module is ^M and trailing whitespace free', { trailing_whitespace => 1 }); |
203 | |
a83ae797 |
204 | Module authors can include the following in a t/eol.t and have C<Test::EOL> |
205 | automatically find and check all perl files in a module distribution: |
206 | |
207 | use Test::EOL; |
208 | all_perl_files_ok(); |
209 | |
210 | or |
211 | |
212 | use Test::EOL; |
213 | all_perl_files_ok( @mydirs ); |
214 | |
91613276 |
215 | and if authors would like to check for trailing whitespace: |
216 | |
217 | use Test::EOL; |
218 | all_perl_files_ok({ trailing_whitespace => 1 }); |
219 | |
220 | or |
221 | |
222 | use Test::EOL; |
223 | all_perl_files_ok({ trailing_whitespace => 1 }, @mydirs ); |
224 | |
5a0bc53a |
225 | or |
226 | |
227 | use Test::More; |
228 | use Test::EOL 'no_test'; |
229 | all_perl_files_ok(); |
230 | done_testing; |
231 | |
a83ae797 |
232 | =head1 DESCRIPTION |
233 | |
234 | This module scans your project/distribution for any perl files (scripts, |
29330dd1 |
235 | modules, etc) for the presence of windows line endings. |
a83ae797 |
236 | |
237 | =head1 EXPORT |
238 | |
239 | A list of functions that can be exported. You can delete this section |
240 | if you don't export anything, such as for a purely object-oriented module. |
241 | |
936fb8fb |
242 | =func all_perl_files_ok |
243 | |
244 | all_perl_files_ok( [ \%options ], [ @directories ] ) |
a83ae797 |
245 | |
246 | Applies C<eol_unix_ok()> to all perl files found in C<@directories> (and sub |
7713e104 |
247 | directories). If no <@directories> is given, the starting point is the current |
248 | working directory, as tests are usually run from the top directory in a typical |
a83ae797 |
249 | CPAN distribution. A perl file is *.pl or *.pm or *.t or a file starting |
250 | with C<#!...perl> |
251 | |
936fb8fb |
252 | Valid C<\%options> currently are: |
253 | |
254 | =over |
255 | |
256 | =item * trailing_whitespace |
257 | |
258 | By default Test::EOL only looks for Windows (CR/LF) line-endings. Set this |
259 | to true to raise errors if any kind of trailing whitespace is present in |
260 | the file. |
261 | |
262 | =item * all_reasons |
263 | |
264 | Normally Test::EOL reports only the first error in every file (given that |
265 | a text file originated on Windows will fail every single line). Set this |
266 | a true value to register a test failure for every line with an error. |
267 | |
268 | =back |
269 | |
a83ae797 |
270 | If the test plan is defined: |
271 | |
272 | use Test::EOL tests => 3; |
273 | all_perl_files_ok(); |
274 | |
275 | the total number of files tested must be specified. |
276 | |
936fb8fb |
277 | =func eol_unix_ok |
278 | |
279 | eol_unix_ok ( $file [, $text] [, \%options ] ) |
a83ae797 |
280 | |
281 | Run a unix EOL check on C<$file>. For a module, the path (lib/My/Module.pm) or the |
936fb8fb |
282 | name (My::Module) can be both used. C<$text> is the diagnostic label emited after |
283 | the C<ok>/C<not ok> TAP output. C<\%options> takes the same values as described in |
284 | L</all_perl_files_ok>. |
a83ae797 |
285 | |
a83ae797 |
286 | =head1 ACKNOWLEDGEMENTS |
287 | |
288 | Shamelessly ripped off from L<Test::NoTabs>. |
289 | |
290 | =head1 SEE ALSO |
291 | |
292 | L<Test::More>, L<Test::Pod>. L<Test::Distribution>, L<Test:NoWarnings>, |
293 | L<Test::NoTabs>, L<Module::Install::AuthorTests>. |
294 | |
a83ae797 |
295 | =cut |