No need for addtional variable.

Remove repo dir variable and loop though newly created repos to exclude paths.

diff --git a/lib/Gitalist/Git/CollectionOfRepositories/FromDirectoryRecursive.pm b/lib/Gitalist/Git/CollectionOfRepositories/FromDirectoryRecursive.pm
index 96a303d..4f576bc 100644 (file)
--- a/lib/Gitalist/Git/CollectionOfRepositories/FromDirectoryRecursive.pm
+++ b/lib/Gitalist/Git/CollectionOfRepositories/FromDirectoryRecursive.pm
@@ -19,40 +19,37 @@ class Gitalist::Git::CollectionOfRepositories::FromDirectoryRecursive
     }
 
     method _get_path_for_repository_name (NonEmptySimpleStr $name) {
-      my $path = $self->repo_dir->subdir($name)->resolve;
-      die "Directory traversal prohibited"
-          unless $self->repo_dir->contains($path);
-      return $path;
+        my $path = $self->repo_dir->subdir($name)->resolve;
+        die "Directory traversal prohibited"
+            unless $self->repo_dir->contains($path);
+        return $path;
     }
 
     ## Builders
     method _build_repositories {
-      my @ret;
-      my @git_dirs; #don't recurse in here
-      $self->repo_dir->recurse( 
-        callback => sub {
-          my ( $dir ) = @_;
-          if ( $dir->is_dir ) {
-            for my $already_gitted ( @git_dirs ) {
-              # no need to go further if parent is git dir
-              # never have a git repo in a git repo?
-              return if ( $already_gitted->contains( $dir ) );
+        my @ret;
+        $self->repo_dir->recurse( 
+            callback => sub {
+                my ( $dir ) = @_;
+                if ( $dir->is_dir ) {
+                    for my $repo ( @ret ) {
+                        # no need to go further if parent is git dir
+                        # never have a git repo in a git repo?
+                        return if ( $repo->path->contains( $dir ) );
+                    }
+                    eval {
+                        # slight hack since get_repo expects string
+                        my @list = $dir->dir_list();
+                        my $p = $self->get_repository($list[$#list]);
+                        push @ret, $p;
+                    };
+                }
+                return;
             }
-            eval {
-              # slight hack since get_repo expects string
-              my @list = $dir->dir_list();
-              my $p = $self->get_repository($list[$#list]);
-              push @ret, $p;
-              push @git_dirs, $dir;
-            };  
-          }
-          return;
-        }
-      );
-      return \@ret;
+        );
+        return \@ret;
     }
-      
-}                                # end class
+}                         # end class
 
 __END__