Clearer error message for get_repository.

This confused me, so I made it clearer. Also added a clarifying comment to
_is_git_repo, although it could certainly be more thorough in its check.

diff --git a/lib/Gitalist/Git/CollectionOfRepositories.pm b/lib/Gitalist/Git/CollectionOfRepositories.pm
index 69243af..cea9050 100644 (file)
--- a/lib/Gitalist/Git/CollectionOfRepositories.pm
+++ b/lib/Gitalist/Git/CollectionOfRepositories.pm
@@ -14,11 +14,12 @@ role Gitalist::Git::CollectionOfRepositories {
     );
     method get_repository (NonEmptySimpleStr $name) {
         my $path = $self->_get_path_for_repository_name($name);
-        die "Not a valid git repository."
+        die "Couldn't get_repository '$name' - not a valid git repository."
             unless $self->_is_git_repo($path);
         return Repository->new( $path );
     }
     # Determine whether a given directory is a git repo.
+    # http://www.kernel.org/pub/software/scm/git/docs/gitrepository-layout.html
     method _is_git_repo ($dir) {
         return -f $dir->file('HEAD') || -f $dir->file('.git', 'HEAD');
     }

diff --git a/lib/Gitalist/Git/CollectionOfRepositories/FromDirectoryRecursive.pm b/lib/Gitalist/Git/CollectionOfRepositories/FromDirectoryRecursive.pm
index ab5701d..cba9de4 100644 (file)
--- a/lib/Gitalist/Git/CollectionOfRepositories/FromDirectoryRecursive.pm
+++ b/lib/Gitalist/Git/CollectionOfRepositories/FromDirectoryRecursive.pm
@@ -2,8 +2,6 @@ use MooseX::Declare;
 
 class Gitalist::Git::CollectionOfRepositories::FromDirectoryRecursive
     with Gitalist::Git::CollectionOfRepositories {
-      use MooseX::Types::Common::String qw/NonEmptySimpleStr/;
-      use MooseX::Types::Path::Class qw/Dir/;
 
     use MooseX::Types::Common::String qw/NonEmptySimpleStr/;
     use MooseX::Types::Path::Class qw/Dir/;
@@ -19,8 +17,7 @@ class Gitalist::Git::CollectionOfRepositories::FromDirectoryRecursive
     );
 
     method BUILD {
-      # Make sure repo_dir is an absolute path so that
-      # ->contains() works correctly.
+      # Make sure repo_dir is an absolute path so that ->contains() works correctly.
       $self->repo_dir->resolve;
     }