Clean up code

diff --git a/lib/CatalystX/HelpText/Finder/TemplateToolkit.pm b/lib/CatalystX/HelpText/Finder/TemplateToolkit.pm
index e76f2ae..9c06656 100644 (file)
--- a/lib/CatalystX/HelpText/Finder/TemplateToolkit.pm
+++ b/lib/CatalystX/HelpText/Finder/TemplateToolkit.pm
@@ -1,8 +1,8 @@
 package CatalystX::HelpText::Finder::TemplateToolkit;
 use Moose;
-use Moose::Autobox;
 use List::MoreUtils qw/ uniq /;
 use Template;
+use namespace::autoclean;
 
 sub find_helptext_keys_in_fn {
     my ($self, $fn, $script) = @_;
@@ -16,4 +16,6 @@ sub find_helptext_keys_in_fn {
     return [ uniq @keys ];
 }
 
-1;
\ No newline at end of file
+__PACKAGE__->meta->make_immutable;
+1;
+

diff --git a/lib/CatalystX/HelpText/Finder/TemplateToolkit/Regexp.pm b/lib/CatalystX/HelpText/Finder/TemplateToolkit/Regexp.pm
index 1949d83..566fb9f 100644 (file)
--- a/lib/CatalystX/HelpText/Finder/TemplateToolkit/Regexp.pm
+++ b/lib/CatalystX/HelpText/Finder/TemplateToolkit/Regexp.pm
@@ -1,19 +1,21 @@
 package CatalystX::HelpText::Finder::TemplateToolkit::Regexp;
 use Moose;
-use Moose::Autobox;
 use List::MoreUtils qw/ uniq /;
+use namespace::autoclean;
 
 sub find_helptext_keys_in_fn {
-    my ($self, $fn, $script) = @_;
-    open(FILE, $fn) or warn "Can't open $fn\n" && return;
+    my ($self, $fn) = @_;
+    open(my $FILE, '<', $fn) or warn "Can't open $fn\n" && return;
     my @keys = ();
-    while (<FILE>) {
+    while (<$FILE>) {
         if (my ($key) = m/help_text\(\s*['"](.*)['"]\s*\)/o) {
             push @keys, $key;
         }
     }
-    close(FILE);
+    close($FILE);
     return [ uniq @keys ];
 }
 
-1;
\ No newline at end of file
+__PACKAGE__->meta->make_immutable;
+
+1;